Re: [Proxool-developer] Spurious connections caused by Prototyper's apparently wrong connectionCount

[Hrvoje N. <hn...@xe...>]

Bill Horsman <arc...@gm...> writes:

> 0.8.9b6 is shortly to become RC1. There are no known problems. If
> you are able to test it in a non-production environment that would
> be very helpful.

As you're probably guessing, the problem is that we cannot reproduce
the problem in a non-production environment.  Testbeds typically don't
have that kind of heavy load and the same database access conditions.
Faithfully duplicating production workload in a testing environment is
a notoriously difficult problem.

What we can do, however, is provide the (excerpts from) Proxool logs
and the contents of AdminServlet, or any other data that can help you
locate the problem.  Just tell me if you need additional info.

>   Isn't there a hint on how I could fix the problem with the
>   Prototyper's connectionCount?  Is the protection from calling
>   reallyClose() twice the correct approach?
>
> I'm not sure. Does the number of extra connections created
> correspond with the number of reported connections that were closed
> automatically?

It's in the same ballpark, but it's hard to prove reliably because the
logs are huge and scattered over several days, and I don't have them
all at the moment.  I'll look into it and get back to you on that.

> Mitch's patch does make sense.  You might want to consider making it
> thread safe.

I can do that.  Is the additional ++connectionCount in the last hunk
of his patch also in your opinion correct?

Thanks for your help and the quick response!