Re: [Proxool-developer] Two errors in killConnecton

[Bill H. <bi...@lo...>]

Hi Dorte,

On Tue, 2004-02-10 at 10:56, Dorte Munk-Jakobsen wrote:

> oracle implementation of enqueue and dequeue on the session queues
> leaves some cursors open and after some time there is no more cursors
> left on the connection.

Ugh.

> try {
> 
> proxyConnection = (ProxyConnection)
> proxyConnections.get(nextAvailableConnection);
> 
> } catch (IndexOutOfBoundsException e) {
[snip]
> }

Thanks for that. I'll commit that fix. 

> The second is a little more subtile as you can see below:
> 
> killConnecton(String alias, long id, boolean merciful)
> 
> uses
> 
> ConnectionPoolManager.getInstance().getConnectionPool(alias).expireConnection(id, merciful);
> 
> to call:
> 
> expireConnection(long id, boolean forceExpiry)
> 
> The documentation says merciful=false => we force and the value false
> is passed to expireConnection.forceExpiry where false => don't force
> so ...
> 
> it is easy to make a work around but I suggest that you negate
> merciful when you pass it to forceExpiry.

Also done. Thanks again. 

> I wonder if you know a good site or a good book where I can learn some
> more about proxies? 

I'm not sure I can think of a simple answer to that question. Cglib
might be a good resource if you want to deep into it - that's the code
we use to implement proxies.

- Bill