[Proxool-developer] finally block throws NPE

[Hume, J. - NA US HQ D. <JH...@my...>]

Greetings ... I'm new to Proxool so forgive me if this has been discussed or
addressed, but I didn't see anything in the archives that seemed related.  

In ConnectionPool.testConnection(ProxyConnectionIF), if the
createStatement() on line 278 throws anything (for example because the
connection was unexpectedly closed), then s never gets assigned, so the
s.close() in the finally block throws a NullPointerException, preventing
testConnection from returning false.  

I know this should be a rare occurence, but it's currently happening to us
with great frequency for some unknown reason.  (We were blaming Jakarta
DBCP, which is why I was working on implementing proxool, but now it looks
like our problem lies elsewhere.)  

I added "if(s!=null)" to the beginning of line 288 to get around this.  Let
me know if you'd like me to submit this as a bug and/or patch on
sourceforge.  Thanks.  

-john.
_____________
john d. hume
 561-266-6256
 john.hume at cruisesonly.com