Re: Re: [Proxool-developer] Bug 673073

[Bill H. <bi...@lo...>]

Hi Andrew,

On Wed, 2003-02-05 at 00:15, Andrew Budarevsky wrote:

> 1. Default pool behaviour 
> <snip> the ABL should not even suspect the existence of the pool.
> That's why the pool's behaviour should be transparent as much as
> possible. 

I totally agree. As far as we know, the only time that the ABL (if you
like) needs to know about Proxool is when you are reloading apps into a
ServletContainer. In this instance, the Servlet's destroy() method is
called but the ShutdownHook isn't. But all the pools are gracefully
shutdown when the servlet container is shut down (eventually). We did
have a solution to this that used System properties but the use of
System properties is precluded by the J2EE spec. We have decided to be
compliant even though it makes this task difficult.

> 2. Work-arounds for JVMs that are not fully compatible <snip> It is
> bad idea to hardcode such work-arounds. 

I don't think we are.

> method like shutdownPool() having empty signature. The name of such
> method must correspond to action semantics. 

Yes, I agree. removeAllConnectionPools is a bad name. I will deprecate
it in favour of somethig like shutdown().

> ... currently the pool provides statistics with INFO log message type.
> In some cases it might be inconvenient. 

I agree. It is currently INFO because you often need statistics in
production (when DEBUG would likely be switched off). I think we should
add a configuration property called statistics-log-level. And if you
don't define it then nothing gets logged at all.

> Of course the customization requires from user to use pool facade
> directly. 

Not true. At least, if I understand you correctly. You can configure
Proxool using a Properties object sent to the Driver. It is the
clumsiest way of configuring it but it is there for precisely that
reason. [The JAXPConfigurator is the nicest way :)]

> I would recomьend to make a wrapper around pool facade reinitializing
> the pool on getting servlet events. 

But then what API does the wrapper adhere to? Is there a spec. for
servlets doing this?

> I am sorry for such a long essay

I welcome it. Keep it up, Andrew. Out of our differences and
misunderstandings will rise a better Proxool :)

-- 
  Bill Horsman
  Proxool
  http://proxool.sourceforge.net
  ICQ: 119577180