PROPER Optical Propagation Library Activity
Routines for wavefront propagation in IDL, Matlab, and Python
Brought to you by:
johnkrist
Activity for PROPER Optical Propagation Library
-
PROPER Optical Propagation Library released /PROPER_manual_v3.2.7a.pdf
-
-
-
-
-
-
-
-
John Krist modified ticket #12
cylindrical lens kind request
-
Requires major changes, beyond resources available.
-
Adding a cylindical lens to PROPER would require signficant changes to handle different samplings in each axis, along with separate propagations for each orthogonal component (needed because the focus is at different distances along the optical axis for such a lens). Given that this has not be requested by anyone else, and it is not needed for my own work, I cannot devote resources to make such a major rewrite. Sorry.
-
-
Ihor Berezhnyy posted a comment on ticket #12
Hello, can you please add cylindrical lens to the PROPER (Matlab) software. Thank you
-
cylindrical lens kind request
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
In Python, dm_prop works the same whether FIT=TRUE or FIT=FALSE
-
The flag options have been fixed in v3.1.5.
-
-
-
-
In Python, dm_prop works the same whether FIT=TRUE or FIT=FALSE
-
Okay. I misread your message. Looking through the codes, the line should read: if ( "FIT" in kwargs and kwargs["FIT"] ): Such checks are handled correctly nearly everywhere else. I found only a couple more such errors and will have my Python programmer fix them next week. In the meantime, unless a flag is True, don't explicitly provide it. John
-
Marcos van Dam posted a comment on ticket #11
Hello John, I agree with what you just stated. Now try proper.prop_dm( wfo, dm, 23.5, 23.5, 0.001, FIT=False ) and you will find that it behaves exactly the same way as proper.prop_dm( wfo, dm, 23.5, 23.5, 0.001, FIT=True ) Kind regards, Marcos
-
In Python, dm_prop works the same whether FIT=TRUE or FIT=FALSE
-
Hi Marcos, The code is operating correctly. If I insert messages into the prop_dm.py code like so: if "FIT" in kwargs: print( "fitting DM" ) x = (np.arange(5, dtype = np.float64) - 2) * dx_dm (blah, blah, blah) (dm_z_commanded, dms) = proper.prop_fit_dm(dm_z, inf_kernel else: print( "NOT fitting DM" ) dm_z_commanded = dm_z then I get the following results when executing the following commands using python3: proper.prop_dm( wfo, dm, 23.5, 23.5, 0.001 ) NOT fitting DM proper.prop_dm( wfo, dm, 23.5,...
-
In Python, dm_prop works the same whether FIT=TRUE or FIT=FALSE
-
-
-
-
-
-
-
-
-
-
Hi Gilles, Thanks for pointing out the bug. It has been fixed and new versions of the Python code have been uploaded to Sourceforge. Regards, John
-
-
-
-
Gilles Orban de Xivry modified a comment on discussion General Discussion
Dear PROPER developper, I think there are IDL->Python translation errors in 'prop_zernikes.py'. In particular, for eps != 0, the bitwise operator ^ is used instead of the power ** (see line 181 to 219). Best regards and thank you for PROPER, Gilles Orban de Xivry
-
Dear PROPER developper, I think there are IDL->Python translation errors in 'prop_zernikes.py'. In particular, for eps != 0, the bitwise operator ^ is used instead of the power ** (see line 181 to 219). Best regards and thank you for PROPER, Gilles Orban de Xivry -- Post-doctoral fellow Space sciences, Technologies and Astrophysics Research (STAR) Institute Université de Liège (ULg), bât. B5c 19c allée du Six Août B-4000 Sart-Tilman Tel: +32 (0)4-366.97.12
-
-
-
-
-
-
-
KDavis posted a comment on discussion General Discussion
Thank you for the above suggestion. I was able to get Proper installed into a conda environment. On a different note, I have a code suggestion for you regarding Proper. This is something I have run into trying to get proper to run prescriptions that I have defined elsewhere. For various reasons, I am running the code from a remote directory relative to where the prescriptions are stored. When I try to then run proper, I need to specify the relative location of the perscription to the prop_run.py...
-
Sorry for the delay - I had to get my Python person to figure this out. Here's what he said. Let me know if this works. Yes, I was able to create a conda environment for python 2.7 PROPER and run examples. Few points to note: Conda does not work seamlessly with pip installer. One has to install supporting packages using conda (if they are available) rather than pip and only install packages using pip that are not available in conda. Pyfits is deprecated and FITS write/read module in astropy should...
-
Has anyone tried to add proper to a conda environment? The setup.py didn't work as a pip-install on my machine. I did run the setup.py while in an environment, but it wasn't added automatically.
-
Matlab hex wavefront numbering bug
-
-
-
-
-
-
-
-
-
-
-
-
Matlab hex wavefront numbering bug
-
Hi Yinzi, Thanks for reporting this. It appears that this bug has existed since PROPER was originally released. I have uploaded fixed IDL and Matlab versions and will soon upload the Python one. Regards, John
-
-
-
1 >