Re: [Projectudi-patches] linux cross [patch 3]

[Robin F. <rob...@te...>]

>>>>> "Robert" == Robert Lipe <ro...@sc...> writes:

    Robert> Robin Farine wrote:
    >> Replace calls to strtok() with calls to strtok_r().

    Robert> We'd consciously resisted strtok_r in the common code before as it
    Robert> (amazingly) isn't part of standard C nor was it part of
    Robert> UNIX 95.

Yes, I hesitated to use it but after all, it is easy to implement in
osdep code if required.

    Robert> Oh, and please don't include major whitespace changes in the same
    Robert> patch.   It makes it harder to review.

Yeah sorry for that. Adding a new block for a local variable caused
the whole block contents to indent. In this situation, do you prefer
that one submit two patches, one with the functional change followed
by another patch with the indentation changes only?

-- 
rnf