Menu

DESTDIR installation patch

Hai-Zaar
2006-02-18
2012-12-27
  • Hai-Zaar

    Hai-Zaar - 2006-02-18

    projectM-0.97 Does not fully supports installation with DESTDIR (i.e. make DESTDIR=<path> install).

    The problem is install-data-hook Makefile.am.
    Here is the patch:
    ----------------------------------------------
    libvisual plugin does not fully supports DESTDIR.

    Signed-off-by: Hai Zaar <haizaar@gmail.com>

    --- projectM-0.97/src/lv-projectM/Makefile.am.orig  2006-02-18 16:05:30.000000000 +0200
    +++ projectM-0.97/src/lv-projectM/Makefile.am   2006-02-18 16:05:51.000000000 +0200
    @@ -28,8 +28,8 @@

    install-data-hook:
    -   chown root /etc/projectM -R
    -   chmod 755 /etc/projectM -R
    -   cp -r ../../presets_projectM/* /etc/projectM/presets
    -   chown root /etc/projectM/presets -R
    -   chmod 777 /etc/projectM/presets -R
    +   chown root $(DESTDIR)/etc/projectM -R
    +   chmod 755 $(DESTDIR)/etc/projectM -R
    +   cp -r ../../presets_projectM/* $(DESTDIR)/etc/projectM/presets
    +   chown root $(DESTDIR)/etc/projectM/presets -R
    +   chmod 777 $(DESTDIR)/etc/projectM/presets -R

     
    • Frank Roscher

      Frank Roscher - 2006-02-18

      This looks quite different in CVS... There is a separate libprojectM which uses the following:

      install-data-hook:
              chown root $(prefix)/share/projectM -R
              chmod 755 $(prefix)/share/projectM -R
              cp -r share/presets/* $(prefix)/share/projectM/presets
              chown root $(prefix)/share/projectM/presets -R
              chmod 777 $(prefix)/share/projectM/presets -R

      So I guess the problem has already been fixed.

      On the other hand, I still have to point libvisual-projectM's configure-script to my X11 headers. I wonder when that will be corrected =)

       
    • Hai-Zaar

      Hai-Zaar - 2006-02-18

      Well, actually, if you want be fully compliant, it should be in the form:
      $(DESTDIR)/$(datadir)/projectM for /usr/share.. stuff
      and
      $(DESTDIR)/$(sysconfdir)/projectM for /etc/... stuff

      If you want more abstraction, use
      $(DESTDIR)/$(datadir)/$(PACKAGE)

       
    • Frank Roscher

      Frank Roscher - 2006-02-22

      As Peter didn't post here himself: I sent him a mail to make him aware of the problem and he said he wanted to try to fix it, but apparently he doesn't know too much about the autotoolset and isn't sure if it will work.

      BTW, the release will be really soon :)

       
      • Hai-Zaar

        Hai-Zaar - 2006-02-22

        Peter has contacted me directly. I will do some ironing in Makefile.am's.

         
        • Frank Roscher

          Frank Roscher - 2006-02-22

          Great :)

           

Log in to post a comment.