#52 Subpicture: endless loop with invalid data

[Daniel Ecer]

In the Subpicture class:
while (BPos[0] < off + playtime_pos) // read sections chunk
{
int cmd_switch = Show_Bits(packet, BPos, 8); // show at first, to enable editing

switch(cmd_switch)
{
...
default:
Flush_Bits(BPos, 8); // FIX otherwise loops endless Common.setMessage(Resource.getString("subpicture.msg3") + ": " + cmd_switch);
}

The original code does not contain the Flush_Bits call in the invalid (default) case and will then loop endless (reporting the same error over and over again).

(I don't know whether just skipping a byte is the best behaviour but seem to work fine)

[Nobody/Anonymous]

Logged In: NO

yap, seems to be a missing step :) (agree to 'flushbits')
but wasn't a problem till vdr 1.5.10 has changed its packet identification to a nonconform solution