From: TJ S. <tj...@di...> - 2001-02-01 20:36:56
|
I've got the -1 UID/GID bug almost all patched up -- excerpt for one small case. At present, mod_tar.c is the only place which calls the auth_name_uid() and auth_name_gid() functions, which return uid_t and gid_t, respectively. From=20around line 267 in mod_tar.c: /* fixup uid and gid if possible */ uid =3D auth_name_uid(p,t->t_uname); gid =3D auth_name_gid(p,t->t_gname); if(uid !=3D -1) t->t_uname =3D pstrdup(p,auth_uid_name(p,uid)); if(gid !=3D -1) t->t_gname =3D pstrdup(p,auth_gid_name(p,gid)); Is that if check sufficient, or does there need to be an else? Any ideas? ---------------------------------------------------------------- TJ Saunders=09=09=09<tj...@di...> ---------------------------------------------------------------- |
From: Jesse S S. <js...@in...> - 2001-02-01 21:06:56
|
On Thu, Feb 01, 2001 at 08:36:34PM +0000, TJ Saunders wrote: > > I've got the -1 UID/GID bug almost all patched up -- excerpt for one small > case. At present, mod_tar.c is the only place which calls the > auth_name_uid() and auth_name_gid() functions, which return uid_t and > gid_t, respectively. > > >From around line 267 in mod_tar.c: > > /* fixup uid and gid if possible */ > uid = auth_name_uid(p,t->t_uname); > gid = auth_name_gid(p,t->t_gname); > > if(uid != -1) > t->t_uname = pstrdup(p,auth_uid_name(p,uid)); > if(gid != -1) > t->t_gname = pstrdup(p,auth_gid_name(p,gid)); > > Is that if check sufficient, or does there need to be an else? Any ideas? I shouldn't worry about it too much in mod_tar. I mean, that DOES probably need to go into the attic anyway. ;) -- "In the event of a failure, the system can be configured to automatically restart itself. This feature of Windows NT Server provides maximum system up-time." -- Reliability and Fault Tolerance in Windows NT Server, MSC -- To unsubscribe, send mail to pro...@pr... with "unsubscribe" in the subject field of the message. http://www.proftpd.net -- The Official ProFTPD web site. http://bugs.proftpd.net -- Bug reporting and feature requests. |
From: TJ S. <tj...@di...> - 2001-02-01 21:32:20
|
jss>I shouldn't worry about it too much in mod_tar. I mean, that DOES probably jss>need to go into the attic anyway. ;) OK. Am verifying my patch for this right now. Works for -1, but having 65535 in the UID/GID fields is causing a SEGV. Need to track that down, first. =P ---------------------------------------------------------------- TJ Saunders <tj...@di...> ---------------------------------------------------------------- -- To unsubscribe, send mail to pro...@pr... with "unsubscribe" in the subject field of the message. http://www.proftpd.net -- The Official ProFTPD web site. http://bugs.proftpd.net -- Bug reporting and feature requests. |
From: Jesse S S. <js...@in...> - 2001-02-01 22:53:23
|
On Thu, Feb 01, 2001 at 09:25:54PM +0000, TJ Saunders wrote: > > jss>I shouldn't worry about it too much in mod_tar. I mean, that DOES probably > jss>need to go into the attic anyway. ;) > > OK. Am verifying my patch for this right now. Works for -1, but having > 65535 in the UID/GID fields is causing a SEGV. Need to track that down, > first. =P Ahhh, ok, I see the problem. Your patch assumes that the return variable in the various functions always contains a valid pointer, which is not true if the handler was unable to fetch the requested data (example: calling auth_getgrgid() with a gid that doesn't have an actual entry in /etc/group). I fixed, tested with 65535 and all seems well. I'll put the new patch into bug 435 and commit to cvs. -- "In the event of a failure, the system can be configured to automatically restart itself. This feature of Windows NT Server provides maximum system up-time." -- Reliability and Fault Tolerance in Windows NT Server, MSC -- To unsubscribe, send mail to pro...@pr... with "unsubscribe" in the subject field of the message. http://www.proftpd.net -- The Official ProFTPD web site. http://bugs.proftpd.net -- Bug reporting and feature requests. |
From: Jesse S S. <js...@in...> - 2001-02-01 23:06:18
|
On Thu, Feb 01, 2001 at 05:46:41PM -0500, Jesse S Sipprell wrote: > On Thu, Feb 01, 2001 at 09:25:54PM +0000, TJ Saunders wrote: > > > > jss>I shouldn't worry about it too much in mod_tar. I mean, that DOES probably > > jss>need to go into the attic anyway. ;) > > > > OK. Am verifying my patch for this right now. Works for -1, but having > > 65535 in the UID/GID fields is causing a SEGV. Need to track that down, > > first. =P > > Ahhh, ok, I see the problem. Your patch assumes that the return variable in > the various functions always contains a valid pointer, which is not true if > the handler was unable to fetch the requested data (example: calling > auth_getgrgid() with a gid that doesn't have an actual entry in /etc/group). > I fixed, tested with 65535 and all seems well. > > I'll put the new patch into bug 435 and commit to cvs. Nevermind, I see you already got it. ;) -- "In the event of a failure, the system can be configured to automatically restart itself. This feature of Windows NT Server provides maximum system up-time." -- Reliability and Fault Tolerance in Windows NT Server, MSC -- To unsubscribe, send mail to pro...@pr... with "unsubscribe" in the subject field of the message. http://www.proftpd.net -- The Official ProFTPD web site. http://bugs.proftpd.net -- Bug reporting and feature requests. |
From: TJ S. <tj...@di...> - 2001-02-01 23:08:06
|
jss>I'll put the new patch into bug 435 and commit to cvs. Which new patch, yours or mine? ;) ---------------------------------------------------------------- TJ Saunders <tj...@di...> ---------------------------------------------------------------- -- To unsubscribe, send mail to pro...@pr... with "unsubscribe" in the subject field of the message. http://www.proftpd.net -- The Official ProFTPD web site. http://bugs.proftpd.net -- Bug reporting and feature requests. |
From: Jesse S S. <js...@in...> - 2001-02-02 01:51:17
|
On Thu, Feb 01, 2001 at 11:02:00PM +0000, TJ Saunders wrote: > > jss>I'll put the new patch into bug 435 and commit to cvs. > > Which new patch, yours or mine? ;) I ended up going with yours, which I saw right after I uploaded mine to bugzilla. Yours had nifty reporting. ;) -- "In the event of a failure, the system can be configured to automatically restart itself. This feature of Windows NT Server provides maximum system up-time." -- Reliability and Fault Tolerance in Windows NT Server, MSC -- To unsubscribe, send mail to pro...@pr... with "unsubscribe" in the subject field of the message. http://www.proftpd.net -- The Official ProFTPD web site. http://bugs.proftpd.net -- Bug reporting and feature requests. |