Re: [ProFTPD-Devel] mod_tar.c and -1 UID/GIDs...

[Jesse S S. <js...@in...>]

On Thu, Feb 01, 2001 at 08:36:34PM +0000, TJ Saunders wrote:
> 
> I've got the -1 UID/GID bug almost all patched up -- excerpt for one small
> case.  At present, mod_tar.c is the only place which calls the
> auth_name_uid() and auth_name_gid() functions, which return uid_t and
> gid_t, respectively.
> 
> >From around line 267 in mod_tar.c:
> 
>   /* fixup uid and gid if possible */
>   uid = auth_name_uid(p,t->t_uname);
>   gid = auth_name_gid(p,t->t_gname);
> 
>   if(uid != -1)
>     t->t_uname = pstrdup(p,auth_uid_name(p,uid));
>   if(gid != -1)
>     t->t_gname = pstrdup(p,auth_gid_name(p,gid));
> 
> Is that if check sufficient, or does there need to be an else?  Any ideas?

I shouldn't worry about it too much in mod_tar.  I mean, that DOES probably
need to go into the attic anyway. ;)

-- 
"In the event of a failure, the system can be configured to automatically
restart itself.  This feature of Windows NT Server provides maximum system
up-time."  -- Reliability and Fault Tolerance in Windows NT Server, MSC

--
To unsubscribe, send mail to pro...@pr... with
"unsubscribe" in the subject field of the message.

http://www.proftpd.net -- The Official ProFTPD web site.
http://bugs.proftpd.net -- Bug reporting and feature requests.