[ProFTPD-Devel] pam && empty passwords

[Arkadiusz M. <mi...@pl...>]

Hi,

I just checked cvs and saw that one bug #363 is still not fixed.
Solution is really simple:

diff -urN proftpd-1.2.0rc2.org/modules/mod_pam.c proftpd-1.2.0rc2/modules=
/mod_pam.c
--- proftpd-1.2.0rc2.org/modules/mod_pam.c	Sun Oct 22 14:19:54 2000
+++ proftpd-1.2.0rc2/modules/mod_pam.c	Sun Oct 22 14:20:16 2000
@@ -73,14 +73,14 @@
       /* PAM frees response and resp.  If you don't believe this, please=
 read
        * the actual PAM RFCs as well as have a good look at libpam.
        */
-      response[i].resp =3D (pam_user && *pam_user) ? strdup(pam_user) : =
NULL;
+      response[i].resp =3D (pam_user) ? strdup(pam_user) : NULL;
       break;
      =20
     case PAM_PROMPT_ECHO_OFF:
       /* PAM frees response and resp.  If you don't believe this, please=
 read
        * the actual PAM RFCs as well as have a good look at libpam.
        */
-      response[i].resp =3D (pam_pass && *pam_pass) ? strdup(pam_pass) : =
NULL;
+      response[i].resp =3D (pam_pass) ? strdup(pam_pass) : NULL;
       break;
      =20
     case PAM_TEXT_INFO:

Empty password is really valid. My pam segfaults when it gets NULL as res=
p.

--=20
Arkadiusz Mi=B6kiewicz, AM2-6BONE    [ PLD GNU/Linux IPv6 ]
http://www.t17.ds.pwr.wroc.pl/~misiek/ipv6/   [ enabled ]

--
To unsubscribe, send mail to pro...@pr... with
"unsubscribe" in the subject field of the message.

http://www.proftpd.net -- The Official ProFTPD web site.
http://bugs.proftpd.net -- Bug reporting and feature requests.