prboom-plus -vidmode gl -width 1920 -height 1080 -fullscreen -file boomtest.wad -warp 1
Hit the switch in front of the player.
The SW1GARG texture scrolls upwards for about 5 pixels (but no texel movement as expected). Happens only in GL mode.
I took screenshots before and after, computed the difference, and of that result, increased the contrast to max. This shows how the texture has changed.
The code comment talked about dots on wall-to-floor seams. The way I remember them, these dots were wall-to-wall (mostly 1s-to-2s, but sometimes 1s-to-1s too), and purely an artifact of the "Speed" rendering mode (itself removed in r4440).
Whether r4439 is built with SMALLDELTA=0.0f or SMALLDELTA=0.01f makes no difference, the dots are visible either way.
Therefore I think it is safe to remove SMALLDELTA altogether in today's prboom-plus.
If you grep for SMALLDOTS, you will see that it is only applied to ytop and ybottom, but never left/right. Which could explain why it only occurs on the left/right edges of a texture.
However, even though I can repro dots with r4551, the chosen value for SMALLDELTA makes no difference, there are few dots when SMALLDELTA=0 and there are few dots with SMALLDELTA=0.1f//0.01f//0.001f.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I took screenshots before and after, computed the difference, and of that result, increased the contrast to max. This shows how the texture has changed.
that's because of #define SMALLDELTA 0.001f in gl_intern.h
you can try to replace it with #define SMALLDELTA 0.0f
don't remember why 0.001 was restored
0.0
https://github.com/coelckers/prboom-plus/commit/948c28a354bf0f94fa95650bec46fbf1141a41f4
0.001 again
https://github.com/coelckers/prboom-plus/commit/8ed83163272e9c8ac57585e2b4934e777cf598e2
probably not required any more
The code comment talked about dots on wall-to-floor seams. The way I remember them, these dots were wall-to-wall (mostly 1s-to-2s, but sometimes 1s-to-1s too), and purely an artifact of the "Speed" rendering mode (itself removed in r4440).
Whether r4439 is built with SMALLDELTA=0.0f or SMALLDELTA=0.01f makes no difference, the dots are visible either way.
Therefore I think it is safe to remove SMALLDELTA altogether in today's prboom-plus.
-
I still see dots on dots.wad with SMALLDELTA 0
cfg + dsg
Last edit: Andrey Budko 2020-05-06
If you grep for SMALLDOTS, you will see that it is only applied to
ytopandybottom, but never left/right. Which could explain why it only occurs on the left/right edges of a texture.However, even though I can repro dots with r4551, the chosen value for SMALLDELTA makes no difference, there are few dots when SMALLDELTA=0 and there are few dots with SMALLDELTA=0.1f//0.01f//0.001f.