#246 Sky textures in PNG format crash the engine

[Fabian Greffrath]

Hi Andrey,

reportedly, PrBoom+ crashes with PWADs that have Sky texture lumps in PNG format, e.g.
https://www.doomworld.com/vb/post/1654792
https://www.doomworld.com/vb/post/1685876

For an example, download this WAD, load it in PrBoom+, warp to MAP02, go along the corridor and through the door in front of you and then head right:
https://www.mediafire.com/?0pb6do92zzzl2sb

I am not quite sure if this is a regression or not, but I am sure that it was once possible to properly load Sky texture flats in PNG format. Please note that this happens regardless of software or OpenGL renderer being active.

Cheers,

• Fabian

[Andrey Budko]

png lumps should be placed between hi_start and hi_end markers, and it
should be texture, not a patch (sky1 instead of rsky1)

2017-01-13 13:40 GMT+02:00 Fabian Greffrath fabian_deb@users.sf.net:

---

• [bugs:#246] https://sourceforge.net/p/prboom-plus/bugs/246/ Sky
  textures in PNG format crash the engine*

Status: open
Group: v2.2.6.
Created: Fri Jan 13, 2017 11:40 AM UTC by Fabian Greffrath
Last Updated: Fri Jan 13, 2017 11:40 AM UTC
Owner:* nobody

Hi Andrey,

reportedly, PrBoom+ crashes with PWADs that have Sky texture lumps in PNG
format, e.g.
https://www.doomworld.com/vb/post/1654792
https://www.doomworld.com/vb/post/1685876

For an example, download this WAD, load it in PrBoom+, warp to MAP02, go
along the corridor and through the door in front of you and then head right:
https://www.mediafire.com/?0pb6do92zzzl2sb

I am not quite sure if this is a regression or not, but I am sure that it
was once possible to properly load Sky texture flats in PNG format. Please
note that this happens regardless of software or OpenGL renderer being
active.

Cheers,

• Fabian

---

Sent from sourceforge.net because you indicated interest in
https://sourceforge.net/p/prboom-plus/bugs/246/

To unsubscribe from further messages, please visit
https://sourceforge.net/auth/subscriptions/

[Fabian Greffrath]

But it should be possible to identify them as PNG graphics (2nd to 4th byte read 'PNG' in PNG graphics) and give them the right treatment even if they are not enclosed between HI_START and HI_END markers?