2012/11/23 Håkan Lindqvist <hak...@en...>:
>> -----Original Message-----
>> From: Marco Stornelli [mailto:mar...@gm...]
>> Sent: den 22 november 2012 17:31
>> To: Håkan Lindqvist
>> Cc: pra...@li...
>> Subject: Re: [PATCH] Fix CONFIG_PRAMFS_WRITE_PROTECT disabled
>> prevents XIP
>>
>> Il 22/11/2012 15:07, Håkan Lindqvist ha scritto:
>> > We found a small bug in the build option handling that prevents the
>> > use of the XIP feature when built with the option
>> CONFIG_PRAMFS_WRITE_PROTECT disabled.
>> >
>> > This patch fixes this when applied to latest
>> >
>>
>> Thanks for the patch, I agree with you. However I think the latest #ifdef is
>> redundant because if protection is not compiled you can't do anything with
>> mount options and if it's not set by set_default_opts(), the option has to be
>> off, so the test with xip will be always ok.
>>
>> Marco
> I Agree, the second #ifdef is redundant from a functionality standpoint. It is
> included because I got the impression that the purpose of the build option
> is not only to reduce functionality but also to remove code that is inert with
> that option. I can resend the patch without the second #ifdef if this is
> preferable.
>
> Best regards / Håkan Lindqvist
Yep, I agree. However for the kernel coding style, the #ifdef should
be present in .h. So I prefer to avoid if possible not needed #ifdef
in .c file. If you can resend it on top of my tree I'll be happy to
apply it.
Regards,
Marco
|
