Just by looking at some GCC warnings, I'm 95% sure PractRand (0.94 + pre0.95) has some easily fixable but possibly quite serious bugs. I'm willing to contribute fixes, but it's really not clear what's the process for that. I'm a bit put off by the possibility that the bugs are already fixed in some unreleased version, because, as far as I understand, there is no development version available after pre0.95. Do you have something unreleased you're working on?
How would you feel if I imported 0.94 and pre0.95 into Git, put it on Github, and created a separate branch for my fixes? Would that fit into your workflow?
Also, are there plans to switch to Git? That would be a really good thing.
Last edit: nsajko 2020-11-24
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
As said, it contains the full history. I created a new branch development which contains some bugfixes, including the one Cerian Knight mentioned. It also fixes the WIN32 bug with the input stream in RNG_test: The problem was not buffer size related as many have said, but that stdin was not set to binary mode.
I have also made a GNUmakefile (replaced unix/Makefile), which builds out-of-source and have dependency checks. Also works well with GCC on windows! More details inside the file.
Note: I am not interested in hosting this for a long time, but I can merge pull request for a while if anyone are interested in developing. In that case, Chris will hopefully import this repository into his own at some point.
Last edit: tylov 2020-12-05
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Just by looking at some GCC warnings, I'm 95% sure PractRand (0.94 + pre0.95) has some easily fixable but possibly quite serious bugs. I'm willing to contribute fixes, but it's really not clear what's the process for that. I'm a bit put off by the possibility that the bugs are already fixed in some unreleased version, because, as far as I understand, there is no development version available after pre0.95. Do you have something unreleased you're working on?
How would you feel if I imported 0.94 and pre0.95 into Git, put it on Github, and created a separate branch for my fixes? Would that fit into your workflow?
Also, are there plans to switch to Git? That would be a really good thing.
Last edit: nsajko 2020-11-24
I did some work on this in June, and created a github repository:
https://github.com/tylov-fork/PractRand I mentioned it here: https://sourceforge.net/p/pracrand/discussion/366935/thread/86ce2d40a6/#c456
As said, it contains the full history. I created a new branch development which contains some bugfixes, including the one Cerian Knight mentioned. It also fixes the WIN32 bug with the input stream in RNG_test: The problem was not buffer size related as many have said, but that stdin was not set to binary mode.
I have also made a GNUmakefile (replaced unix/Makefile), which builds out-of-source and have dependency checks. Also works well with GCC on windows! More details inside the file.
Note: I am not interested in hosting this for a long time, but I can merge pull request for a while if anyone are interested in developing. In that case, Chris will hopefully import this repository into his own at some point.
Last edit: tylov 2020-12-05