Re: [Powerpc-utils-devel] Changes to lparstat (1.2.26)

[Nathan F. <nf...@li...>]

On 01/06/2016 01:40 AM, Sanders, Miguel wrote:
> Hi guys
> 
> How are you?
> We're currently deploying SAP HANA on POWER and I found some defects in the lparstat (1.2.26) provided by the powerpc-utils package.
> Can you please revise the attached patch files and push the code.
> 
> 1) If no count is provided, lparstat should run indefinitely given the specified interval
> 2) physc calculation has been corrected. get_time() function didn't take t.tv_usec into account properly.
> 3) %entc calculation has been corrected.
> 4) smt has been corrected. Information is now gathered from the --threads-per-core option of ppc64_cpu
> 5) user/sys/wait/idle time has been corrected. get_cpu_stat() function didn't properly calculate the percentage
> 6) shared/dedicated memory is now derived from entitled_memory_weight. entitled_memory_weight=0 indicates dedicated memory.
> 7) memory is measured in MB (like lparstat in AIX)
> 8) added function get_cpu_dispatches() (in order to calculate the diff)
> 9) added function get_cpu_interrupts() (in order to calculate the diff)
> 10) lcpu calculation has been corrected. added function get_cpu_lcpu() function.
> 11) similar to lparstat on AIX, every 21 iterations, the header is shown.

Could you submit this as a series of patches, one patch for each of the
issues you have listed. This makes it much easier to determine which changes
go with what issue that you are trying to address.

Also, please put your patches inline instead of as attachments.

-Nathan
> 
> Many thanks
> 
> Sincerely
> 
> -- 
> Met vriendelijke groeten
> Best regards
> 
> *Miguel Sanders*
> ArcelorMittal Europe – Flat Products – Business Division North
> 
> External collaborator | Midrange UNIX
> John Kennedylaan 51 B-9042 Gent
> *T* +32 9 347 52 78
> *E* gen...@ar...
> *E* mig...@ar...
> 
> 
> 
> 
> ------------------------------------------------------------------------------
> 
> 
> 
> _______________________________________________
> Powerpc-utils-devel mailing list
> Pow...@li...
> https://lists.sourceforge.net/lists/listinfo/powerpc-utils-devel
>