[Powerpc-utils-devel] [PATCH v2 1/2] nvram: fix stack overflow in logging function

[Joel S. <jo...@jm...>]

Signed-off-by: Joel Stanley <jo...@jm...>
---
 src/nvram.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/nvram.c b/src/nvram.c
index ce3f7e1..c3f4ebc 100644
--- a/src/nvram.c
+++ b/src/nvram.c
@@ -136,7 +136,7 @@ help(void)
  * @def MAXLINE
  * @brief maximum line length
  */
-#define MAXLINE		4096
+#define MAXLINE		512
 
 /**
  * _msg
@@ -152,10 +152,10 @@ _msg(int msg_type, const char *fmt, va_list ap)
     int	n;
     char buf[MAXLINE];
 
-    n = sprintf(buf, "%s: %s", nvram_cmdname, 
+    n = snprintf(buf, sizeof(buf), "%s: %s", nvram_cmdname,
 		(msg_type == WARN_MSG ? "WARNING: " : "ERROR: "));
 
-    vsprintf(buf + n, fmt, ap);
+    vsnprintf(buf + n, sizeof(buf) - n, fmt, ap);
 
     fflush(stderr);
     fputs(buf, stderr);
-- 
2.1.4