Re: [Powerpc-utils-devel] [PATCH]Fix to check for drmgr REPLACE (-R) flag

[Nathan F. <nf...@li...>]

On 03/16/2015 05:28 AM, Mamatha Inamdar wrote:
> In drmgr command drmgr -R (REPLACE) flag check was missing, so
> this patch is to fix drmgr -R flag in valid_pci_options() interface.
> 
> *************************************************
> Test results:
> 
> before fixing the patch:
> # drmgr -c pci -s U78CD.001.FZH0003-P2-C3 -R
> The '-r', '-a', or '-i' option must be spcified for PCI operation
> 
> After fixing the patch:
> 
> # ./src/drmgr/drmgr -c pci -s U78CD.001.FZH0003-P2-C3 -R
> The specified PCI slot is either invalid
> or does not support hot plug operations.xing the patch:
> **************************************************************
> 
> Signed-off-by: Mamatha Inamdar <mam...@li...>
> ---
>  0 files changed
> 
> diff --git a/src/drmgr/drslot_chrp_pci.c b/src/drmgr/drslot_chrp_pci.c
> index 0c8de2f..1f9f994 100644
> --- a/src/drmgr/drslot_chrp_pci.c
> +++ b/src/drmgr/drslot_chrp_pci.c
> @@ -855,7 +855,7 @@ valid_pci_options(struct options *opts)
>  	}
> 
>  	if ((opts->action != ADD) && (opts->action != REMOVE)
> -	    && (opts->action != IDENTIFY)) {
> +	    && (opts->action != IDENTIFY) && (opts->action != REPLACE)) {
>  		say(ERROR, "The '-r', '-a', or '-i' option must be spcified "
>  	 	    "for PCI operations\n");

We should also update the error message to include -R.

-Nathan

>  		return -1;
> 
> 
> ------------------------------------------------------------------------------
> Dive into the World of Parallel Programming The Go Parallel Website, sponsored
> by Intel and developed in partnership with Slashdot Media, is your hub for all
> things parallel software development, from weekly thought leadership blogs to
> news, videos, case studies, tutorials and more. Take a look and join the 
> conversation now. http://goparallel.sourceforge.net/
> _______________________________________________
> Powerpc-utils-devel mailing list
> Pow...@li...
> https://lists.sourceforge.net/lists/listinfo/powerpc-utils-devel
>