Menu
▾
▴
Re: [Powerpc-utils-devel] [PATCH] Powerpc-utils: Restrict the usage of snap on RHEL 7 onwards
|
From: Vasant H. <heg...@li...> - 2015-01-08 05:40:16
|
On 12/18/2014 03:23 AM, Nathan Fontenot wrote:
> On 12/14/2014 11:39 PM, Vasant Hegde wrote:
>> On 12/05/2014 04:11 PM, Henish Patel wrote:
>>> snap is not supported on the RHEL 7 onwards, because we have integrated snap
>>> functionality in sosreport. So this patch displays a suitable message on
>>> usage of snap tool. RHEL 7+ users can use sosreport to collect log data.
>>>
>>
>> Nathan,
>>
>>
>>> Signed-off-by: Henish Patel <hp...@li...>
>>
>> As you are aware we are trying to standardize data collection tool rather than
>> having separate tool for Power.. We have made necessary changes in distro
>> provided tools (sosreport for RH) to collect required data.. Also any future
>> changes goes to distro provided tools only..
>>
>
> Not a problem.
>
> Do you know if there is any work to do this same thing for the other distro's?
Yes .. We are planning to deprecate for SLES12 onwards as well.. We have pushed
all required changes to supportconfig command.. Let me confirm we have everything
in supportconfig.. Then will send out another patch.
>
> It appears we are on a path to deprecate this command, I'm just trying to figure
> out what the timeline for that looks like.
All n-1 distro releases (like RHEL 6.x , SLES11.x) contains snap command. And we
have not
enabled distro provided tools in those releases to collect Power specific
information..
So should we carry this command for sometime in upstream or deprecate right way?
Note that RH is removed this command from RHEL7.1 onwards.. likewise recently
its removed
from Fedora as well.
-Vasant
>
> -Nathan
>
>> Hence this patch adds necessary message to snap...
>>
>>
>> Reviewed-by: Vasant Hegde <heg...@li...>
>>
>>
>> -Vasant
>>
>>> ---
>>> scripts/snap | 14 +++++++++++++-
>>> 1 file changed, 13 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/scripts/snap b/scripts/snap
>>> index 3e547e6..1bede61 100755
>>> --- a/scripts/snap
>>> +++ b/scripts/snap
>>> @@ -34,7 +34,19 @@ my $outfile = "snap.tar.gz"; # in the working dir.
>>> my $cmddir = "snap_commands"; # cmd output dir.
>>> my $cmdoutdir = "$outdir/$cmddir"; # in outdir dir.
>>> my $rsxx_exists = 0; # Does an IBM Flash Adapter exist?
>>> -my $distro_file = "/etc/issue"
>>> +my $distro_file = "/etc/issue";
>>> +my $redhat_release_file = "/etc/redhat-release";
>>> +
>>> +if (-e $redhat_release_file) {
>>> + open(RELEASE, "< $redhat_release_file") or die "open: $!\n";
>>> + $_ = <RELEASE>;
>>> + my $redhat_version = (split / /, $_)[6];
>>> + if ($redhat_version > 7.0) {
>>> + print "snap: is not supported on the RHEL 7 onwards..!\n";
>>> + print "Please use sosreport to collect log data..!! \n";
>>> + exit 1;
>>> + }
>>> +}
>>>
>>> our($opt_a, $opt_d, $opt_h, $opt_o, $opt_t, $opt_v);
>>>
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
>>> from Actuate! Instantly Supercharge Your Business Reports and Dashboards
>>> with Interactivity, Sharing, Native Excel Exports, App Integration & more
>>> Get technology previously reserved for billion-dollar corporations, FREE
>>> http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
>>> _______________________________________________
>>> Powerpc-utils-devel mailing list
>>> Pow...@li...
>>> https://lists.sourceforge.net/lists/listinfo/powerpc-utils-devel
>>>
>>
>>
>> ------------------------------------------------------------------------------
>> Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
>> from Actuate! Instantly Supercharge Your Business Reports and Dashboards
>> with Interactivity, Sharing, Native Excel Exports, App Integration & more
>> Get technology previously reserved for billion-dollar corporations, FREE
>> http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
>> _______________________________________________
>> Powerpc-utils-devel mailing list
>> Pow...@li...
>> https://lists.sourceforge.net/lists/listinfo/powerpc-utils-devel
>>
|
