Re: [Powerpc-utils-devel] [PATCH] drmgr/lsslot: Fix broken memory support for little endian

[Nathan F. <nf...@li...>]

Pulled into -next.

Thanks,
-Nathan

On 12/04/2014 11:33 AM, Thomas Falcon wrote:
> Commit 493bfdda30b61be46d7d71e5e7bb05df9334ba81 should have removed
> some endian conversions included in previous commit. Unfortunately,
> they were not removed, causing problems when hotplugging memory.
> This patch removes those endian conversions.
> 
> Signed-off-by: Thomas Falcon <tlf...@li...>
> ---
>  src/drmgr/drslot_chrp_mem.c | 11 +----------
>  1 file changed, 1 insertion(+), 10 deletions(-)
> 
> diff --git a/src/drmgr/drslot_chrp_mem.c b/src/drmgr/drslot_chrp_mem.c
> index a867894..6c2ac07 100644
> --- a/src/drmgr/drslot_chrp_mem.c
> +++ b/src/drmgr/drslot_chrp_mem.c
> @@ -298,11 +298,6 @@ get_dynamic_reconfig_lmbs(struct lmb_list_head *lmb_list)
>  	for (i = 0; i < num_entries; i++) {
>  		struct dr_node *lmb;
> 
> -		/* convert for LE systems */
> -		drmem->address = be64toh(drmem->address);
> -		drmem->drc_index = be32toh(drmem->drc_index);
> -		drmem->flags = be32toh(drmem->flags);
> -
>  		for (lmb = lmb_list->lmbs; lmb; lmb = lmb->next) {
>  			if (lmb->drc_index == be32toh(drmem->drc_index))
>  				break;
> @@ -576,11 +571,7 @@ update_drconf_node(struct dr_node *lmb, struct lmb_list_head *lmb_list,
> 
>  	for (i = 0; i < entries; i++) {
> 
> -		/* convert for LE systems */
> -		drmem->drc_index = be32toh(drmem->drc_index);
> -		drmem->flags = be32toh(drmem->flags);
> -
> -		if (drmem->drc_index != lmb->drc_index) {
> +		if (be32toh(drmem->drc_index) != lmb->drc_index) {
>  			drmem++;
>  			continue;
>  		}
>