postgres-xc-developers

Re: [Postgres-xc-developers] Default value of PRIMARY and PREFERRED is wrong(CREATE NODE)

[鈴木 幸市 <ko...@in...>]

This is document change which describes the current code more closely.

Any more suggestions?  For example, changing the default as described in the current doc?

Regards;
---
Koichi Suzuki



On 2013/07/17, at 11:16, Masataka Saito <pg...@gm...> wrote:

> Hello all.
> 
> I found creating nodes without PRIMARY and PREFERRED parameters not works like the description of the documentation.
> 
> The documentation says the default value of PRIMARY and PREFERRED is true.
> But unspecifying them to CREATE NODE creates non-primary / non-preferred node.
> 
> Documentation:
> > PRIMARY
> >  A boolean value can be specified. In case no value is specified, PRIMARY acts like true.
> > PREFERRED
> >  A boolean value can be specified. In case no value is specified, PREFERRED acts like true.
> 
> cx=# create node data03 WITH (host='localhost',port=5444, type=datanode);
> CREATE NODE
> cx=# select * from pg_catalog.pgxc_node ;
> node_name | node_type | node_port | node_host | nodeis_primary | nodeis_preferred | node_id 
> -----------+-----------+-----------+-----------+----------------+------------------+-------------
> coord01 | C | 5432 | localhost | f | f | -951114102
> data03 | D | 5444 | localhost | f | f | 1867970210
> (2 rows)
> 
> I speculate that it is bugs of documentation because specifying true for PRIMARY/PREFERRED marks the node special and I think the default value should be false.
> 
> I wrote a patch to the documentation and attached to this mail.
> 
> Regards.
> <create_node_doc_fix.patch>------------------------------------------------------------------------------
> See everything from the browser to the database with AppDynamics
> Get end-to-end visibility with application monitoring from AppDynamics
> Isolate bottlenecks and diagnose root cause in seconds.
> Start your free trial of AppDynamics Pro today!
> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk_______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers

Re: [Postgres-xc-developers] Default value of PRIMARY and PREFERRED is wrong(CREATE NODE)

[Michael P. <mic...@gm...>]

On Wed, Jul 17, 2013 at 1:59 PM, 鈴木 幸市 <ko...@in...> wrote:
> This is document change which describes the current code more closely.
>
> Any more suggestions?  For example, changing the default as described in the
> current doc?
Nope. This patch is correct and should be backpatched down to 1.0.
--
Michael