Thread: [Postgres-xc-developers] Not just type error?

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 422-6466

Hi all,

I just found something maybe wrong on the branch origin/REL1_2_STABLE.

Please have a check. Patch attached.

Sorry,Not just one.  Update the attachment.

2014-12-22 16:50 GMT+08:00 Jaimin Pan <jai...@gm...>:

> Hi all,
>
> I just found something maybe wrong on the branch origin/REL1_2_STABLE.
>
> Please have a check. Patch attached.
>

This file was brought from PG repo.    Do you think it is specific to
XC?   We may need to investigate how such difference came.

Best;
---
Koichi Suzuki

2014-12-22 18:06 GMT+09:00 Jaimin Pan <jai...@gm...>:
> Sorry,Not just one.  Update the attachment.
>
> 2014-12-22 16:50 GMT+08:00 Jaimin Pan <jai...@gm...>:
>>
>> Hi all,
>>
>> I just found something maybe wrong on the branch origin/REL1_2_STABLE.
>>
>> Please have a check. Patch attached.
>
>
>
> ------------------------------------------------------------------------------
> Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
> from Actuate! Instantly Supercharge Your Business Reports and Dashboards
> with Interactivity, Sharing, Native Excel Exports, App Integration & more
> Get technology previously reserved for billion-dollar corporations, FREE
> http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>

I check the PG repo master branch(latest commit in my view
d69ffd6f035fe24483247bf9b2335d7474eaf31a).
And there is no such error, seem no modified ever.

2014-12-22 20:56 GMT+08:00 Koichi Suzuki <koi...@gm...>:

> This file was brought from PG repo.    Do you think it is specific to
> XC?   We may need to investigate how such difference came.
>
> Best;
> ---
> Koichi Suzuki
>
>
> 2014-12-22 18:06 GMT+09:00 Jaimin Pan <jai...@gm...>:
> > Sorry,Not just one.  Update the attachment.
> >
> > 2014-12-22 16:50 GMT+08:00 Jaimin Pan <jai...@gm...>:
> >>
> >> Hi all,
> >>
> >> I just found something maybe wrong on the branch origin/REL1_2_STABLE.
> >>
> >> Please have a check. Patch attached.
> >
> >
> >
> >
> ------------------------------------------------------------------------------
> > Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
> > from Actuate! Instantly Supercharge Your Business Reports and Dashboards
> > with Interactivity, Sharing, Native Excel Exports, App Integration & more
> > Get technology previously reserved for billion-dollar corporations, FREE
> >
> http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
> > _______________________________________________
> > Postgres-xc-developers mailing list
> > Pos...@li...
> > https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
> >
>

On Tue, Dec 23, 2014 at 1:57 PM, Jaimin Pan <jai...@gm...> wrote:
> I check the PG repo master branch(latest commit in my view
> d69ffd6f035fe24483247bf9b2335d7474eaf31a).
> And there is no such error, seem no modified ever.
I disagree, per se this commit in Postgres:
commit: 5242fefb471d1fb2d0f35a33bde3570e19acd4b1
author: Tom Lane <tg...@ss...>
date: Sat, 15 Jun 2013 14:11:43 -0400
Be consistent about #define'ing configure symbols as "1" not empty.

This is just neatnik-ism, since all the tests in the code are #ifdefs,
but we shouldn't specify symbols as "Define to 1 ..." and then not
actually define them that way.

The usual policy here is not to fix problems with upstream directly,
but to get them merged from upstream. Hence I don't think your patch
should be merged, but we should re-sync with Postgres itself.
-- 
Michael

Thanks Michael.   It was what I was considering.   I agree that we
shouldn't get upstream patches before we merge them into XC.

Appreciate for your comment.
---
Koichi Suzuki

2014-12-24 8:38 GMT+09:00 Michael Paquier <mic...@gm...>:
> On Tue, Dec 23, 2014 at 1:57 PM, Jaimin Pan <jai...@gm...> wrote:
>> I check the PG repo master branch(latest commit in my view
>> d69ffd6f035fe24483247bf9b2335d7474eaf31a).
>> And there is no such error, seem no modified ever.
> I disagree, per se this commit in Postgres:
> commit: 5242fefb471d1fb2d0f35a33bde3570e19acd4b1
> author: Tom Lane <tg...@ss...>
> date: Sat, 15 Jun 2013 14:11:43 -0400
> Be consistent about #define'ing configure symbols as "1" not empty.
>
> This is just neatnik-ism, since all the tests in the code are #ifdefs,
> but we shouldn't specify symbols as "Define to 1 ..." and then not
> actually define them that way.
>
> The usual policy here is not to fix problems with upstream directly,
> but to get them merged from upstream. Hence I don't think your patch
> should be merged, but we should re-sync with Postgres itself.
> --
> Michael