Thread: [Postgres-xc-developers] Fix for compile duo to Bison 3.0 update

Brought to you by: ahsanhadi, amitdkhan, ashutoshbapat, gabbasb, and 3 others

postgres-xc-developers

[Postgres-xc-developers] Fix for compile duo to Bison 3.0 update

From: Jure K. <j....@gm...> - 2013-08-12 20:28:58

Attachments: signature.asc bison-parse-params-fix.patch

Since Bison 3.0 they stopped support for YYPARSE_PARAM, which is used in
contrib/cube and contrib/seg. More can be read at:
http://www.postgresql.org/message-id/736...@ss...

There is a patch for PostgreSQL which fixes this but doesn't apply clean on
Postgres-XC 1.0.3 without some minor changes.

Attached is the patch for 1.0.3. Tested with bison 3.0 and 2.7.1. Both compile
without errors.

--
Regards,
Jure Kobal

Re: [Postgres-xc-developers] Fix for compile duo to Bison 3.0 update

From: Michael P. <mic...@gm...> - 2013-08-19 01:48:20

On Tue, Aug 13, 2013 at 5:28 AM, Jure Kobal <j....@gm...> wrote:
> Since Bison 3.0 they stopped support for YYPARSE_PARAM, which is used in
> contrib/cube and contrib/seg. More can be read at:
> http://www.postgresql.org/message-id/736...@ss...
>
> There is a patch for PostgreSQL which fixes this but doesn't apply clean on
> Postgres-XC 1.0.3 without some minor changes.
>
> Attached is the patch for 1.0.3. Tested with bison 3.0 and 2.7.1. Both compile
> without errors.
Yes, this is definitely something to be aware of, but -1 for the patch
as this fix has been committed in the Postgres code tree, and XC
should directly pick it up from there by merging all its active
branches with the latest commits of postgres.
-- 
Michael

Re: [Postgres-xc-developers] Fix for compile duo to Bison 3.0 update

From: Jure K. <j....@gm...> - 2013-08-21 18:47:16

On 19. 08. 2013 03:48, Michael Paquier wrote:
> On Tue, Aug 13, 2013 at 5:28 AM, Jure Kobal <j....@gm...> wrote:
>> Since Bison 3.0 they stopped support for YYPARSE_PARAM, which is used in
>> contrib/cube and contrib/seg. More can be read at:
>> http://www.postgresql.org/message-id/736...@ss...
>>
>> There is a patch for PostgreSQL which fixes this but doesn't apply clean on
>> Postgres-XC 1.0.3 without some minor changes.
>>
>> Attached is the patch for 1.0.3. Tested with bison 3.0 and 2.7.1. Both compile
>> without errors.
> Yes, this is definitely something to be aware of, but -1 for the patch
> as this fix has been committed in the Postgres code tree, and XC
> should directly pick it up from there by merging all its active
> branches with the latest commits of postgres.
> 

Sorry for that. Didn't know about the merge process between postgresql and
postgres-xc. Will keep it in mind in th future.

--
Regards,
Jure

Re: [Postgres-xc-developers] Fix for compile duo to Bison 3.0 update

From: Koichi S. <koi...@gm...> - 2013-08-19 01:54:16

Hmm... As Michael suggested, applying this patch only locally to XC will
make it difficult to keep XC code synchronized with vanilla PG.    We
should wait until this patch is included in vanilla PG.

Regards;
---
Koichi Suzuki


2013/8/19 Michael Paquier <mic...@gm...>

> On Tue, Aug 13, 2013 at 5:28 AM, Jure Kobal <j....@gm...> wrote:
> > Since Bison 3.0 they stopped support for YYPARSE_PARAM, which is used in
> > contrib/cube and contrib/seg. More can be read at:
> > http://www.postgresql.org/message-id/736...@ss...
> >
> > There is a patch for PostgreSQL which fixes this but doesn't apply clean
> on
> > Postgres-XC 1.0.3 without some minor changes.
> >
> > Attached is the patch for 1.0.3. Tested with bison 3.0 and 2.7.1. Both
> compile
> > without errors.
> Yes, this is definitely something to be aware of, but -1 for the patch
> as this fix has been committed in the Postgres code tree, and XC
> should directly pick it up from there by merging all its active
> branches with the latest commits of postgres.
> --
> Michael
>
>
> ------------------------------------------------------------------------------
> Get 100% visibility into Java/.NET code with AppDynamics Lite!
> It's a free troubleshooting tool designed for production.
> Get down to code-level detail for bottlenecks, with <2% overhead.
> Download for free and get started troubleshooting in minutes.
> http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>

Re: [Postgres-xc-developers] Fix for compile duo to Bison 3.0 update

From: Michael P. <mic...@gm...> - 2013-08-19 02:02:52

On Mon, Aug 19, 2013 at 10:54 AM, Koichi Suzuki <koi...@gm...> wrote:
> Hmm... As Michael suggested, applying this patch only locally to XC will
> make it difficult to keep XC code synchronized with vanilla PG.    We should
> wait until this patch is included in vanilla PG.
Actually it has been committed a couple of weeks ago and back-patched
to all the supported branches:
- master: 55cbfa5
- REL9_3_STABLE: 8cbf8df
- REL9_2_STABLE: 9822dc3
- REL9_1_STABLE: aa49821

Regards,
-- 
Michael

Re: [Postgres-xc-developers] Fix for compile duo to Bison 3.0 update

From: Koichi S. <koi...@gm...> - 2013-08-19 02:28:03

Thanks.   They will be included in the next minor, if it is available as a
part of PG minor release.

Regards;
---
Koichi Suzuki


2013/8/19 Michael Paquier <mic...@gm...>

> On Mon, Aug 19, 2013 at 10:54 AM, Koichi Suzuki <koi...@gm...>
> wrote:
> > Hmm... As Michael suggested, applying this patch only locally to XC will
> > make it difficult to keep XC code synchronized with vanilla PG.    We
> should
> > wait until this patch is included in vanilla PG.
> Actually it has been committed a couple of weeks ago and back-patched
> to all the supported branches:
> - master: 55cbfa5
> - REL9_3_STABLE: 8cbf8df
> - REL9_2_STABLE: 9822dc3
> - REL9_1_STABLE: aa49821
>
> Regards,
> --
> Michael
>