Menu
▾
▴
postgres-xc-developers
|
From: Abbas B. <abb...@en...> - 2013-09-30 02:23:56
|
Hi, The current implementation of event triggers assumes that any statment that is not handeled by the main switch-case in standard_ProcessUtility supports event triggers. CLEAN CONNECTION is a new statement added by XC and does not support event triggers as of now. This patch is intended for the master_pg93_merge branch and applies cleanly on top of the following two patches. 20130924_01.patch and fix_for_pooler_socket_20130926.patch Regards -- *Abbas* Architect Ph: 92.334.5100153 Skype ID: gabbasb www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/> * Follow us on Twitter* @EnterpriseDB Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community> |
|
From: Abbas B. <abb...@en...> - 2013-09-30 02:31:22
Attachments:
3_1_clean_con.patch
|
Here is the patch, forgot to attach it with the previous mail. Regards On Mon, Sep 30, 2013 at 7:23 AM, Abbas Butt <abb...@en...> wrote: > > Hi, > The current implementation of event triggers assumes that any statment > that is not handeled by the main switch-case in standard_ProcessUtility > supports event triggers. > CLEAN CONNECTION is a new statement added by XC and does not support > event triggers as of now. > > This patch is intended for the master_pg93_merge branch and applies cleanly > on top of the following two patches. > 20130924_01.patch and fix_for_pooler_socket_20130926.patch > > Regards > -- > Abbas > Architect > > Ph: 92.334.5100153 > Skype ID: gabbasb > www.enterprisedb.com > > Follow us on Twitter > @EnterpriseDB > > Visit EnterpriseDB for tutorials, webinars, whitepapers and more -- -- Abbas Architect Ph: 92.334.5100153 Skype ID: gabbasb www.enterprisedb.com Follow us on Twitter @EnterpriseDB Visit EnterpriseDB for tutorials, webinars, whitepapers and more On Mon, Sep 30, 2013 at 7:23 AM, Abbas Butt <abb...@en...> wrote: > > Hi, > The current implementation of event triggers assumes that any statment > that is not handeled by the main switch-case in standard_ProcessUtility > supports event triggers. > CLEAN CONNECTION is a new statement added by XC and does not support > event triggers as of now. > > This patch is intended for the master_pg93_merge branch and applies cleanly > on top of the following two patches. > 20130924_01.patch and fix_for_pooler_socket_20130926.patch > > Regards > -- > Abbas > Architect > > Ph: 92.334.5100153 > Skype ID: gabbasb > www.enterprisedb.com > > Follow us on Twitter > @EnterpriseDB > > Visit EnterpriseDB for tutorials, webinars, whitepapers and more -- -- Abbas Architect Ph: 92.334.5100153 Skype ID: gabbasb www.enterprisedb.com Follow us on Twitter @EnterpriseDB Visit EnterpriseDB for tutorials, webinars, whitepapers and more |
|
From: Koichi S. <koi...@gm...> - 2013-10-22 02:12:32
|
(Please take a look at WIP branch master_pg93_merge).
I reviewed this patch and found that this patch handles CLEAN CONNECTION as
simply NOP.
To disable event trigger for some DDLs, we need to move the code from
ProcessUtilitySlow() to Standard_ProcessUtility(). My previous patch was
not sufficient. We need to move the code for XC-specific DDLs in this
manner.
I don't think this change affects regression test.
DDL handling was done as follows:
(outside) --> ProcessUtility() /* ProcessUtility_hook is handled here */
--> standard_ProcessUtility() /* DDLs without event
trigger support are handled here */
--> ProcessUtilitySlow() /* DDLs with event trigger
support are handled here */
3_1_clean_con.patch just returns from standard_ProcessUtility() without
doing anything. Unfortunately, CLEAN CONNECTION HANDLER is now in
ProcessUtilitySlow() and this should be moved back to
standard_ProcessUtility().
Any thoughts?
---
Koichi Suzuki
2013/9/30 Abbas Butt <abb...@en...>
> Here is the patch, forgot to attach it with the previous mail.
> Regards
>
>
>
> On Mon, Sep 30, 2013 at 7:23 AM, Abbas Butt <abb...@en...>
> wrote:
> >
> > Hi,
> > The current implementation of event triggers assumes that any statment
> > that is not handeled by the main switch-case in standard_ProcessUtility
> > supports event triggers.
> > CLEAN CONNECTION is a new statement added by XC and does not support
> > event triggers as of now.
> >
> > This patch is intended for the master_pg93_merge branch and applies
> cleanly
> > on top of the following two patches.
> > 20130924_01.patch and fix_for_pooler_socket_20130926.patch
> >
> > Regards
> > --
> > Abbas
> > Architect
> >
> > Ph: 92.334.5100153
> > Skype ID: gabbasb
> > www.enterprisedb.com
> >
> > Follow us on Twitter
> > @EnterpriseDB
> >
> > Visit EnterpriseDB for tutorials, webinars, whitepapers and more
>
>
>
>
> --
> --
> Abbas
> Architect
>
> Ph: 92.334.5100153
> Skype ID: gabbasb
> www.enterprisedb.com
>
> Follow us on Twitter
> @EnterpriseDB
>
> Visit EnterpriseDB for tutorials, webinars, whitepapers and more
>
>
> On Mon, Sep 30, 2013 at 7:23 AM, Abbas Butt <abb...@en...>
> wrote:
> >
> > Hi,
> > The current implementation of event triggers assumes that any statment
> > that is not handeled by the main switch-case in standard_ProcessUtility
> > supports event triggers.
> > CLEAN CONNECTION is a new statement added by XC and does not support
> > event triggers as of now.
> >
> > This patch is intended for the master_pg93_merge branch and applies
> cleanly
> > on top of the following two patches.
> > 20130924_01.patch and fix_for_pooler_socket_20130926.patch
> >
> > Regards
> > --
> > Abbas
> > Architect
> >
> > Ph: 92.334.5100153
> > Skype ID: gabbasb
> > www.enterprisedb.com
> >
> > Follow us on Twitter
> > @EnterpriseDB
> >
> > Visit EnterpriseDB for tutorials, webinars, whitepapers and more
>
>
>
>
> --
> --
> Abbas
> Architect
>
> Ph: 92.334.5100153
> Skype ID: gabbasb
> www.enterprisedb.com
>
> Follow us on Twitter
> @EnterpriseDB
>
> Visit EnterpriseDB for tutorials, webinars, whitepapers and more
>
>
> ------------------------------------------------------------------------------
> October Webinars: Code for Performance
> Free Intel webinars can help you accelerate application performance.
> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most
> from
> the latest Intel processors and coprocessors. See abstracts and register >
> http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>
>
|
|
From: Michael P. <mic...@gm...> - 2013-09-30 05:02:30
|
On Mon, Sep 30, 2013 at 11:23 AM, Abbas Butt <abb...@en...> wrote: > The current implementation of event triggers assumes that any statment > that is not handeled by the main switch-case in standard_ProcessUtility > supports event triggers. > CLEAN CONNECTION is a new statement added by XC and does not support > event triggers as of now. I would agree not to support event triggers at all for event triggers. You can have a look at the commands that work with event triggers here: http://www.postgresql.org/docs/9.3/static/event-trigger-matrix.html You would notice that only a subset of CREATE/ALTER/DROP commands is supported only. There is nothing like for example CLUSTER or VACUUM, etc. -- Michael |
|
From: 鈴木 幸市 <ko...@in...> - 2013-09-30 07:19:21
|
Do you agree not to support event triggers because it does support only a subset of CREATE/ALTER/DROP or XC architecture needs extra improvement? --- Koichi Suzuki On 2013/09/30, at 14:02, Michael Paquier <mic...@gm...> wrote: > On Mon, Sep 30, 2013 at 11:23 AM, Abbas Butt > <abb...@en...> wrote: >> The current implementation of event triggers assumes that any statment >> that is not handeled by the main switch-case in standard_ProcessUtility >> supports event triggers. >> CLEAN CONNECTION is a new statement added by XC and does not support >> event triggers as of now. > I would agree not to support event triggers at all for event triggers. > You can have a look at the commands that work with event triggers > here: > http://www.postgresql.org/docs/9.3/static/event-trigger-matrix.html > You would notice that only a subset of CREATE/ALTER/DROP commands is > supported only. There is nothing like for example CLUSTER or VACUUM, > etc. > -- > Michael > > ------------------------------------------------------------------------------ > October Webinars: Code for Performance > Free Intel webinars can help you accelerate application performance. > Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from > the latest Intel processors and coprocessors. See abstracts and register > > http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk > _______________________________________________ > Postgres-xc-developers mailing list > Pos...@li... > https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers > |
|
From: Michael P. <mic...@gm...> - 2013-09-30 09:54:03
|
On Mon, Sep 30, 2013 at 4:19 PM, 鈴木 幸市 <ko...@in...> wrote: > Do you agree not to support event triggers because it does support only a subset of CREATE/ALTER/DROP or XC architecture needs extra improvement? Supporting event triggers would be a nice thing, just I don't see why it would be necessary for CLEAN CONNECTION. -- Michael |
|
From: 鈴木 幸市 <ko...@in...> - 2013-10-01 00:58:21
|
Hmmm. I don't see clear background that CLEAN CONNECTION should have its event trigger either. --- Koichi Suzuki On 2013/09/30, at 18:53, Michael Paquier <mic...@gm...> wrote: > On Mon, Sep 30, 2013 at 4:19 PM, 鈴木 幸市 <ko...@in...> wrote: >> Do you agree not to support event triggers because it does support only a subset of CREATE/ALTER/DROP or XC architecture needs extra improvement? > Supporting event triggers would be a nice thing, just I don't see why > it would be necessary for CLEAN CONNECTION. > -- > Michael > |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X