postgres-xc-developers — Postgres-XC hackers and developers

Re: [Postgres-xc-developers] Fix for test case xc_misc

[Ashutosh B. <ash...@en...>]

This looks good, except a cosmetic change.
The condition here is a && (b || c) && d. When spread across multiple
lines, it should be properly indented like
a &&
(b ||
   c) &&
d

so that AND/OR hierarchy is easily readable.


On Thu, May 9, 2013 at 4:35 PM, Abbas Butt <abb...@en...>wrote:

> PFA the updated patch.
>
>
> On Tue, May 7, 2013 at 2:57 PM, Ashutosh Bapat <
> ash...@en...> wrote:
>
>> Hi Abbas,
>> The right fix is at line 402. Because of the condition there, we do not
>> call GetPreferredReplicationNode() if there is FOR SHARE/FOR UPDATE clause
>> there. I think we need to modify the condition.
>>
>>  392     if (exec_nodes && exec_nodes->nodeList)
>>  393     {
>>  394         /*
>>  395          * If this is the highest level query in the query tree and
>>  396          * relations involved in the query are such that ultimate
>> JOIN is
>>  397          * replicated JOIN, choose only one of them.
>>  398          * If we do this for lower level queries in query tree, we
>> might loose
>>  399          * chance because common nodes are left out.
>>  400          */
>>  401         if (IsExecNodesReplicated(exec_nodes) &&
>>  402             exec_nodes->accesstype == RELATION_ACCESS_READ &&
>>  403             sc_context->sc_query_level == 0)
>>  404
>>  405         {
>>  406             List *tmp_list = exec_nodes->nodeList;
>>  407             exec_nodes->nodeList =
>> GetPreferredReplicationNode(exec_nodes->nodeList);
>>  408             list_free(tmp_list);
>>  409         }
>>  410         return exec_nodes;
>>  411     }
>>
>> Regarding other places where you have used the wrapper around
>> GetPreferredReplicationNode(); we don't need those code changes. We set
>> en_expr only for distributed relations and en_relid is set and used
>> properly only for DMLs when this problem would not happen. May be we should
>> add assertions at these places to make sure that we don't come there for
>> replicated tables and FOR SHARE/UDPATE SELECTs.
>>
>>
>>
>> On Tue, May 7, 2013 at 10:21 AM, Abbas Butt <abb...@en...>wrote:
>>
>>> I changed to code by creating another function and calling it right
>>> after GetRelationNodes where needed. Updated patch attached.
>>>
>>>
>>> On Tue, Apr 30, 2013 at 3:41 PM, Ashutosh Bapat <
>>> ash...@en...> wrote:
>>>
>>>> Hi Abbas,
>>>> Instead of fixing this in GetRelationNodes, we should fix it outside,
>>>> by calling GetPrefferedNode on the result returned by GetRelationNodes for
>>>> replicated tables. Please send a revised patch with this change. May be you
>>>> want to examine all callers of GetRelationNodes.
>>>>
>>>>
>>>> On Wed, Apr 24, 2013 at 10:58 PM, Abbas Butt <
>>>> abb...@en...> wrote:
>>>>
>>>>> Hi,
>>>>> The test case fails if there is no primary node in the cluster. The
>>>>> following test case was producing error.
>>>>>
>>>>> CREATE TABLE tt_22 (a int, b int) distribute by replication;
>>>>> INSERT INTO tt_22 VALUES (10);
>>>>>
>>>>> In a four datanode cluster the following query plan was being produced.
>>>>>
>>>>> explain verbose SELECT * FROM tt_22 FOR UPDATE;
>>>>>                                  QUERY
>>>>> PLAN
>>>>>
>>>>> ----------------------------------------------------------------------------
>>>>>  Data Node Scan on "__REMOTE_FQS_QUERY__"  (cost=0.00..0.00 rows=0
>>>>> width=0)
>>>>>    Output: tt_22.a, tt_22.b
>>>>>    Node/s: data_node_1, data_node_2, data_node_3, data_node_4
>>>>>    Remote query: SELECT a, b FROM tt_22 FOR UPDATE OF tt_22
>>>>> (4 rows)
>>>>>
>>>>> The reason was a missing else case in GetRelationNodes.
>>>>>
>>>>>
>>>>> --
>>>>> *Abbas*
>>>>>  Architect
>>>>>
>>>>> Ph: 92.334.5100153
>>>>>  Skype ID: gabbasb
>>>>> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
>>>>> *
>>>>> Follow us on Twitter*
>>>>> @EnterpriseDB
>>>>>
>>>>> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>>>>>
>>>>>
>>>>> ------------------------------------------------------------------------------
>>>>> Try New Relic Now & We'll Send You this Cool Shirt
>>>>> New Relic is the only SaaS-based application performance monitoring
>>>>> service
>>>>> that delivers powerful full stack analytics. Optimize and monitor your
>>>>> browser, app, & servers with just a few lines of code. Try New Relic
>>>>> and get this awesome Nerd Life shirt!
>>>>> http://p.sf.net/sfu/newrelic_d2d_apr
>>>>> _______________________________________________
>>>>> Postgres-xc-developers mailing list
>>>>> Pos...@li...
>>>>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Best Wishes,
>>>> Ashutosh Bapat
>>>> EntepriseDB Corporation
>>>> The Postgres Database Company
>>>>
>>>
>>>
>>>
>>> --
>>> --
>>> *Abbas*
>>>  Architect
>>>
>>> Ph: 92.334.5100153
>>>  Skype ID: gabbasb
>>> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
>>> *
>>> Follow us on Twitter*
>>> @EnterpriseDB
>>>
>>> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>>>
>>
>>
>>
>> --
>> Best Wishes,
>> Ashutosh Bapat
>> EntepriseDB Corporation
>> The Postgres Database Company
>>
>
>
>
> --
> --
> *Abbas*
>  Architect
>
> Ph: 92.334.5100153
>  Skype ID: gabbasb
> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
> *
> Follow us on Twitter*
> @EnterpriseDB
>
> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>



-- 
Best Wishes,
Ashutosh Bapat
EntepriseDB Corporation
The Postgres Database Company

Re: [Postgres-xc-developers] GTM standby bugs

[鈴木 幸市 <ko...@in...>]

Andrei;

It's wonderful to have these fixes, especially sequence issues, which is already in the bug track.

Error messages need some more thought, I think.   Node registration will be useful in the future.   Disabling this could be a quick fix but I think we should keep this code.

Thank you very much;
---
Koichi Suzuki



On 2013/05/09, at 17:15, Andrei Martsinchyk <and...@gm...> wrote:

> Hi,
> 
> We have found few bugs related to GTM standby.
> 1. Missing break; after handling MSG_BKUP_TXN_BEGIN_GETGXID on standby was causing error 
> "insufficient data left in message". Patch is attached.
> 2. GTM master does not forward information about sequence created to standby. Patch is attached, too.
> 3. When restarting cluster with standby, GTM master logs errors "Expecting a startup message, but received �". The problem disappears if I remove file register.node from the GTM master data directory. Before I start looking into details, why GTM needs to save information about running nodes? Cluster may be shut down for reconfiguration and information in register.node may be out of date. At the same time when nodes connect to GTM they deliver actual information.
> So, maybe proper fix for the problem is just to remove code to save/restore register.node?
> 
> -- 
> Andrei Martsinchyk
> 
> StormDB - http://www.stormdb.com
> The Database Cloud
> 
> <missing_break.patch><create_sequence.patch>------------------------------------------------------------------------------
> Learn Graph Databases - Download FREE O'Reilly Book
> "Graph Databases" is the definitive new guide to graph databases and 
> their applications. This 200-page book is written by three acclaimed 
> leaders in the field. The early access version is available now. 
> Download your free book today! http://p.sf.net/sfu/neotech_d2d_may_______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers

Re: [Postgres-xc-developers] Fix for test case xc_misc

[Abbas B. <abb...@en...>]

PFA the updated patch.

On Tue, May 7, 2013 at 2:57 PM, Ashutosh Bapat <
ash...@en...> wrote:

> Hi Abbas,
> The right fix is at line 402. Because of the condition there, we do not
> call GetPreferredReplicationNode() if there is FOR SHARE/FOR UPDATE clause
> there. I think we need to modify the condition.
>
>  392     if (exec_nodes && exec_nodes->nodeList)
>  393     {
>  394         /*
>  395          * If this is the highest level query in the query tree and
>  396          * relations involved in the query are such that ultimate
> JOIN is
>  397          * replicated JOIN, choose only one of them.
>  398          * If we do this for lower level queries in query tree, we
> might loose
>  399          * chance because common nodes are left out.
>  400          */
>  401         if (IsExecNodesReplicated(exec_nodes) &&
>  402             exec_nodes->accesstype == RELATION_ACCESS_READ &&
>  403             sc_context->sc_query_level == 0)
>  404
>  405         {
>  406             List *tmp_list = exec_nodes->nodeList;
>  407             exec_nodes->nodeList =
> GetPreferredReplicationNode(exec_nodes->nodeList);
>  408             list_free(tmp_list);
>  409         }
>  410         return exec_nodes;
>  411     }
>
> Regarding other places where you have used the wrapper around
> GetPreferredReplicationNode(); we don't need those code changes. We set
> en_expr only for distributed relations and en_relid is set and used
> properly only for DMLs when this problem would not happen. May be we should
> add assertions at these places to make sure that we don't come there for
> replicated tables and FOR SHARE/UDPATE SELECTs.
>
>
>
> On Tue, May 7, 2013 at 10:21 AM, Abbas Butt <abb...@en...>wrote:
>
>> I changed to code by creating another function and calling it right after
>> GetRelationNodes where needed. Updated patch attached.
>>
>>
>> On Tue, Apr 30, 2013 at 3:41 PM, Ashutosh Bapat <
>> ash...@en...> wrote:
>>
>>> Hi Abbas,
>>> Instead of fixing this in GetRelationNodes, we should fix it outside, by
>>> calling GetPrefferedNode on the result returned by GetRelationNodes for
>>> replicated tables. Please send a revised patch with this change. May be you
>>> want to examine all callers of GetRelationNodes.
>>>
>>>
>>> On Wed, Apr 24, 2013 at 10:58 PM, Abbas Butt <
>>> abb...@en...> wrote:
>>>
>>>> Hi,
>>>> The test case fails if there is no primary node in the cluster. The
>>>> following test case was producing error.
>>>>
>>>> CREATE TABLE tt_22 (a int, b int) distribute by replication;
>>>> INSERT INTO tt_22 VALUES (10);
>>>>
>>>> In a four datanode cluster the following query plan was being produced.
>>>>
>>>> explain verbose SELECT * FROM tt_22 FOR UPDATE;
>>>>                                  QUERY
>>>> PLAN
>>>>
>>>> ----------------------------------------------------------------------------
>>>>  Data Node Scan on "__REMOTE_FQS_QUERY__"  (cost=0.00..0.00 rows=0
>>>> width=0)
>>>>    Output: tt_22.a, tt_22.b
>>>>    Node/s: data_node_1, data_node_2, data_node_3, data_node_4
>>>>    Remote query: SELECT a, b FROM tt_22 FOR UPDATE OF tt_22
>>>> (4 rows)
>>>>
>>>> The reason was a missing else case in GetRelationNodes.
>>>>
>>>>
>>>> --
>>>> *Abbas*
>>>>  Architect
>>>>
>>>> Ph: 92.334.5100153
>>>>  Skype ID: gabbasb
>>>> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
>>>> *
>>>> Follow us on Twitter*
>>>> @EnterpriseDB
>>>>
>>>> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>>>>
>>>>
>>>> ------------------------------------------------------------------------------
>>>> Try New Relic Now & We'll Send You this Cool Shirt
>>>> New Relic is the only SaaS-based application performance monitoring
>>>> service
>>>> that delivers powerful full stack analytics. Optimize and monitor your
>>>> browser, app, & servers with just a few lines of code. Try New Relic
>>>> and get this awesome Nerd Life shirt!
>>>> http://p.sf.net/sfu/newrelic_d2d_apr
>>>> _______________________________________________
>>>> Postgres-xc-developers mailing list
>>>> Pos...@li...
>>>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>>>
>>>>
>>>
>>>
>>> --
>>> Best Wishes,
>>> Ashutosh Bapat
>>> EntepriseDB Corporation
>>> The Postgres Database Company
>>>
>>
>>
>>
>> --
>> --
>> *Abbas*
>>  Architect
>>
>> Ph: 92.334.5100153
>>  Skype ID: gabbasb
>> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
>> *
>> Follow us on Twitter*
>> @EnterpriseDB
>>
>> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>>
>
>
>
> --
> Best Wishes,
> Ashutosh Bapat
> EntepriseDB Corporation
> The Postgres Database Company
>



-- 
-- 
*Abbas*
 Architect

Ph: 92.334.5100153
 Skype ID: gabbasb
www.enterprisedb.co
<http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
*
Follow us on Twitter*
@EnterpriseDB

Visit EnterpriseDB for tutorials, webinars,
whitepapers<http://www.enterprisedb.com/resources-community>and
more<http://www.enterprisedb.com/resources-community>

Re: [Postgres-xc-developers] Fwd: [ postgres-xc-Feature Requests-3612885 ] Add support for TRUNCATE with RESTART IDENTITY

[鈴木 幸市 <ko...@in...>]

Sorry, I've not reviewed it yet.  Yes, I will review the patch.

Regards;
---
Koichi Suzuki



On 2013/05/08, at 18:36, Nikhil Sontakke <ni...@st...> wrote:

> Hi Suzuki-san, 
> 
> I have submitted patch to handle negative sequences a while back. 
> 
> Yes, surely we can discuss stuff at pgcon as well. 
> 
> Regards,
> Nikhils
> 
> 
> On Wed, May 8, 2013 at 2:44 PM, Koichi Suzuki <koi...@gm...> wrote:
> Thanks.   I'd like to discuss refactoring sequence support in the next F2F MTG, or in Ottawa, if we have a time.
> 
> ----------
> Koichi Suzuki
> 
> 
> 2013/5/8 Ashutosh Bapat <ash...@en...>
> Hi Nikhil, Suzuki-san,
> 
> I have created feature request https://sourceforge.net/tracker/?func=detail&aid=3612885&group_id=311227&atid=1310235 for enabling and supporting TRUNCATE with RESTART IDENTITY. Right now I have assigned it to Suzuki-san. I didn't find any user id for Nikhil in sourceforge. If it's to be assigned to Nikhil, Nikhil, please provide your source forge id.
> 
> I have assigned high priority to it (8), so that we will take it up in next release.
> 
> ---------- Forwarded message ----------
> From: SourceForge.net <no...@so...>
> Date: Wed, May 8, 2013 at 11:48 AM
> Subject: [ postgres-xc-Feature Requests-3612885 ] Add support for TRUNCATE with RESTART IDENTITY
> To: "SourceForge.net" <no...@so...>
> 
> 
> Feature Requests item #3612885, was opened at 2013-05-07 23:18
> Message generated for change (Tracker Item Submitted) made by ashutoshbapat
> You can respond by visiting:
> https://sourceforge.net/tracker/?func=detail&atid=1310235&aid=3612885&group_id=311227
> 
> Please note that this message will contain a full copy of the comment thread,
> including the initial issue submission, for this request,
> not just the latest update.
> Category: GTM
> Group: Development Queue
> Status: Open
> Priority: 8
> Private: No
> Submitted By: Ashutosh Bapat (ashutoshbapat)
> Assigned to: Koichi Suzuki (koichi-szk)
> Summary: Add support for TRUNCATE with RESTART IDENTITY
> 
> Initial Comment:
> Currently TRUNCATE statement with RESTART IDENTITY clause doesn't work, since there is no way to restart a sequence at the GTM. This feature requests to add the support for TRUNCATE with RESTART IDENTITY.
> 
> The feature has been disabled by commit commit d337476e7c0a49f2b8d05a8c5a1c9be65683bb41
> Author: Ashutosh Bapat <ash...@en...>
> Date:   Wed May 8 11:41:45 2013 +0530
> 
>     TRUNCATE statement with RESTART IDENTITY clause is not supported in this
>     release. Error out when TRUNCATE with RESTART IDENTITY is specified. Alternate
>     expected output is updated with error message and consequences of the same.
>     Original patch by Nikhil Sontakke.
> 
> 
> ----------------------------------------------------------------------
> 
> You can respond by visiting:
> https://sourceforge.net/tracker/?func=detail&atid=1310235&aid=3612885&group_id=311227
> 
> 
> 
> -- 
> Best Wishes,
> Ashutosh Bapat
> EntepriseDB Corporation
> The Postgres Database Company
> 
> ------------------------------------------------------------------------------
> Learn Graph Databases - Download FREE O'Reilly Book
> "Graph Databases" is the definitive new guide to graph databases and
> their applications. This 200-page book is written by three acclaimed
> leaders in the field. The early access version is available now.
> Download your free book today! http://p.sf.net/sfu/neotech_d2d_may
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
> 
> 
> 
> ------------------------------------------------------------------------------
> Learn Graph Databases - Download FREE O'Reilly Book
> "Graph Databases" is the definitive new guide to graph databases and
> their applications. This 200-page book is written by three acclaimed
> leaders in the field. The early access version is available now.
> Download your free book today! http://p.sf.net/sfu/neotech_d2d_may
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
> 
> 
> 
> 
> -- 
> StormDB - http://www.stormdb.com
> The Database Cloud
> ------------------------------------------------------------------------------
> Learn Graph Databases - Download FREE O'Reilly Book
> "Graph Databases" is the definitive new guide to graph databases and 
> their applications. This 200-page book is written by three acclaimed 
> leaders in the field. The early access version is available now. 
> Download your free book today! http://p.sf.net/sfu/neotech_d2d_may_______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers

Re: [Postgres-xc-developers] Fix for test case combocid

[Ashutosh B. <ash...@en...>]

Ok, looks good.


On Wed, May 8, 2013 at 4:19 PM, Abbas Butt <abb...@en...>wrote:

> Attached please find a revised patch to fix test case combocid.sql.
> As discussed I have modified the distribution strategy of the table being
> used to replication and found that the test works fine.
>
>
> On Wed, May 8, 2013 at 12:36 PM, Abbas Butt <abb...@en...>wrote:
>
>> Sure, that should work. Let me try.
>>
>>
>> On Wed, May 8, 2013 at 9:18 AM, Ashutosh Bapat <
>> ash...@en...> wrote:
>>
>>> Is that because the table is distributed? Can you please check if the
>>> table can be replicated (explicitly)?
>>>
>>>
>>> On Wed, May 8, 2013 at 7:12 AM, Abbas Butt <abb...@en...>wrote:
>>>
>>>> You are right, but the problem is that there is a test case in
>>>> combocid.sql that selects ctid
>>>>
>>>> SELECT ctid,cmin,* FROM combocidtest ORDER BY ctid;
>>>>
>>>> The query results in the following output on my machine.
>>>>  ctid  | cmin | foobar
>>>> -------+------+--------
>>>>  (0,1) |   10 |    444
>>>>
>>>> The alternate expected output file has
>>>>  ctid  | cmin | foobar
>>>> -------+------+--------
>>>>  (0,4) |   10 |    444
>>>>
>>>> The test fails on my machine and passes on buildfarm, meaning that the
>>>> query results in (0,4) as ctid on buildfarm.
>>>>
>>>> I therefore thought of resetting ctid, so that we can get (0,1) ctid on
>>>> buildfarm as well as the rest of the setups. But I agree that the
>>>> additional statement in SQL to reset ctid will not be required when
>>>> SAVEPOINTs are implemented.
>>>> What strategy should we then adopt to solve the issue?
>>>>
>>>> On Tue, May 7, 2013 at 4:17 PM, Ashutosh Bapat <
>>>> ash...@en...> wrote:
>>>>
>>>>> Hi Abbas,
>>>>> Since this diff is because we do not support a particular feature, I
>>>>> think, we need up update alternate expected output file (only) with the
>>>>> diff. There is no need to add any new SQL. If we do so, we will have
>>>>> problem in future, when we start supporting SAVEPOINT.
>>>>>
>>>>
>>>> The test case
>>>>
>>>>
>>>>>
>>>>>
>>>>> On Wed, Apr 24, 2013 at 11:12 PM, Abbas Butt <
>>>>> abb...@en...> wrote:
>>>>>
>>>>>> Hi,
>>>>>> The test was failing because ctid was being selected and was not
>>>>>> being reset explicitly.
>>>>>> SAVEPOINT is not implemented yet and the transaction fails because of
>>>>>> that statement.
>>>>>> Due to the failure / rollback the ctid remains incremented and that
>>>>>> incremented value
>>>>>> is dependent on cluster configuration.
>>>>>> The solution is to explicitly reset ctid using truncate statement.
>>>>>>
>>>>>> --
>>>>>> *Abbas*
>>>>>>  Architect
>>>>>>
>>>>>> Ph: 92.334.5100153
>>>>>>  Skype ID: gabbasb
>>>>>> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
>>>>>> *
>>>>>> Follow us on Twitter*
>>>>>> @EnterpriseDB
>>>>>>
>>>>>> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>>>>>>
>>>>>>
>>>>>> ------------------------------------------------------------------------------
>>>>>> Try New Relic Now & We'll Send You this Cool Shirt
>>>>>> New Relic is the only SaaS-based application performance monitoring
>>>>>> service
>>>>>> that delivers powerful full stack analytics. Optimize and monitor your
>>>>>> browser, app, & servers with just a few lines of code. Try New Relic
>>>>>> and get this awesome Nerd Life shirt!
>>>>>> http://p.sf.net/sfu/newrelic_d2d_apr
>>>>>> _______________________________________________
>>>>>> Postgres-xc-developers mailing list
>>>>>> Pos...@li...
>>>>>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Best Wishes,
>>>>> Ashutosh Bapat
>>>>> EntepriseDB Corporation
>>>>> The Postgres Database Company
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> --
>>>> *Abbas*
>>>>  Architect
>>>>
>>>> Ph: 92.334.5100153
>>>>  Skype ID: gabbasb
>>>> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
>>>> *
>>>> Follow us on Twitter*
>>>> @EnterpriseDB
>>>>
>>>> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>>>>
>>>
>>>
>>>
>>> --
>>> Best Wishes,
>>> Ashutosh Bapat
>>> EntepriseDB Corporation
>>> The Postgres Database Company
>>>
>>
>>
>>
>> --
>> --
>> *Abbas*
>>  Architect
>>
>> Ph: 92.334.5100153
>>  Skype ID: gabbasb
>> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
>> *
>> Follow us on Twitter*
>> @EnterpriseDB
>>
>> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>>
>
>
>
> --
> --
> *Abbas*
>  Architect
>
> Ph: 92.334.5100153
>  Skype ID: gabbasb
> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
> *
> Follow us on Twitter*
> @EnterpriseDB
>
> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>



-- 
Best Wishes,
Ashutosh Bapat
EntepriseDB Corporation
The Postgres Database Company

Re: [Postgres-xc-developers] Fix for test case combocid

[Abbas B. <abb...@en...>]

Attached please find a revised patch to fix test case combocid.sql.
As discussed I have modified the distribution strategy of the table being
used to replication and found that the test works fine.

On Wed, May 8, 2013 at 12:36 PM, Abbas Butt <abb...@en...>wrote:

> Sure, that should work. Let me try.
>
>
> On Wed, May 8, 2013 at 9:18 AM, Ashutosh Bapat <
> ash...@en...> wrote:
>
>> Is that because the table is distributed? Can you please check if the
>> table can be replicated (explicitly)?
>>
>>
>> On Wed, May 8, 2013 at 7:12 AM, Abbas Butt <abb...@en...>wrote:
>>
>>> You are right, but the problem is that there is a test case in
>>> combocid.sql that selects ctid
>>>
>>> SELECT ctid,cmin,* FROM combocidtest ORDER BY ctid;
>>>
>>> The query results in the following output on my machine.
>>>  ctid  | cmin | foobar
>>> -------+------+--------
>>>  (0,1) |   10 |    444
>>>
>>> The alternate expected output file has
>>>  ctid  | cmin | foobar
>>> -------+------+--------
>>>  (0,4) |   10 |    444
>>>
>>> The test fails on my machine and passes on buildfarm, meaning that the
>>> query results in (0,4) as ctid on buildfarm.
>>>
>>> I therefore thought of resetting ctid, so that we can get (0,1) ctid on
>>> buildfarm as well as the rest of the setups. But I agree that the
>>> additional statement in SQL to reset ctid will not be required when
>>> SAVEPOINTs are implemented.
>>> What strategy should we then adopt to solve the issue?
>>>
>>> On Tue, May 7, 2013 at 4:17 PM, Ashutosh Bapat <
>>> ash...@en...> wrote:
>>>
>>>> Hi Abbas,
>>>> Since this diff is because we do not support a particular feature, I
>>>> think, we need up update alternate expected output file (only) with the
>>>> diff. There is no need to add any new SQL. If we do so, we will have
>>>> problem in future, when we start supporting SAVEPOINT.
>>>>
>>>
>>> The test case
>>>
>>>
>>>>
>>>>
>>>> On Wed, Apr 24, 2013 at 11:12 PM, Abbas Butt <
>>>> abb...@en...> wrote:
>>>>
>>>>> Hi,
>>>>> The test was failing because ctid was being selected and was not being
>>>>> reset explicitly.
>>>>> SAVEPOINT is not implemented yet and the transaction fails because of
>>>>> that statement.
>>>>> Due to the failure / rollback the ctid remains incremented and that
>>>>> incremented value
>>>>> is dependent on cluster configuration.
>>>>> The solution is to explicitly reset ctid using truncate statement.
>>>>>
>>>>> --
>>>>> *Abbas*
>>>>>  Architect
>>>>>
>>>>> Ph: 92.334.5100153
>>>>>  Skype ID: gabbasb
>>>>> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
>>>>> *
>>>>> Follow us on Twitter*
>>>>> @EnterpriseDB
>>>>>
>>>>> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>>>>>
>>>>>
>>>>> ------------------------------------------------------------------------------
>>>>> Try New Relic Now & We'll Send You this Cool Shirt
>>>>> New Relic is the only SaaS-based application performance monitoring
>>>>> service
>>>>> that delivers powerful full stack analytics. Optimize and monitor your
>>>>> browser, app, & servers with just a few lines of code. Try New Relic
>>>>> and get this awesome Nerd Life shirt!
>>>>> http://p.sf.net/sfu/newrelic_d2d_apr
>>>>> _______________________________________________
>>>>> Postgres-xc-developers mailing list
>>>>> Pos...@li...
>>>>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Best Wishes,
>>>> Ashutosh Bapat
>>>> EntepriseDB Corporation
>>>> The Postgres Database Company
>>>>
>>>
>>>
>>>
>>> --
>>> --
>>> *Abbas*
>>>  Architect
>>>
>>> Ph: 92.334.5100153
>>>  Skype ID: gabbasb
>>> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
>>> *
>>> Follow us on Twitter*
>>> @EnterpriseDB
>>>
>>> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>>>
>>
>>
>>
>> --
>> Best Wishes,
>> Ashutosh Bapat
>> EntepriseDB Corporation
>> The Postgres Database Company
>>
>
>
>
> --
> --
> *Abbas*
>  Architect
>
> Ph: 92.334.5100153
>  Skype ID: gabbasb
> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
> *
> Follow us on Twitter*
> @EnterpriseDB
>
> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>



-- 
-- 
*Abbas*
 Architect

Ph: 92.334.5100153
 Skype ID: gabbasb
www.enterprisedb.co
<http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
*
Follow us on Twitter*
@EnterpriseDB

Visit EnterpriseDB for tutorials, webinars,
whitepapers<http://www.enterprisedb.com/resources-community>and
more<http://www.enterprisedb.com/resources-community>

Re: [Postgres-xc-developers] Fwd: [ postgres-xc-Feature Requests-3612885 ] Add support for TRUNCATE with RESTART IDENTITY

[Nikhil S. <ni...@st...>]

Hi Suzuki-san,

I have submitted patch to handle negative sequences a while back.

Yes, surely we can discuss stuff at pgcon as well.

Regards,
Nikhils


On Wed, May 8, 2013 at 2:44 PM, Koichi Suzuki <koi...@gm...>wrote:

> Thanks.   I'd like to discuss refactoring sequence support in the next F2F
> MTG, or in Ottawa, if we have a time.
>
> ----------
> Koichi Suzuki
>
>
> 2013/5/8 Ashutosh Bapat <ash...@en...>
>
>>  Hi Nikhil, Suzuki-san,
>>
>> I have created feature request
>> https://sourceforge.net/tracker/?func=detail&aid=3612885&group_id=311227&atid=1310235for enabling and supporting TRUNCATE with RESTART IDENTITY. Right now I
>> have assigned it to Suzuki-san. I didn't find any user id for Nikhil in
>> sourceforge. If it's to be assigned to Nikhil, Nikhil, please provide your
>> source forge id.
>>
>> I have assigned high priority to it (8), so that we will take it up in
>> next release.
>>
>> ---------- Forwarded message ----------
>> From: SourceForge.net <no...@so...>
>> Date: Wed, May 8, 2013 at 11:48 AM
>> Subject: [ postgres-xc-Feature Requests-3612885 ] Add support for
>> TRUNCATE with RESTART IDENTITY
>> To: "SourceForge.net" <no...@so...>
>>
>>
>> Feature Requests item #3612885, was opened at 2013-05-07 23:18
>> Message generated for change (Tracker Item Submitted) made by
>> ashutoshbapat
>> You can respond by visiting:
>>
>> https://sourceforge.net/tracker/?func=detail&atid=1310235&aid=3612885&group_id=311227
>>
>> Please note that this message will contain a full copy of the comment
>> thread,
>> including the initial issue submission, for this request,
>> not just the latest update.
>> Category: GTM
>> Group: Development Queue
>> Status: Open
>> Priority: 8
>> Private: No
>> Submitted By: Ashutosh Bapat (ashutoshbapat)
>> Assigned to: Koichi Suzuki (koichi-szk)
>> Summary: Add support for TRUNCATE with RESTART IDENTITY
>>
>> Initial Comment:
>> Currently TRUNCATE statement with RESTART IDENTITY clause doesn't work,
>> since there is no way to restart a sequence at the GTM. This feature
>> requests to add the support for TRUNCATE with RESTART IDENTITY.
>>
>> The feature has been disabled by commit commit
>> d337476e7c0a49f2b8d05a8c5a1c9be65683bb41
>> Author: Ashutosh Bapat <ash...@en...>
>> Date:   Wed May 8 11:41:45 2013 +0530
>>
>>     TRUNCATE statement with RESTART IDENTITY clause is not supported in
>> this
>>     release. Error out when TRUNCATE with RESTART IDENTITY is specified.
>> Alternate
>>     expected output is updated with error message and consequences of the
>> same.
>>     Original patch by Nikhil Sontakke.
>>
>>
>> ----------------------------------------------------------------------
>>
>> You can respond by visiting:
>>
>> https://sourceforge.net/tracker/?func=detail&atid=1310235&aid=3612885&group_id=311227
>>
>>
>>
>> --
>> Best Wishes,
>> Ashutosh Bapat
>> EntepriseDB Corporation
>> The Postgres Database Company
>>
>>
>> ------------------------------------------------------------------------------
>> Learn Graph Databases - Download FREE O'Reilly Book
>> "Graph Databases" is the definitive new guide to graph databases and
>> their applications. This 200-page book is written by three acclaimed
>> leaders in the field. The early access version is available now.
>> Download your free book today! http://p.sf.net/sfu/neotech_d2d_may
>> _______________________________________________
>> Postgres-xc-developers mailing list
>> Pos...@li...
>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>
>>
>
>
> ------------------------------------------------------------------------------
> Learn Graph Databases - Download FREE O'Reilly Book
> "Graph Databases" is the definitive new guide to graph databases and
> their applications. This 200-page book is written by three acclaimed
> leaders in the field. The early access version is available now.
> Download your free book today! http://p.sf.net/sfu/neotech_d2d_may
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>
>


-- 
StormDB - http://www.stormdb.com
The Database Cloud

Re: [Postgres-xc-developers] Fwd: [ postgres-xc-Feature Requests-3612885 ] Add support for TRUNCATE with RESTART IDENTITY

[Koichi S. <koi...@gm...>]

Thanks.   I'd like to discuss refactoring sequence support in the next F2F
MTG, or in Ottawa, if we have a time.

----------
Koichi Suzuki


2013/5/8 Ashutosh Bapat <ash...@en...>

> Hi Nikhil, Suzuki-san,
>
> I have created feature request
> https://sourceforge.net/tracker/?func=detail&aid=3612885&group_id=311227&atid=1310235for enabling and supporting TRUNCATE with RESTART IDENTITY. Right now I
> have assigned it to Suzuki-san. I didn't find any user id for Nikhil in
> sourceforge. If it's to be assigned to Nikhil, Nikhil, please provide your
> source forge id.
>
> I have assigned high priority to it (8), so that we will take it up in
> next release.
>
> ---------- Forwarded message ----------
> From: SourceForge.net <no...@so...>
> Date: Wed, May 8, 2013 at 11:48 AM
> Subject: [ postgres-xc-Feature Requests-3612885 ] Add support for TRUNCATE
> with RESTART IDENTITY
> To: "SourceForge.net" <no...@so...>
>
>
> Feature Requests item #3612885, was opened at 2013-05-07 23:18
> Message generated for change (Tracker Item Submitted) made by ashutoshbapat
> You can respond by visiting:
>
> https://sourceforge.net/tracker/?func=detail&atid=1310235&aid=3612885&group_id=311227
>
> Please note that this message will contain a full copy of the comment
> thread,
> including the initial issue submission, for this request,
> not just the latest update.
> Category: GTM
> Group: Development Queue
> Status: Open
> Priority: 8
> Private: No
> Submitted By: Ashutosh Bapat (ashutoshbapat)
> Assigned to: Koichi Suzuki (koichi-szk)
> Summary: Add support for TRUNCATE with RESTART IDENTITY
>
> Initial Comment:
> Currently TRUNCATE statement with RESTART IDENTITY clause doesn't work,
> since there is no way to restart a sequence at the GTM. This feature
> requests to add the support for TRUNCATE with RESTART IDENTITY.
>
> The feature has been disabled by commit commit
> d337476e7c0a49f2b8d05a8c5a1c9be65683bb41
> Author: Ashutosh Bapat <ash...@en...>
> Date:   Wed May 8 11:41:45 2013 +0530
>
>     TRUNCATE statement with RESTART IDENTITY clause is not supported in
> this
>     release. Error out when TRUNCATE with RESTART IDENTITY is specified.
> Alternate
>     expected output is updated with error message and consequences of the
> same.
>     Original patch by Nikhil Sontakke.
>
>
> ----------------------------------------------------------------------
>
> You can respond by visiting:
>
> https://sourceforge.net/tracker/?func=detail&atid=1310235&aid=3612885&group_id=311227
>
>
>
> --
> Best Wishes,
> Ashutosh Bapat
> EntepriseDB Corporation
> The Postgres Database Company
>
>
> ------------------------------------------------------------------------------
> Learn Graph Databases - Download FREE O'Reilly Book
> "Graph Databases" is the definitive new guide to graph databases and
> their applications. This 200-page book is written by three acclaimed
> leaders in the field. The early access version is available now.
> Download your free book today! http://p.sf.net/sfu/neotech_d2d_may
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>
>

Re: [Postgres-xc-developers] Fix for test case combocid

[Abbas B. <abb...@en...>]

Sure, that should work. Let me try.

On Wed, May 8, 2013 at 9:18 AM, Ashutosh Bapat <
ash...@en...> wrote:

> Is that because the table is distributed? Can you please check if the
> table can be replicated (explicitly)?
>
>
> On Wed, May 8, 2013 at 7:12 AM, Abbas Butt <abb...@en...>wrote:
>
>> You are right, but the problem is that there is a test case in
>> combocid.sql that selects ctid
>>
>> SELECT ctid,cmin,* FROM combocidtest ORDER BY ctid;
>>
>> The query results in the following output on my machine.
>>  ctid  | cmin | foobar
>> -------+------+--------
>>  (0,1) |   10 |    444
>>
>> The alternate expected output file has
>>  ctid  | cmin | foobar
>> -------+------+--------
>>  (0,4) |   10 |    444
>>
>> The test fails on my machine and passes on buildfarm, meaning that the
>> query results in (0,4) as ctid on buildfarm.
>>
>> I therefore thought of resetting ctid, so that we can get (0,1) ctid on
>> buildfarm as well as the rest of the setups. But I agree that the
>> additional statement in SQL to reset ctid will not be required when
>> SAVEPOINTs are implemented.
>> What strategy should we then adopt to solve the issue?
>>
>> On Tue, May 7, 2013 at 4:17 PM, Ashutosh Bapat <
>> ash...@en...> wrote:
>>
>>> Hi Abbas,
>>> Since this diff is because we do not support a particular feature, I
>>> think, we need up update alternate expected output file (only) with the
>>> diff. There is no need to add any new SQL. If we do so, we will have
>>> problem in future, when we start supporting SAVEPOINT.
>>>
>>
>> The test case
>>
>>
>>>
>>>
>>> On Wed, Apr 24, 2013 at 11:12 PM, Abbas Butt <
>>> abb...@en...> wrote:
>>>
>>>> Hi,
>>>> The test was failing because ctid was being selected and was not being
>>>> reset explicitly.
>>>> SAVEPOINT is not implemented yet and the transaction fails because of
>>>> that statement.
>>>> Due to the failure / rollback the ctid remains incremented and that
>>>> incremented value
>>>> is dependent on cluster configuration.
>>>> The solution is to explicitly reset ctid using truncate statement.
>>>>
>>>> --
>>>> *Abbas*
>>>>  Architect
>>>>
>>>> Ph: 92.334.5100153
>>>>  Skype ID: gabbasb
>>>> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
>>>> *
>>>> Follow us on Twitter*
>>>> @EnterpriseDB
>>>>
>>>> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>>>>
>>>>
>>>> ------------------------------------------------------------------------------
>>>> Try New Relic Now & We'll Send You this Cool Shirt
>>>> New Relic is the only SaaS-based application performance monitoring
>>>> service
>>>> that delivers powerful full stack analytics. Optimize and monitor your
>>>> browser, app, & servers with just a few lines of code. Try New Relic
>>>> and get this awesome Nerd Life shirt!
>>>> http://p.sf.net/sfu/newrelic_d2d_apr
>>>> _______________________________________________
>>>> Postgres-xc-developers mailing list
>>>> Pos...@li...
>>>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>>>
>>>>
>>>
>>>
>>> --
>>> Best Wishes,
>>> Ashutosh Bapat
>>> EntepriseDB Corporation
>>> The Postgres Database Company
>>>
>>
>>
>>
>> --
>> --
>> *Abbas*
>>  Architect
>>
>> Ph: 92.334.5100153
>>  Skype ID: gabbasb
>> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
>> *
>> Follow us on Twitter*
>> @EnterpriseDB
>>
>> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>>
>
>
>
> --
> Best Wishes,
> Ashutosh Bapat
> EntepriseDB Corporation
> The Postgres Database Company
>



-- 
-- 
*Abbas*
 Architect

Ph: 92.334.5100153
 Skype ID: gabbasb
www.enterprisedb.co
<http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
*
Follow us on Twitter*
@EnterpriseDB

Visit EnterpriseDB for tutorials, webinars,
whitepapers<http://www.enterprisedb.com/resources-community>and
more<http://www.enterprisedb.com/resources-community>

[Postgres-xc-developers] Fwd: [ postgres-xc-Feature Requests-3612885 ] Add support for TRUNCATE with RESTART IDENTITY

[Ashutosh B. <ash...@en...>]

Hi Nikhil, Suzuki-san,

I have created feature request
https://sourceforge.net/tracker/?func=detail&aid=3612885&group_id=311227&atid=1310235for
enabling and supporting TRUNCATE with RESTART IDENTITY. Right now I
have assigned it to Suzuki-san. I didn't find any user id for Nikhil in
sourceforge. If it's to be assigned to Nikhil, Nikhil, please provide your
source forge id.

I have assigned high priority to it (8), so that we will take it up in next
release.

---------- Forwarded message ----------
From: SourceForge.net <no...@so...>
Date: Wed, May 8, 2013 at 11:48 AM
Subject: [ postgres-xc-Feature Requests-3612885 ] Add support for TRUNCATE
with RESTART IDENTITY
To: "SourceForge.net" <no...@so...>


Feature Requests item #3612885, was opened at 2013-05-07 23:18
Message generated for change (Tracker Item Submitted) made by ashutoshbapat
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=1310235&aid=3612885&group_id=311227

Please note that this message will contain a full copy of the comment
thread,
including the initial issue submission, for this request,
not just the latest update.
Category: GTM
Group: Development Queue
Status: Open
Priority: 8
Private: No
Submitted By: Ashutosh Bapat (ashutoshbapat)
Assigned to: Koichi Suzuki (koichi-szk)
Summary: Add support for TRUNCATE with RESTART IDENTITY

Initial Comment:
Currently TRUNCATE statement with RESTART IDENTITY clause doesn't work,
since there is no way to restart a sequence at the GTM. This feature
requests to add the support for TRUNCATE with RESTART IDENTITY.

The feature has been disabled by commit commit
d337476e7c0a49f2b8d05a8c5a1c9be65683bb41
Author: Ashutosh Bapat <ash...@en...>
Date:   Wed May 8 11:41:45 2013 +0530

    TRUNCATE statement with RESTART IDENTITY clause is not supported in this
    release. Error out when TRUNCATE with RESTART IDENTITY is specified.
Alternate
    expected output is updated with error message and consequences of the
same.
    Original patch by Nikhil Sontakke.


----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=1310235&aid=3612885&group_id=311227



-- 
Best Wishes,
Ashutosh Bapat
EntepriseDB Corporation
The Postgres Database Company

Re: [Postgres-xc-developers] Fix for test case combocid

[Ashutosh B. <ash...@en...>]

Is that because the table is distributed? Can you please check if the table
can be replicated (explicitly)?


On Wed, May 8, 2013 at 7:12 AM, Abbas Butt <abb...@en...>wrote:

> You are right, but the problem is that there is a test case in
> combocid.sql that selects ctid
>
> SELECT ctid,cmin,* FROM combocidtest ORDER BY ctid;
>
> The query results in the following output on my machine.
>  ctid  | cmin | foobar
> -------+------+--------
>  (0,1) |   10 |    444
>
> The alternate expected output file has
>  ctid  | cmin | foobar
> -------+------+--------
>  (0,4) |   10 |    444
>
> The test fails on my machine and passes on buildfarm, meaning that the
> query results in (0,4) as ctid on buildfarm.
>
> I therefore thought of resetting ctid, so that we can get (0,1) ctid on
> buildfarm as well as the rest of the setups. But I agree that the
> additional statement in SQL to reset ctid will not be required when
> SAVEPOINTs are implemented.
> What strategy should we then adopt to solve the issue?
>
> On Tue, May 7, 2013 at 4:17 PM, Ashutosh Bapat <
> ash...@en...> wrote:
>
>> Hi Abbas,
>> Since this diff is because we do not support a particular feature, I
>> think, we need up update alternate expected output file (only) with the
>> diff. There is no need to add any new SQL. If we do so, we will have
>> problem in future, when we start supporting SAVEPOINT.
>>
>
> The test case
>
>
>>
>>
>> On Wed, Apr 24, 2013 at 11:12 PM, Abbas Butt <abb...@en...
>> > wrote:
>>
>>> Hi,
>>> The test was failing because ctid was being selected and was not being
>>> reset explicitly.
>>> SAVEPOINT is not implemented yet and the transaction fails because of
>>> that statement.
>>> Due to the failure / rollback the ctid remains incremented and that
>>> incremented value
>>> is dependent on cluster configuration.
>>> The solution is to explicitly reset ctid using truncate statement.
>>>
>>> --
>>> *Abbas*
>>>  Architect
>>>
>>> Ph: 92.334.5100153
>>>  Skype ID: gabbasb
>>> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
>>> *
>>> Follow us on Twitter*
>>> @EnterpriseDB
>>>
>>> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Try New Relic Now & We'll Send You this Cool Shirt
>>> New Relic is the only SaaS-based application performance monitoring
>>> service
>>> that delivers powerful full stack analytics. Optimize and monitor your
>>> browser, app, & servers with just a few lines of code. Try New Relic
>>> and get this awesome Nerd Life shirt!
>>> http://p.sf.net/sfu/newrelic_d2d_apr
>>> _______________________________________________
>>> Postgres-xc-developers mailing list
>>> Pos...@li...
>>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>>
>>>
>>
>>
>> --
>> Best Wishes,
>> Ashutosh Bapat
>> EntepriseDB Corporation
>> The Postgres Database Company
>>
>
>
>
> --
> --
> *Abbas*
>  Architect
>
> Ph: 92.334.5100153
>  Skype ID: gabbasb
> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
> *
> Follow us on Twitter*
> @EnterpriseDB
>
> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>



-- 
Best Wishes,
Ashutosh Bapat
EntepriseDB Corporation
The Postgres Database Company

Re: [Postgres-xc-developers] Fix for test case combocid

[Abbas B. <abb...@en...>]

You are right, but the problem is that there is a test case in combocid.sql
that selects ctid

SELECT ctid,cmin,* FROM combocidtest ORDER BY ctid;

The query results in the following output on my machine.
 ctid  | cmin | foobar
-------+------+--------
 (0,1) |   10 |    444

The alternate expected output file has
 ctid  | cmin | foobar
-------+------+--------
 (0,4) |   10 |    444

The test fails on my machine and passes on buildfarm, meaning that the
query results in (0,4) as ctid on buildfarm.

I therefore thought of resetting ctid, so that we can get (0,1) ctid on
buildfarm as well as the rest of the setups. But I agree that the
additional statement in SQL to reset ctid will not be required when
SAVEPOINTs are implemented.
What strategy should we then adopt to solve the issue?

On Tue, May 7, 2013 at 4:17 PM, Ashutosh Bapat <
ash...@en...> wrote:

> Hi Abbas,
> Since this diff is because we do not support a particular feature, I
> think, we need up update alternate expected output file (only) with the
> diff. There is no need to add any new SQL. If we do so, we will have
> problem in future, when we start supporting SAVEPOINT.
>

The test case


>
>
> On Wed, Apr 24, 2013 at 11:12 PM, Abbas Butt <abb...@en...>wrote:
>
>> Hi,
>> The test was failing because ctid was being selected and was not being
>> reset explicitly.
>> SAVEPOINT is not implemented yet and the transaction fails because of
>> that statement.
>> Due to the failure / rollback the ctid remains incremented and that
>> incremented value
>> is dependent on cluster configuration.
>> The solution is to explicitly reset ctid using truncate statement.
>>
>> --
>> *Abbas*
>>  Architect
>>
>> Ph: 92.334.5100153
>>  Skype ID: gabbasb
>> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
>> *
>> Follow us on Twitter*
>> @EnterpriseDB
>>
>> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>>
>>
>> ------------------------------------------------------------------------------
>> Try New Relic Now & We'll Send You this Cool Shirt
>> New Relic is the only SaaS-based application performance monitoring
>> service
>> that delivers powerful full stack analytics. Optimize and monitor your
>> browser, app, & servers with just a few lines of code. Try New Relic
>> and get this awesome Nerd Life shirt!
>> http://p.sf.net/sfu/newrelic_d2d_apr
>> _______________________________________________
>> Postgres-xc-developers mailing list
>> Pos...@li...
>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>
>>
>
>
> --
> Best Wishes,
> Ashutosh Bapat
> EntepriseDB Corporation
> The Postgres Database Company
>



-- 
-- 
*Abbas*
 Architect

Ph: 92.334.5100153
 Skype ID: gabbasb
www.enterprisedb.co
<http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
*
Follow us on Twitter*
@EnterpriseDB

Visit EnterpriseDB for tutorials, webinars,
whitepapers<http://www.enterprisedb.com/resources-community>and
more<http://www.enterprisedb.com/resources-community>

Re: [Postgres-xc-developers] Truncate with restart identity

[Nikhil S. <ni...@st...>]

Thanks Ashutosh,

Looks ok to me.

Regards,
Nikhils


On Tue, May 7, 2013 at 6:41 PM, Ashutosh Bapat <
ash...@en...> wrote:

> Hi Nikhil,
> Thanks for the documentation changes. There were few more expected output
> changes to make the test pass with the restriction. I have attached updated
> patch. Please check if the changes are fine. I will commit it after that.
>
>
> On Tue, Apr 30, 2013 at 6:17 PM, Nikhil Sontakke <ni...@st...>wrote:
>
>> There's so much noise in the output that it's kinda difficult to cogently
>> provide a diff for just this case. Anyways I have added the relevant error
>> messages in the output file where RESTART IDENTITY has been used.
>>
>> HTH,
>> Nikhils
>>
>>
>> On Tue, Apr 30, 2013 at 5:39 PM, Ashutosh Bapat <
>> ash...@en...> wrote:
>>
>>> Hi Nikhil,
>>> We are trying to clean up the regression, so that there are 0 failures.
>>> This helps to stop new differences creeping in the already failing files.
>>>
>>> If there are features we are not supporting in XC, we are silencing
>>> those failure (and only those failures) by adding alternate outputs.
>>> truncate already has an alternate output file, so you need to change that.
>>>
>>>
>>> On Tue, Apr 30, 2013 at 4:22 PM, Nikhil Sontakke <ni...@st...>wrote:
>>>
>>>>
>>>>
>>>>
>>>>
>>>>> Thanks for the patch. Please include the testcase expected output
>>>>> changes as well.
>>>>>
>>>>>
>>>> This patch already has a lot of other issues. I know I can provide a
>>>> truncate_1.out but I do not see the point.
>>>>
>>>> PFA, patch with the documentation fixed up.
>>>>
>>>> Regards,
>>>> Nikhils
>>>>
>>>>
>>>>>
>>>>> On Thu, Apr 25, 2013 at 2:21 PM, Nikhil Sontakke <ni...@st...>wrote:
>>>>>
>>>>>> PFA, the patch to disallow.
>>>>>>
>>>>>>
>>>>>> >> +1 so far.   Does anybody know how widely it is used?   I hope it
>>>>>> is not used widely.
>>>>>>
>>>>>> Suzuki-san, the user has an option to reset the sequence value
>>>>>> afterwards on his own to circumvent this issue. So it should be ok..
>>>>>>
>>>>>> Regards,
>>>>>> Nikhils
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Thu, Apr 25, 2013 at 2:05 PM, Ashutosh Bapat <
>>>>>> ash...@en...> wrote:
>>>>>>
>>>>>>> Can you please provide the patch to restrict the feature?
>>>>>>>
>>>>>>>
>>>>>>> On Thu, Apr 25, 2013 at 2:03 PM, Nikhil Sontakke <
>>>>>>> ni...@st...> wrote:
>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> If it can not be done easily and before release, we need to at
>>>>>>>>> least disable RESTART IDENTITY clause.
>>>>>>>>>
>>>>>>>>> +1 for now..
>>>>>>>>
>>>>>>>> Regards,
>>>>>>>> Nikhils
>>>>>>>>
>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Wed, Apr 24, 2013 at 11:45 PM, Nikhil Sontakke <
>>>>>>>>> ni...@st...> wrote:
>>>>>>>>>
>>>>>>>>>> Ok,
>>>>>>>>>> This is not so straight forward. We cannot reset the sequence
>>>>>>>>>> value in the GTM as is. We got to handle the case when the user can
>>>>>>>>>> rollback the truncate operation in which case the old value should still
>>>>>>>>>> hold.
>>>>>>>>>>
>>>>>>>>>> ISTM, we need to add handing code when the commit operation
>>>>>>>>>> actually unlinks the corresponding underlying relfilenode for the earlier
>>>>>>>>>> version of the sequence.
>>>>>>>>>>
>>>>>>>>>> Regards,
>>>>>>>>>> Nikhils
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On Wed, Apr 24, 2013 at 7:34 PM, Ashutosh Bapat <
>>>>>>>>>> ash...@en...> wrote:
>>>>>>>>>>
>>>>>>>>>>> Good, that works. This bug is causing testcase truncate to fail.
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> On Wed, Apr 24, 2013 at 6:53 PM, Nikhil Sontakke <
>>>>>>>>>>> ni...@st...> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> Hi Ashutosh,
>>>>>>>>>>>>
>>>>>>>>>>>> By the EOW?
>>>>>>>>>>>>
>>>>>>>>>>>> Regards,
>>>>>>>>>>>> Nikhils
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> On Wed, Apr 24, 2013 at 6:49 PM, Ashutosh Bapat <
>>>>>>>>>>>> ash...@en...> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> Hi Nikhil,
>>>>>>>>>>>>> Thanks for taking this up?
>>>>>>>>>>>>>
>>>>>>>>>>>>> By when do you think you can provide the patch?
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> On Wed, Apr 24, 2013 at 6:01 PM, Nikhil Sontakke <
>>>>>>>>>>>>> ni...@st...> wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> ResetSequence(), the function being called from
>>>>>>>>>>>>>>> ExecuteTruncate() does not send reset message to GTM. It applies sequence
>>>>>>>>>>>>>>> changes locally on the coordinator, which is not enough.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Can someone with relevant experience look into this problem
>>>>>>>>>>>>>>> and provide a fix?
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> I have attached the testcase and its output showing the bug.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>> I guess setval() was handled but we forgot to handle reset
>>>>>>>>>>>>>> sequence. I will take this up when I cleanup currval, nextval for negative
>>>>>>>>>>>>>> sequences.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Regards,
>>>>>>>>>>>>>> Nikhils
>>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> --
>>>>>>>>>>>>> Best Wishes,
>>>>>>>>>>>>> Ashutosh Bapat
>>>>>>>>>>>>> EntepriseDB Corporation
>>>>>>>>>>>>> The Postgres Database Company
>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> --
>>>>>>>>>>>> StormDB - http://www.stormdb.com
>>>>>>>>>>>> The Database Cloud
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> --
>>>>>>>>>>> Best Wishes,
>>>>>>>>>>> Ashutosh Bapat
>>>>>>>>>>> EntepriseDB Corporation
>>>>>>>>>>> The Postgres Database Company
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> StormDB - http://www.stormdb.com
>>>>>>>>>> The Database Cloud
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Best Wishes,
>>>>>>>>> Ashutosh Bapat
>>>>>>>>> EntepriseDB Corporation
>>>>>>>>> The Postgres Database Company
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> StormDB - http://www.stormdb.com
>>>>>>>> The Database Cloud
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Best Wishes,
>>>>>>> Ashutosh Bapat
>>>>>>> EntepriseDB Corporation
>>>>>>> The Postgres Database Company
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> StormDB - http://www.stormdb.com
>>>>>> The Database Cloud
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Best Wishes,
>>>>> Ashutosh Bapat
>>>>> EntepriseDB Corporation
>>>>> The Postgres Database Company
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> StormDB - http://www.stormdb.com
>>>> The Database Cloud
>>>>
>>>
>>>
>>>
>>> --
>>> Best Wishes,
>>> Ashutosh Bapat
>>> EntepriseDB Corporation
>>> The Postgres Database Company
>>>
>>
>>
>>
>> --
>> StormDB - http://www.stormdb.com
>> The Database Cloud
>>
>
>
>
> --
> Best Wishes,
> Ashutosh Bapat
> EntepriseDB Corporation
> The Postgres Database Company
>



-- 
StormDB - http://www.stormdb.com
The Database Cloud

Re: [Postgres-xc-developers] Fix for test case combocid

[Ashutosh B. <ash...@en...>]

Hi Abbas,
Since this diff is because we do not support a particular feature, I think,
we need up update alternate expected output file (only) with the diff.
There is no need to add any new SQL. If we do so, we will have problem in
future, when we start supporting SAVEPOINT.


On Wed, Apr 24, 2013 at 11:12 PM, Abbas Butt <abb...@en...>wrote:

> Hi,
> The test was failing because ctid was being selected and was not being
> reset explicitly.
> SAVEPOINT is not implemented yet and the transaction fails because of that
> statement.
> Due to the failure / rollback the ctid remains incremented and that
> incremented value
> is dependent on cluster configuration.
> The solution is to explicitly reset ctid using truncate statement.
>
> --
> *Abbas*
>  Architect
>
> Ph: 92.334.5100153
>  Skype ID: gabbasb
> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
> *
> Follow us on Twitter*
> @EnterpriseDB
>
> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>
>
> ------------------------------------------------------------------------------
> Try New Relic Now & We'll Send You this Cool Shirt
> New Relic is the only SaaS-based application performance monitoring service
> that delivers powerful full stack analytics. Optimize and monitor your
> browser, app, & servers with just a few lines of code. Try New Relic
> and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>
>


-- 
Best Wishes,
Ashutosh Bapat
EntepriseDB Corporation
The Postgres Database Company

Re: [Postgres-xc-developers] Fix for test case plpgsql

[Ashutosh B. <ash...@en...>]

Ok, this is good to go then.


On Tue, Apr 30, 2013 at 6:00 PM, Abbas Butt <abb...@en...>wrote:

>
>
> On Tue, Apr 30, 2013 at 5:04 PM, Ashutosh Bapat <
> ash...@en...> wrote:
>
>> Hi Abbas,
>> This change looks confusing. The statements where you have added order by
>> clause do not correspond to the statements where you have changed the
>> output. Can you please explain this?
>>
>
> The output of the test cases are changed because there was an error in the
> expected output files of these test cases. These outputs have to be
> modified (and the modified output is correct) because of your check in
> 2608af3d5288607e8245fa10e74e7307bb1bb23d.
>
> The order by clause is added in test cases where the expected output was
> already in order, but results were coming out to be in different order
> depending on node configuration.
>
>
>>
>> Also, whenever you change .sql and need to change the .out for that,
>> please change all the alt. expected output files.
>>
>
> Sure
>
>
>>
>>
>> On Thu, Apr 25, 2013 at 4:58 PM, Abbas Butt <abb...@en...>wrote:
>>
>>> Hi,
>>> Attached please find patch to fix test case plpgsql. The test was
>>> failing for some order by issues, Also there were some errors in expected
>>> output.
>>>
>>> --
>>> *Abbas*
>>>  Architect
>>>
>>> Ph: 92.334.5100153
>>>  Skype ID: gabbasb
>>> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
>>> *
>>> Follow us on Twitter*
>>> @EnterpriseDB
>>>
>>> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Try New Relic Now & We'll Send You this Cool Shirt
>>> New Relic is the only SaaS-based application performance monitoring
>>> service
>>> that delivers powerful full stack analytics. Optimize and monitor your
>>> browser, app, & servers with just a few lines of code. Try New Relic
>>> and get this awesome Nerd Life shirt!
>>> http://p.sf.net/sfu/newrelic_d2d_apr
>>> _______________________________________________
>>> Postgres-xc-developers mailing list
>>> Pos...@li...
>>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>>
>>>
>>
>>
>> --
>> Best Wishes,
>> Ashutosh Bapat
>> EntepriseDB Corporation
>> The Postgres Database Company
>>
>
>
>
> --
> --
> *Abbas*
>  Architect
>
> Ph: 92.334.5100153
>  Skype ID: gabbasb
> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
> *
> Follow us on Twitter*
> @EnterpriseDB
>
> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>



-- 
Best Wishes,
Ashutosh Bapat
EntepriseDB Corporation
The Postgres Database Company

Re: [Postgres-xc-developers] Fix for test case xc_misc

[Ashutosh B. <ash...@en...>]

Hi Abbas,
The right fix is at line 402. Because of the condition there, we do not
call GetPreferredReplicationNode() if there is FOR SHARE/FOR UPDATE clause
there. I think we need to modify the condition.

 392     if (exec_nodes && exec_nodes->nodeList)
 393     {
 394         /*
 395          * If this is the highest level query in the query tree and
 396          * relations involved in the query are such that ultimate JOIN
is
 397          * replicated JOIN, choose only one of them.
 398          * If we do this for lower level queries in query tree, we
might loose
 399          * chance because common nodes are left out.
 400          */
 401         if (IsExecNodesReplicated(exec_nodes) &&
 402             exec_nodes->accesstype == RELATION_ACCESS_READ &&
 403             sc_context->sc_query_level == 0)
 404
 405         {
 406             List *tmp_list = exec_nodes->nodeList;
 407             exec_nodes->nodeList =
GetPreferredReplicationNode(exec_nodes->nodeList);
 408             list_free(tmp_list);
 409         }
 410         return exec_nodes;
 411     }

Regarding other places where you have used the wrapper around
GetPreferredReplicationNode(); we don't need those code changes. We set
en_expr only for distributed relations and en_relid is set and used
properly only for DMLs when this problem would not happen. May be we should
add assertions at these places to make sure that we don't come there for
replicated tables and FOR SHARE/UDPATE SELECTs.



On Tue, May 7, 2013 at 10:21 AM, Abbas Butt <abb...@en...>wrote:

> I changed to code by creating another function and calling it right after
> GetRelationNodes where needed. Updated patch attached.
>
>
> On Tue, Apr 30, 2013 at 3:41 PM, Ashutosh Bapat <
> ash...@en...> wrote:
>
>> Hi Abbas,
>> Instead of fixing this in GetRelationNodes, we should fix it outside, by
>> calling GetPrefferedNode on the result returned by GetRelationNodes for
>> replicated tables. Please send a revised patch with this change. May be you
>> want to examine all callers of GetRelationNodes.
>>
>>
>> On Wed, Apr 24, 2013 at 10:58 PM, Abbas Butt <abb...@en...
>> > wrote:
>>
>>> Hi,
>>> The test case fails if there is no primary node in the cluster. The
>>> following test case was producing error.
>>>
>>> CREATE TABLE tt_22 (a int, b int) distribute by replication;
>>> INSERT INTO tt_22 VALUES (10);
>>>
>>> In a four datanode cluster the following query plan was being produced.
>>>
>>> explain verbose SELECT * FROM tt_22 FOR UPDATE;
>>>                                  QUERY
>>> PLAN
>>>
>>> ----------------------------------------------------------------------------
>>>  Data Node Scan on "__REMOTE_FQS_QUERY__"  (cost=0.00..0.00 rows=0
>>> width=0)
>>>    Output: tt_22.a, tt_22.b
>>>    Node/s: data_node_1, data_node_2, data_node_3, data_node_4
>>>    Remote query: SELECT a, b FROM tt_22 FOR UPDATE OF tt_22
>>> (4 rows)
>>>
>>> The reason was a missing else case in GetRelationNodes.
>>>
>>>
>>> --
>>> *Abbas*
>>>  Architect
>>>
>>> Ph: 92.334.5100153
>>>  Skype ID: gabbasb
>>> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
>>> *
>>> Follow us on Twitter*
>>> @EnterpriseDB
>>>
>>> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Try New Relic Now & We'll Send You this Cool Shirt
>>> New Relic is the only SaaS-based application performance monitoring
>>> service
>>> that delivers powerful full stack analytics. Optimize and monitor your
>>> browser, app, & servers with just a few lines of code. Try New Relic
>>> and get this awesome Nerd Life shirt!
>>> http://p.sf.net/sfu/newrelic_d2d_apr
>>> _______________________________________________
>>> Postgres-xc-developers mailing list
>>> Pos...@li...
>>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>>
>>>
>>
>>
>> --
>> Best Wishes,
>> Ashutosh Bapat
>> EntepriseDB Corporation
>> The Postgres Database Company
>>
>
>
>
> --
> --
> *Abbas*
>  Architect
>
> Ph: 92.334.5100153
>  Skype ID: gabbasb
> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
> *
> Follow us on Twitter*
> @EnterpriseDB
>
> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>



-- 
Best Wishes,
Ashutosh Bapat
EntepriseDB Corporation
The Postgres Database Company

Re: [Postgres-xc-developers] Fix for test case select_views

[Abbas B. <abb...@en...>]

ok, sure.

On Tue, May 7, 2013 at 11:37 AM, Ashutosh Bapat <
ash...@en...> wrote:

> BTW, fix the bug in separate patch and fix expected outputs in separate
> patch.
>
>
> On Tue, May 7, 2013 at 11:54 AM, Ashutosh Bapat <
> ash...@en...> wrote:
>
>> Can you please fix the bug then?
>>
>>
>> On Tue, May 7, 2013 at 10:25 AM, Abbas Butt <abb...@en...>wrote:
>>
>>>
>>>
>>> On Tue, Apr 30, 2013 at 4:57 PM, Ashutosh Bapat <
>>> ash...@en...> wrote:
>>>
>>>> Hi Abbas,
>>>> I see that the EXPLAIN commands are changed to include the XC specific
>>>> options. Since the original test is using capital letters everywhere, it's
>>>> better to maintain that style.
>>>>
>>>
>>> Done.
>>>
>>>
>>>>
>>>> Please make sure that the changes you have done (explain output)
>>>> reflect in all the alt. expected output files.
>>>>
>>>
>>> Done.
>>>
>>>
>>>>  Can you please see if we can eliminate the alternate expected output
>>>> files as well? What are the reasons we have to maintain those?
>>>>
>>>
>>> select_views.out and select_view_1.out are maintained by vanilla PG. We
>>> have added select_views_2.out and It can be removed, however I noticed that
>>> the test case that was added (Leaky View Scenario) is failing and needs a
>>> fix.
>>>
>>>
>>>>
>>>>
>>>> On Wed, Apr 24, 2013 at 10:59 PM, Abbas Butt <
>>>> abb...@en...> wrote:
>>>>
>>>>> Hi,
>>>>> The test was failing because some more tests are added in sql file.
>>>>>
>>>>> --
>>>>> *Abbas*
>>>>>  Architect
>>>>>
>>>>> Ph: 92.334.5100153
>>>>>  Skype ID: gabbasb
>>>>> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
>>>>> *
>>>>> Follow us on Twitter*
>>>>> @EnterpriseDB
>>>>>
>>>>> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>>>>>
>>>>>
>>>>> ------------------------------------------------------------------------------
>>>>> Try New Relic Now & We'll Send You this Cool Shirt
>>>>> New Relic is the only SaaS-based application performance monitoring
>>>>> service
>>>>> that delivers powerful full stack analytics. Optimize and monitor your
>>>>> browser, app, & servers with just a few lines of code. Try New Relic
>>>>> and get this awesome Nerd Life shirt!
>>>>> http://p.sf.net/sfu/newrelic_d2d_apr
>>>>> _______________________________________________
>>>>> Postgres-xc-developers mailing list
>>>>> Pos...@li...
>>>>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Best Wishes,
>>>> Ashutosh Bapat
>>>> EntepriseDB Corporation
>>>> The Postgres Database Company
>>>>
>>>
>>>
>>>
>>> --
>>> --
>>> *Abbas*
>>>  Architect
>>>
>>> Ph: 92.334.5100153
>>>  Skype ID: gabbasb
>>> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
>>> *
>>> Follow us on Twitter*
>>> @EnterpriseDB
>>>
>>> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>>>
>>
>>
>>
>> --
>> Best Wishes,
>> Ashutosh Bapat
>> EntepriseDB Corporation
>> The Postgres Database Company
>>
>
>
>
> --
> Best Wishes,
> Ashutosh Bapat
> EntepriseDB Corporation
> The Postgres Database Company
>



-- 
-- 
*Abbas*
 Architect

Ph: 92.334.5100153
 Skype ID: gabbasb
www.enterprisedb.co
<http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
*
Follow us on Twitter*
@EnterpriseDB

Visit EnterpriseDB for tutorials, webinars,
whitepapers<http://www.enterprisedb.com/resources-community>and
more<http://www.enterprisedb.com/resources-community>

Re: [Postgres-xc-developers] Fix for test case select_views

[Ashutosh B. <ash...@en...>]

BTW, fix the bug in separate patch and fix expected outputs in separate
patch.


On Tue, May 7, 2013 at 11:54 AM, Ashutosh Bapat <
ash...@en...> wrote:

> Can you please fix the bug then?
>
>
> On Tue, May 7, 2013 at 10:25 AM, Abbas Butt <abb...@en...>wrote:
>
>>
>>
>> On Tue, Apr 30, 2013 at 4:57 PM, Ashutosh Bapat <
>> ash...@en...> wrote:
>>
>>> Hi Abbas,
>>> I see that the EXPLAIN commands are changed to include the XC specific
>>> options. Since the original test is using capital letters everywhere, it's
>>> better to maintain that style.
>>>
>>
>> Done.
>>
>>
>>>
>>> Please make sure that the changes you have done (explain output) reflect
>>> in all the alt. expected output files.
>>>
>>
>> Done.
>>
>>
>>>  Can you please see if we can eliminate the alternate expected output
>>> files as well? What are the reasons we have to maintain those?
>>>
>>
>> select_views.out and select_view_1.out are maintained by vanilla PG. We
>> have added select_views_2.out and It can be removed, however I noticed that
>> the test case that was added (Leaky View Scenario) is failing and needs a
>> fix.
>>
>>
>>>
>>>
>>> On Wed, Apr 24, 2013 at 10:59 PM, Abbas Butt <
>>> abb...@en...> wrote:
>>>
>>>> Hi,
>>>> The test was failing because some more tests are added in sql file.
>>>>
>>>> --
>>>> *Abbas*
>>>>  Architect
>>>>
>>>> Ph: 92.334.5100153
>>>>  Skype ID: gabbasb
>>>> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
>>>> *
>>>> Follow us on Twitter*
>>>> @EnterpriseDB
>>>>
>>>> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>>>>
>>>>
>>>> ------------------------------------------------------------------------------
>>>> Try New Relic Now & We'll Send You this Cool Shirt
>>>> New Relic is the only SaaS-based application performance monitoring
>>>> service
>>>> that delivers powerful full stack analytics. Optimize and monitor your
>>>> browser, app, & servers with just a few lines of code. Try New Relic
>>>> and get this awesome Nerd Life shirt!
>>>> http://p.sf.net/sfu/newrelic_d2d_apr
>>>> _______________________________________________
>>>> Postgres-xc-developers mailing list
>>>> Pos...@li...
>>>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>>>
>>>>
>>>
>>>
>>> --
>>> Best Wishes,
>>> Ashutosh Bapat
>>> EntepriseDB Corporation
>>> The Postgres Database Company
>>>
>>
>>
>>
>> --
>> --
>> *Abbas*
>>  Architect
>>
>> Ph: 92.334.5100153
>>  Skype ID: gabbasb
>> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
>> *
>> Follow us on Twitter*
>> @EnterpriseDB
>>
>> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>>
>
>
>
> --
> Best Wishes,
> Ashutosh Bapat
> EntepriseDB Corporation
> The Postgres Database Company
>



-- 
Best Wishes,
Ashutosh Bapat
EntepriseDB Corporation
The Postgres Database Company

Re: [Postgres-xc-developers] Fix for test case select_views

[Ashutosh B. <ash...@en...>]

Can you please fix the bug then?


On Tue, May 7, 2013 at 10:25 AM, Abbas Butt <abb...@en...>wrote:

>
>
> On Tue, Apr 30, 2013 at 4:57 PM, Ashutosh Bapat <
> ash...@en...> wrote:
>
>> Hi Abbas,
>> I see that the EXPLAIN commands are changed to include the XC specific
>> options. Since the original test is using capital letters everywhere, it's
>> better to maintain that style.
>>
>
> Done.
>
>
>>
>> Please make sure that the changes you have done (explain output) reflect
>> in all the alt. expected output files.
>>
>
> Done.
>
>
>>  Can you please see if we can eliminate the alternate expected output
>> files as well? What are the reasons we have to maintain those?
>>
>
> select_views.out and select_view_1.out are maintained by vanilla PG. We
> have added select_views_2.out and It can be removed, however I noticed that
> the test case that was added (Leaky View Scenario) is failing and needs a
> fix.
>
>
>>
>>
>> On Wed, Apr 24, 2013 at 10:59 PM, Abbas Butt <abb...@en...
>> > wrote:
>>
>>> Hi,
>>> The test was failing because some more tests are added in sql file.
>>>
>>> --
>>> *Abbas*
>>>  Architect
>>>
>>> Ph: 92.334.5100153
>>>  Skype ID: gabbasb
>>> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
>>> *
>>> Follow us on Twitter*
>>> @EnterpriseDB
>>>
>>> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Try New Relic Now & We'll Send You this Cool Shirt
>>> New Relic is the only SaaS-based application performance monitoring
>>> service
>>> that delivers powerful full stack analytics. Optimize and monitor your
>>> browser, app, & servers with just a few lines of code. Try New Relic
>>> and get this awesome Nerd Life shirt!
>>> http://p.sf.net/sfu/newrelic_d2d_apr
>>> _______________________________________________
>>> Postgres-xc-developers mailing list
>>> Pos...@li...
>>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>>
>>>
>>
>>
>> --
>> Best Wishes,
>> Ashutosh Bapat
>> EntepriseDB Corporation
>> The Postgres Database Company
>>
>
>
>
> --
> --
> *Abbas*
>  Architect
>
> Ph: 92.334.5100153
>  Skype ID: gabbasb
> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
> *
> Follow us on Twitter*
> @EnterpriseDB
>
> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>



-- 
Best Wishes,
Ashutosh Bapat
EntepriseDB Corporation
The Postgres Database Company

Re: [Postgres-xc-developers] Fix for regression failures in inherit.sql

[Abbas B. <abb...@en...>]

I am ok with the changes in the test. It worked fine for me.

On Mon, Apr 22, 2013 at 3:10 PM, Ashutosh Bapat <
ash...@en...> wrote:

> Hi All,
> The testcase was failing because of change in the query plans (because of
> LIMIT optimization) and queries returning unpredictable results (because of
> lack of order by clause). I have corrected the plans and added order by
> clause to the queries.
>
> There is only one query (multiple instances) which needed order by clause.
> It's
> select * from patest0 join (select f1 from int4_tbl limit 1) ss on id = f1
> Since the first row inserted in int4_tbl has f1 = 0, the subquery "select
> f1 from int4_tbl limit 1" returns 0 in PG, whereas that may not be true in
> XC, hence we need to add order by and where clause to make sure that the
> subquery returns 0.
>
> I found that inherit.out and inherit_1.out had more than differences
> necessary (only differences expected were those because of tableoid). I
> have removed those differences.
> --
> Best Wishes,
> Ashutosh Bapat
> EntepriseDB Corporation
> The Postgres Database Company
>
>
> ------------------------------------------------------------------------------
> Precog is a next-generation analytics platform capable of advanced
> analytics on semi-structured data. The platform includes APIs for building
> apps and a phenomenal toolset for data science. Developers can use
> our toolset for easy data analysis & visualization. Get a free account!
> http://www2.precog.com/precogplatform/slashdotnewsletter
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>
>


-- 
-- 
*Abbas*
 Architect

Ph: 92.334.5100153
 Skype ID: gabbasb
www.enterprisedb.co
<http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
*
Follow us on Twitter*
@EnterpriseDB

Visit EnterpriseDB for tutorials, webinars,
whitepapers<http://www.enterprisedb.com/resources-community>and
more<http://www.enterprisedb.com/resources-community>

Re: [Postgres-xc-developers] Fix regressions in truncate

[Abbas B. <abb...@en...>]

I am ok with the changes in the test case. It worked fine for me.

On Thu, Apr 25, 2013 at 4:23 PM, Ashutosh Bapat <
ash...@en...> wrote:

> Hi All,
> PFA the patch which fixes the regressions truncate.sql.
>
> Because of one foreign key constraint, one table needed to be replicated
> instead of distributed. There were some diffs because statement triggers
> are now enabled. This diff should have been resolved when statement trigger
> work was completed.
>
> --
> Best Wishes,
> Ashutosh Bapat
> EntepriseDB Corporation
> The Postgres Database Company
>
>
> ------------------------------------------------------------------------------
> Try New Relic Now & We'll Send You this Cool Shirt
> New Relic is the only SaaS-based application performance monitoring service
> that delivers powerful full stack analytics. Optimize and monitor your
> browser, app, & servers with just a few lines of code. Try New Relic
> and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>
>


-- 
-- 
*Abbas*
 Architect

Ph: 92.334.5100153
 Skype ID: gabbasb
www.enterprisedb.co
<http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
*
Follow us on Twitter*
@EnterpriseDB

Visit EnterpriseDB for tutorials, webinars,
whitepapers<http://www.enterprisedb.com/resources-community>and
more<http://www.enterprisedb.com/resources-community>

Re: [Postgres-xc-developers] Fix for test case select_views

[Abbas B. <abb...@en...>]

On Tue, Apr 30, 2013 at 4:57 PM, Ashutosh Bapat <
ash...@en...> wrote:

> Hi Abbas,
> I see that the EXPLAIN commands are changed to include the XC specific
> options. Since the original test is using capital letters everywhere, it's
> better to maintain that style.
>

Done.


>
> Please make sure that the changes you have done (explain output) reflect
> in all the alt. expected output files.
>

Done.


> Can you please see if we can eliminate the alternate expected output files
> as well? What are the reasons we have to maintain those?
>

select_views.out and select_view_1.out are maintained by vanilla PG. We
have added select_views_2.out and It can be removed, however I noticed that
the test case that was added (Leaky View Scenario) is failing and needs a
fix.


>
>
> On Wed, Apr 24, 2013 at 10:59 PM, Abbas Butt <abb...@en...>wrote:
>
>> Hi,
>> The test was failing because some more tests are added in sql file.
>>
>> --
>> *Abbas*
>>  Architect
>>
>> Ph: 92.334.5100153
>>  Skype ID: gabbasb
>> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
>> *
>> Follow us on Twitter*
>> @EnterpriseDB
>>
>> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>>
>>
>> ------------------------------------------------------------------------------
>> Try New Relic Now & We'll Send You this Cool Shirt
>> New Relic is the only SaaS-based application performance monitoring
>> service
>> that delivers powerful full stack analytics. Optimize and monitor your
>> browser, app, & servers with just a few lines of code. Try New Relic
>> and get this awesome Nerd Life shirt!
>> http://p.sf.net/sfu/newrelic_d2d_apr
>> _______________________________________________
>> Postgres-xc-developers mailing list
>> Pos...@li...
>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>
>>
>
>
> --
> Best Wishes,
> Ashutosh Bapat
> EntepriseDB Corporation
> The Postgres Database Company
>



-- 
-- 
*Abbas*
 Architect

Ph: 92.334.5100153
 Skype ID: gabbasb
www.enterprisedb.co
<http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
*
Follow us on Twitter*
@EnterpriseDB

Visit EnterpriseDB for tutorials, webinars,
whitepapers<http://www.enterprisedb.com/resources-community>and
more<http://www.enterprisedb.com/resources-community>

Re: [Postgres-xc-developers] Fix for test case xc_misc

[Abbas B. <abb...@en...>]

I changed to code by creating another function and calling it right after
GetRelationNodes where needed. Updated patch attached.

On Tue, Apr 30, 2013 at 3:41 PM, Ashutosh Bapat <
ash...@en...> wrote:

> Hi Abbas,
> Instead of fixing this in GetRelationNodes, we should fix it outside, by
> calling GetPrefferedNode on the result returned by GetRelationNodes for
> replicated tables. Please send a revised patch with this change. May be you
> want to examine all callers of GetRelationNodes.
>
>
> On Wed, Apr 24, 2013 at 10:58 PM, Abbas Butt <abb...@en...>wrote:
>
>> Hi,
>> The test case fails if there is no primary node in the cluster. The
>> following test case was producing error.
>>
>> CREATE TABLE tt_22 (a int, b int) distribute by replication;
>> INSERT INTO tt_22 VALUES (10);
>>
>> In a four datanode cluster the following query plan was being produced.
>>
>> explain verbose SELECT * FROM tt_22 FOR UPDATE;
>>                                  QUERY
>> PLAN
>>
>> ----------------------------------------------------------------------------
>>  Data Node Scan on "__REMOTE_FQS_QUERY__"  (cost=0.00..0.00 rows=0
>> width=0)
>>    Output: tt_22.a, tt_22.b
>>    Node/s: data_node_1, data_node_2, data_node_3, data_node_4
>>    Remote query: SELECT a, b FROM tt_22 FOR UPDATE OF tt_22
>> (4 rows)
>>
>> The reason was a missing else case in GetRelationNodes.
>>
>>
>> --
>> *Abbas*
>>  Architect
>>
>> Ph: 92.334.5100153
>>  Skype ID: gabbasb
>> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
>> *
>> Follow us on Twitter*
>> @EnterpriseDB
>>
>> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>>
>>
>> ------------------------------------------------------------------------------
>> Try New Relic Now & We'll Send You this Cool Shirt
>> New Relic is the only SaaS-based application performance monitoring
>> service
>> that delivers powerful full stack analytics. Optimize and monitor your
>> browser, app, & servers with just a few lines of code. Try New Relic
>> and get this awesome Nerd Life shirt!
>> http://p.sf.net/sfu/newrelic_d2d_apr
>> _______________________________________________
>> Postgres-xc-developers mailing list
>> Pos...@li...
>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>
>>
>
>
> --
> Best Wishes,
> Ashutosh Bapat
> EntepriseDB Corporation
> The Postgres Database Company
>



-- 
-- 
*Abbas*
 Architect

Ph: 92.334.5100153
 Skype ID: gabbasb
www.enterprisedb.co
<http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
*
Follow us on Twitter*
@EnterpriseDB

Visit EnterpriseDB for tutorials, webinars,
whitepapers<http://www.enterprisedb.com/resources-community>and
more<http://www.enterprisedb.com/resources-community>

Re: [Postgres-xc-developers] Fix for test case copy2

[Abbas B. <abb...@en...>]

On Tue, Apr 30, 2013 at 4:19 PM, Ashutosh Bapat <
ash...@en...> wrote:

> Hi Abbas,
> copy2 has an alternate output file. So, if you change .sql file, you need
> to make corresponding changes in .out and _1.out. There is one missing
> change about not enforcing 2PC with temporary tables, which needs to be
> carried to .out file as well.
>

Done.


>
> Otherwise the change looks good. While adding the ORDER BY clause, hope
> you have made sure that the data that is output is same except for change
> in the ordering.
>

True.


>
> This testcase needs to be looked at by Amit for the trigger related
> changes. After that I think we should remove alt. output file.
>

The data in copy2.out and copy2_1.out is different because FOR EACH ROW
triggers are not fired on coordinators.
There is one other difference and that is
---
> "Jackson, Sam",\h
> "It is ""perfect"".",
214,215c214,215
< "Jackson, Sam","\h"
< "It is ""perfect"".","    "

Note quotes around \h in one case and no quotes in the other.

So we need to decide how to take care of these two changes in the data
before we remove the alternate expected output file.



>
>
> On Wed, Apr 24, 2013 at 10:58 PM, Abbas Butt <abb...@en...>wrote:
>
>> Hi,
>> Test was failing because of some order by issues in COPY TO statements.
>>
>> --
>> *Abbas*
>>  Architect
>>
>> Ph: 92.334.5100153
>>  Skype ID: gabbasb
>> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
>> *
>> Follow us on Twitter*
>> @EnterpriseDB
>>
>> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>>
>>
>> ------------------------------------------------------------------------------
>> Try New Relic Now & We'll Send You this Cool Shirt
>> New Relic is the only SaaS-based application performance monitoring
>> service
>> that delivers powerful full stack analytics. Optimize and monitor your
>> browser, app, & servers with just a few lines of code. Try New Relic
>> and get this awesome Nerd Life shirt!
>> http://p.sf.net/sfu/newrelic_d2d_apr
>> _______________________________________________
>> Postgres-xc-developers mailing list
>> Pos...@li...
>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>
>>
>
>
> --
> Best Wishes,
> Ashutosh Bapat
> EntepriseDB Corporation
> The Postgres Database Company
>



-- 
-- 
*Abbas*
 Architect

Ph: 92.334.5100153
 Skype ID: gabbasb
www.enterprisedb.co
<http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
*
Follow us on Twitter*
@EnterpriseDB

Visit EnterpriseDB for tutorials, webinars,
whitepapers<http://www.enterprisedb.com/resources-community>and
more<http://www.enterprisedb.com/resources-community>

Re: [Postgres-xc-developers] Fix for test case plpgsql

[Abbas B. <abb...@en...>]

On Tue, Apr 30, 2013 at 5:04 PM, Ashutosh Bapat <
ash...@en...> wrote:

> Hi Abbas,
> This change looks confusing. The statements where you have added order by
> clause do not correspond to the statements where you have changed the
> output. Can you please explain this?
>

The output of the test cases are changed because there was an error in the
expected output files of these test cases. These outputs have to be
modified (and the modified output is correct) because of your check in
2608af3d5288607e8245fa10e74e7307bb1bb23d.

The order by clause is added in test cases where the expected output was
already in order, but results were coming out to be in different order
depending on node configuration.


>
> Also, whenever you change .sql and need to change the .out for that,
> please change all the alt. expected output files.
>

Sure


>
>
> On Thu, Apr 25, 2013 at 4:58 PM, Abbas Butt <abb...@en...>wrote:
>
>> Hi,
>> Attached please find patch to fix test case plpgsql. The test was failing
>> for some order by issues, Also there were some errors in expected output.
>>
>> --
>> *Abbas*
>>  Architect
>>
>> Ph: 92.334.5100153
>>  Skype ID: gabbasb
>> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
>> *
>> Follow us on Twitter*
>> @EnterpriseDB
>>
>> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>>
>>
>> ------------------------------------------------------------------------------
>> Try New Relic Now & We'll Send You this Cool Shirt
>> New Relic is the only SaaS-based application performance monitoring
>> service
>> that delivers powerful full stack analytics. Optimize and monitor your
>> browser, app, & servers with just a few lines of code. Try New Relic
>> and get this awesome Nerd Life shirt!
>> http://p.sf.net/sfu/newrelic_d2d_apr
>> _______________________________________________
>> Postgres-xc-developers mailing list
>> Pos...@li...
>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>
>>
>
>
> --
> Best Wishes,
> Ashutosh Bapat
> EntepriseDB Corporation
> The Postgres Database Company
>



-- 
-- 
*Abbas*
 Architect

Ph: 92.334.5100153
 Skype ID: gabbasb
www.enterprisedb.co
<http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
*
Follow us on Twitter*
@EnterpriseDB

Visit EnterpriseDB for tutorials, webinars,
whitepapers<http://www.enterprisedb.com/resources-community>and
more<http://www.enterprisedb.com/resources-community>