postgres-xc-developers — Postgres-XC hackers and developers

Re: [Postgres-xc-developers] pgxc_ctl does not compile of Mac OS X

[Koichi S. <koi...@gm...>]

Thanks Nikhil for the patch.

I have a couple of questions on this patch.

1, Did you run only pgxc_ctl on Mac OS and the others (all XC components)
on Linux?
2. Did you really test that pgxc_ctl runs on Mac OS?   pgxc_ctl uses so
many system() functions so it is shell script dependent.   I do hope all
the shell scripts used in pgxc_ctl works in Mac OS too.

Regards;




2013/8/7 Nikhil Sontakke <ni...@st...>

> Hi Suzuki san,
>
> PFA, patch which allows pgxc_ctl to compile on OS X.
>
> Regards,
> Nikhils
> --
> StormDB - http://www.stormdb.com
> The Database Cloud
>
> ------------------------------------------------------------------------------
> Get 100% visibility into Java/.NET code with AppDynamics Lite!
> It's a free troubleshooting tool designed for production.
> Get down to code-level detail for bottlenecks, with <2% overhead.
> Download for free and get started troubleshooting in minutes.
> http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>
>

Re: [Postgres-xc-developers] [Postgres-xc-general] Sourceforge repository upgraded

[Michael P. <mic...@gm...>]

On Wed, Aug 7, 2013 at 11:33 AM, Koichi Suzuki <koi...@gm...> wrote:
> Postgres-XC sourceforge repository has been upgraded successfully.   There
> are no change in development page URL.    GIT repository URL changed.
The new URL can be found here:
http://sourceforge.net/p/postgres-xc/postgres-xc/ci/master/tree/
And you can use git protocol:
git clone git://git.code.sf.net/p/postgres-xc/postgres-xc
postgres-xc-postgres-xc
or https to clone the repository:
git clone http://git.code.sf.net/p/postgres-xc/postgres-xc
postgres-xc-postgres-xc

>
> Top page of the development page will have "GIT" tag, where you can choose a
> repository (postgres-xc, in this case) then you will get URLs for RW, RO and
> HTTPS, depending your privilege to the repo.
RW = read-write
RO = read-only
HTTP = can be both depending on your status on the project concerned

> I've not tested if we can continue to use local repo just with changing
> configuration.
What do you mean by that? You just need to change the link to remote
folder by either running for example "git remote set-url" or even
setting directly .git/config. This does not impact your local
environment, the commits SHA1 as well as the commit history are still
the same.

> Hope they provide faster link.
It looks that the new layer of their website is very github-like. This
is not necessarily a bad thing :) https is something people have
wanted in sourceforge for years... Definitely useful for people hidden
behind a company firewall.
-- 
Michael

[Postgres-xc-developers] Sourceforge repository upgraded

[Koichi S. <koi...@gm...>]

Hello;

Postgres-XC sourceforge repository has been upgraded successfully.   There
are no change in development page URL.    GIT repository URL changed.

Top page of the development page will have "GIT" tag, where you can choose
a repository (postgres-xc, in this case) then you will get URLs for RW, RO
and HTTPS, depending your privilege to the repo.

I've not tested if we can continue to use local repo just with changing
configuration.

Hope they provide faster link.

Good Luck;
---
Koichi Suzuki

Re: [Postgres-xc-developers] [JDBC Regression] Fix wrongly written boolean tests

[Masataka S. <pg...@gm...>]

I'm sorry to be late.

This is the thing I intended.
All right to change other tests like this one.

On Wed, Aug 7, 2013 at 8:33 AM, Abbas Butt <abb...@en...> wrote:
> Hi,
> Please spare some time for this patch, once accepted the same technique
> needs to be applied to fix integer, date. time and time-stamp tests.
> Thanks.
>
>
> On Tue, Aug 6, 2013 at 8:27 AM, Abbas Butt <abb...@en...>
> wrote:
>>
>> PFA revised patch.
>>
>>
>> On Tue, Aug 6, 2013 at 7:21 AM, Masataka Saito <pg...@gm...> wrote:
>>>
>>> I meant append a serial column to the tail of tables.
>>> Then you need not to modify INSERTs and SELECT targets because they
>>> want first column to test.
>>>
>>> e.g.
>>>   TestUtil.createTable(con, "testbool", "i serial, a boolean");
>>>      ->   TestUtil.createTable(con, "testbool", "a boolean, i serial");
>>>
>>>   stmt.executeUpdate("INSERT INTO testboolstring VALUES('true')");
>>>      ->   (needless to change)
>>>
>>>   ResultSet rs = con.createStatement().executeQuery("select * from
>>> testbool");
>>>      ->  ResultSet rs = con.createStatement().executeQuery("select *
>>> from testbool");
>>>            rs.close();
>>>            rs = con.createStatement().executeQuery("select * from
>>> testbool order by i");
>>>       (Of course, you can branch statement like you did.)
>>>
>>> Regards.
>>>
>>> On Mon, Aug 5, 2013 at 9:16 PM, Abbas Butt <abb...@en...>
>>> wrote:
>>> > Please use this patch for review, attached the wrong patch file with
>>> > the
>>> > previous mail.
>>> >
>>> >
>>> > On Mon, Aug 5, 2013 at 4:59 PM, Abbas Butt
>>> > <abb...@en...>
>>> > wrote:
>>> >>
>>> >> Attached please find a revised patch according to your suggestion.
>>> >> I am holding the rest of the patches till you review this one, because
>>> >> we
>>> >> need similar changes for integer, date, time and time-stamp tests.
>>> >>
>>> >>
>>> >> On Mon, Aug 5, 2013 at 12:45 PM, Masataka Saito <pg...@gm...>
>>> >> wrote:
>>> >>>
>>> >>> Hi,
>>> >>>
>>> >>> I feel feckless for sorting assertins.
>>> >>>
>>> >>> I propose appending a serial column to test tables and SELECT rows
>>> >>> ORDERED BY it.
>>> >>> I think this idea makes costless and it doesn't against to the gist
>>> >>> of
>>> >>> the test.
>>> >>>
>>> >>> Regards.
>>> >>>
>>> >>> On Fri, Aug 2, 2013 at 8:47 PM, Abbas Butt
>>> >>> <abb...@en...>
>>> >>> wrote:
>>> >>> > Hi,
>>> >>> > PFA patch to fix wrongly written boolean tests, patch comments
>>> >>> > explain
>>> >>> > the
>>> >>> > errors and the fix.
>>> >>> >
>>> >>> > --
>>> >>> > Abbas
>>> >>> > Architect
>>> >>> >
>>> >>> > Ph: 92.334.5100153
>>> >>> > Skype ID: gabbasb
>>> >>> > www.enterprisedb.com
>>> >>> >
>>> >>> > Follow us on Twitter
>>> >>> > @EnterpriseDB
>>> >>> >
>>> >>> > Visit EnterpriseDB for tutorials, webinars, whitepapers and more
>>> >>> >
>>> >>> >
>>> >>> >
>>> >>> > ------------------------------------------------------------------------------
>>> >>> > Get your SQL database under version control now!
>>> >>> > Version control is standard for application code, but databases
>>> >>> > havent
>>> >>> > caught up. So what steps can you take to put your SQL databases
>>> >>> > under
>>> >>> > version control? Why should you start doing it? Read more to find
>>> >>> > out.
>>> >>> >
>>> >>> >
>>> >>> > http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk
>>> >>> > _______________________________________________
>>> >>> > Postgres-xc-developers mailing list
>>> >>> > Pos...@li...
>>> >>> > https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>> >>> >
>>> >>
>>> >>
>>> >>
>>> >>
>>> >> --
>>> >> --
>>> >> Abbas
>>> >> Architect
>>> >>
>>> >> Ph: 92.334.5100153
>>> >> Skype ID: gabbasb
>>> >> www.enterprisedb.com
>>> >>
>>> >> Follow us on Twitter
>>> >> @EnterpriseDB
>>> >>
>>> >> Visit EnterpriseDB for tutorials, webinars, whitepapers and more
>>> >
>>> >
>>> >
>>> >
>>> > --
>>> > --
>>> > Abbas
>>> > Architect
>>> >
>>> > Ph: 92.334.5100153
>>> > Skype ID: gabbasb
>>> > www.enterprisedb.com
>>> >
>>> > Follow us on Twitter
>>> > @EnterpriseDB
>>> >
>>> > Visit EnterpriseDB for tutorials, webinars, whitepapers and more
>>
>>
>>
>>
>> --
>> --
>> Abbas
>> Architect
>>
>> Ph: 92.334.5100153
>> Skype ID: gabbasb
>> www.enterprisedb.com
>>
>> Follow us on Twitter
>> @EnterpriseDB
>>
>> Visit EnterpriseDB for tutorials, webinars, whitepapers and more
>
>
>
>
> --
> --
> Abbas
> Architect
>
> Ph: 92.334.5100153
> Skype ID: gabbasb
> www.enterprisedb.com
>
> Follow us on Twitter
> @EnterpriseDB
>
> Visit EnterpriseDB for tutorials, webinars, whitepapers and more

Re: [Postgres-xc-developers] [JDBC Regression] Fix wrongly written boolean tests

[Abbas B. <abb...@en...>]

Hi,
Please spare some time for this patch, once accepted the same technique
needs to be applied to fix integer, date. time and time-stamp tests.
Thanks.

On Tue, Aug 6, 2013 at 8:27 AM, Abbas Butt <abb...@en...>wrote:

> PFA revised patch.
>
>
> On Tue, Aug 6, 2013 at 7:21 AM, Masataka Saito <pg...@gm...> wrote:
>
>> I meant append a serial column to the tail of tables.
>> Then you need not to modify INSERTs and SELECT targets because they
>> want first column to test.
>>
>> e.g.
>>   TestUtil.createTable(con, "testbool", "i serial, a boolean");
>>      ->   TestUtil.createTable(con, "testbool", "a boolean, i serial");
>>
>>   stmt.executeUpdate("INSERT INTO testboolstring VALUES('true')");
>>      ->   (needless to change)
>>
>>   ResultSet rs = con.createStatement().executeQuery("select * from
>> testbool");
>>      ->  ResultSet rs = con.createStatement().executeQuery("select *
>> from testbool");
>>            rs.close();
>>            rs = con.createStatement().executeQuery("select * from
>> testbool order by i");
>>       (Of course, you can branch statement like you did.)
>>
>> Regards.
>>
>> On Mon, Aug 5, 2013 at 9:16 PM, Abbas Butt <abb...@en...>
>> wrote:
>> > Please use this patch for review, attached the wrong patch file with the
>> > previous mail.
>> >
>> >
>> > On Mon, Aug 5, 2013 at 4:59 PM, Abbas Butt <abb...@en...
>> >
>> > wrote:
>> >>
>> >> Attached please find a revised patch according to your suggestion.
>> >> I am holding the rest of the patches till you review this one, because
>> we
>> >> need similar changes for integer, date, time and time-stamp tests.
>> >>
>> >>
>> >> On Mon, Aug 5, 2013 at 12:45 PM, Masataka Saito <pg...@gm...>
>> wrote:
>> >>>
>> >>> Hi,
>> >>>
>> >>> I feel feckless for sorting assertins.
>> >>>
>> >>> I propose appending a serial column to test tables and SELECT rows
>> >>> ORDERED BY it.
>> >>> I think this idea makes costless and it doesn't against to the gist of
>> >>> the test.
>> >>>
>> >>> Regards.
>> >>>
>> >>> On Fri, Aug 2, 2013 at 8:47 PM, Abbas Butt <
>> abb...@en...>
>> >>> wrote:
>> >>> > Hi,
>> >>> > PFA patch to fix wrongly written boolean tests, patch comments
>> explain
>> >>> > the
>> >>> > errors and the fix.
>> >>> >
>> >>> > --
>> >>> > Abbas
>> >>> > Architect
>> >>> >
>> >>> > Ph: 92.334.5100153
>> >>> > Skype ID: gabbasb
>> >>> > www.enterprisedb.com
>> >>> >
>> >>> > Follow us on Twitter
>> >>> > @EnterpriseDB
>> >>> >
>> >>> > Visit EnterpriseDB for tutorials, webinars, whitepapers and more
>> >>> >
>> >>> >
>> >>> >
>> ------------------------------------------------------------------------------
>> >>> > Get your SQL database under version control now!
>> >>> > Version control is standard for application code, but databases
>> havent
>> >>> > caught up. So what steps can you take to put your SQL databases
>> under
>> >>> > version control? Why should you start doing it? Read more to find
>> out.
>> >>> >
>> >>> >
>> http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk
>> >>> > _______________________________________________
>> >>> > Postgres-xc-developers mailing list
>> >>> > Pos...@li...
>> >>> > https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>> >>> >
>> >>
>> >>
>> >>
>> >>
>> >> --
>> >> --
>> >> Abbas
>> >> Architect
>> >>
>> >> Ph: 92.334.5100153
>> >> Skype ID: gabbasb
>> >> www.enterprisedb.com
>> >>
>> >> Follow us on Twitter
>> >> @EnterpriseDB
>> >>
>> >> Visit EnterpriseDB for tutorials, webinars, whitepapers and more
>> >
>> >
>> >
>> >
>> > --
>> > --
>> > Abbas
>> > Architect
>> >
>> > Ph: 92.334.5100153
>> > Skype ID: gabbasb
>> > www.enterprisedb.com
>> >
>> > Follow us on Twitter
>> > @EnterpriseDB
>> >
>> > Visit EnterpriseDB for tutorials, webinars, whitepapers and more
>>
>
>
>
> --
> --
> *Abbas*
>  Architect
>
> Ph: 92.334.5100153
>  Skype ID: gabbasb
> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
> *
> Follow us on Twitter*
> @EnterpriseDB
>
> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>



-- 
-- 
*Abbas*
 Architect

Ph: 92.334.5100153
 Skype ID: gabbasb
www.enterprisedb.co
<http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
*
Follow us on Twitter*
@EnterpriseDB

Visit EnterpriseDB for tutorials, webinars,
whitepapers<http://www.enterprisedb.com/resources-community>and
more<http://www.enterprisedb.com/resources-community>

Re: [Postgres-xc-developers] GTM/GTM Proxy invalid handles and failed to get snapshot issues

[Nikhil S. <ni...@st...>]

> Can GTM/proxy cleanup the pending list when it detects the death of a
> connection, just like GTM does its cleanup?
>
>
Well, the pending requests are not stored in a per client list. We could go
and look for this specific client in the list though and clean it up. But
remember that the client might have given a set of instructions to the
proxy and disappeared legitimately. So processing all requests in order
before processing the disconnection seems much cleaner.

Regards,
Nikhils


>
> On Tue, Aug 6, 2013 at 11:03 AM, Nikhil Sontakke <ni...@st...>wrote:
>
>>
>> A naive question,
>>> Can we also cleanup the pending list?
>>>
>>>
>> Umm, the processed commands are put onto the thr_processed_commands list
>> and freed up eventually. Is that what you were asking?
>>
>> Regards,
>> Nikhils
>>
>>>
>>>  On Tue, Aug 6, 2013 at 9:56 AM, Nikhil Sontakke <ni...@st...>wrote:
>>>
>>>> Hi,
>>>>
>>>> We have had a long standing issue with a GTM Proxy in the mix. It has
>>>> been reported here:
>>>>
>>>>
>>>> http://sourceforge.net/mailarchive/forum.php?thread_name=CAB7nPqQ51fabopxCOHPrRM%3D2WTJMikfZUPHNEW942DDHmED7bQ%40mail.gmail.com&forum_name=postgres-xc-developers
>>>>
>>>> I think I found the root cause:
>>>>
>>>> Here's how things work:
>>>>
>>>> The client connects to proxy. The proxy internally connects to the GTM.
>>>>
>>>> Some commands from clients are sent immediately to the GTM by the
>>>> proxy.
>>>>
>>>> Some commands are put in the pending list on the proxy for batch
>>>> processing later.
>>>>
>>>> Now, if the client goes away before processing pending commands, the
>>>> proxy is immediately telling the GTM so. That initiates a cleanup on the
>>>> GTM side and removes the XIDs associated with this client. After this
>>>> cleanup when the GTM receives a command like "MSG_SNAPSHOT_GET" or
>>>> "MSG_TXN_COMMIT_MULTI" etc. from the pending list from the proxy, then it's
>>>> going to get confused.
>>>>
>>>> A way to handle this is to put "disconnected" messages also onto the
>>>> pending list. We then process these "disconnected" messages LAST from the
>>>> pending list.
>>>>
>>>> I have tried this fix and run a number of tests (using pgbench) and
>>>> things seem to be ok. I do not see the invalid handle and snapshot errors
>>>> on the GTM side with this patch in place.
>>>>
>>>> PFA, patches for 1.0, 1.1 and head attached with this email.
>>>>
>>>> Regards,
>>>> Nikhils
>>>> --
>>>> StormDB - http://www.stormdb.com
>>>> The Database Cloud
>>>>
>>>> ------------------------------------------------------------------------------
>>>> Get your SQL database under version control now!
>>>> Version control is standard for application code, but databases havent
>>>> caught up. So what steps can you take to put your SQL databases under
>>>> version control? Why should you start doing it? Read more to find out.
>>>>
>>>> http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
>>>> _______________________________________________
>>>> Postgres-xc-developers mailing list
>>>> Pos...@li...
>>>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>>>
>>>>
>>>
>>>
>>> --
>>> Best Wishes,
>>> Ashutosh Bapat
>>> EntepriseDB Corporation
>>> The Postgres Database Company
>>>
>>
>>
>>
>> --
>> StormDB - http://www.stormdb.com
>> The Database Cloud
>>
>
>
>
> --
> Best Wishes,
> Ashutosh Bapat
> EntepriseDB Corporation
> The Postgres Database Company
>



-- 
StormDB - http://www.stormdb.com
The Database Cloud

Re: [Postgres-xc-developers] GTM/GTM Proxy invalid handles and failed to get snapshot issues

[Ashutosh B. <ash...@en...>]

Sorry, I wasn't clear enough.

Can GTM/proxy cleanup the pending list when it detects the death of a
connection, just like GTM does its cleanup?


On Tue, Aug 6, 2013 at 11:03 AM, Nikhil Sontakke <ni...@st...>wrote:

>
> A naive question,
>> Can we also cleanup the pending list?
>>
>>
> Umm, the processed commands are put onto the thr_processed_commands list
> and freed up eventually. Is that what you were asking?
>
> Regards,
> Nikhils
>
>>
>>  On Tue, Aug 6, 2013 at 9:56 AM, Nikhil Sontakke <ni...@st...>wrote:
>>
>>> Hi,
>>>
>>> We have had a long standing issue with a GTM Proxy in the mix. It has
>>> been reported here:
>>>
>>>
>>> http://sourceforge.net/mailarchive/forum.php?thread_name=CAB7nPqQ51fabopxCOHPrRM%3D2WTJMikfZUPHNEW942DDHmED7bQ%40mail.gmail.com&forum_name=postgres-xc-developers
>>>
>>> I think I found the root cause:
>>>
>>> Here's how things work:
>>>
>>> The client connects to proxy. The proxy internally connects to the GTM.
>>>
>>> Some commands from clients are sent immediately to the GTM by the proxy.
>>>
>>> Some commands are put in the pending list on the proxy for batch
>>> processing later.
>>>
>>> Now, if the client goes away before processing pending commands, the
>>> proxy is immediately telling the GTM so. That initiates a cleanup on the
>>> GTM side and removes the XIDs associated with this client. After this
>>> cleanup when the GTM receives a command like "MSG_SNAPSHOT_GET" or
>>> "MSG_TXN_COMMIT_MULTI" etc. from the pending list from the proxy, then it's
>>> going to get confused.
>>>
>>> A way to handle this is to put "disconnected" messages also onto the
>>> pending list. We then process these "disconnected" messages LAST from the
>>> pending list.
>>>
>>> I have tried this fix and run a number of tests (using pgbench) and
>>> things seem to be ok. I do not see the invalid handle and snapshot errors
>>> on the GTM side with this patch in place.
>>>
>>> PFA, patches for 1.0, 1.1 and head attached with this email.
>>>
>>> Regards,
>>> Nikhils
>>> --
>>> StormDB - http://www.stormdb.com
>>> The Database Cloud
>>>
>>> ------------------------------------------------------------------------------
>>> Get your SQL database under version control now!
>>> Version control is standard for application code, but databases havent
>>> caught up. So what steps can you take to put your SQL databases under
>>> version control? Why should you start doing it? Read more to find out.
>>>
>>> http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
>>> _______________________________________________
>>> Postgres-xc-developers mailing list
>>> Pos...@li...
>>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>>
>>>
>>
>>
>> --
>> Best Wishes,
>> Ashutosh Bapat
>> EntepriseDB Corporation
>> The Postgres Database Company
>>
>
>
>
> --
> StormDB - http://www.stormdb.com
> The Database Cloud
>



-- 
Best Wishes,
Ashutosh Bapat
EntepriseDB Corporation
The Postgres Database Company

Re: [Postgres-xc-developers] GTM/GTM Proxy invalid handles and failed to get snapshot issues

[Nikhil S. <ni...@st...>]

> A naive question,
> Can we also cleanup the pending list?
>
>
Umm, the processed commands are put onto the thr_processed_commands list
and freed up eventually. Is that what you were asking?

Regards,
Nikhils

>
> On Tue, Aug 6, 2013 at 9:56 AM, Nikhil Sontakke <ni...@st...>wrote:
>
>> Hi,
>>
>> We have had a long standing issue with a GTM Proxy in the mix. It has
>> been reported here:
>>
>>
>> http://sourceforge.net/mailarchive/forum.php?thread_name=CAB7nPqQ51fabopxCOHPrRM%3D2WTJMikfZUPHNEW942DDHmED7bQ%40mail.gmail.com&forum_name=postgres-xc-developers
>>
>> I think I found the root cause:
>>
>> Here's how things work:
>>
>> The client connects to proxy. The proxy internally connects to the GTM.
>>
>> Some commands from clients are sent immediately to the GTM by the proxy.
>>
>> Some commands are put in the pending list on the proxy for batch
>> processing later.
>>
>> Now, if the client goes away before processing pending commands, the
>> proxy is immediately telling the GTM so. That initiates a cleanup on the
>> GTM side and removes the XIDs associated with this client. After this
>> cleanup when the GTM receives a command like "MSG_SNAPSHOT_GET" or
>> "MSG_TXN_COMMIT_MULTI" etc. from the pending list from the proxy, then it's
>> going to get confused.
>>
>> A way to handle this is to put "disconnected" messages also onto the
>> pending list. We then process these "disconnected" messages LAST from the
>> pending list.
>>
>> I have tried this fix and run a number of tests (using pgbench) and
>> things seem to be ok. I do not see the invalid handle and snapshot errors
>> on the GTM side with this patch in place.
>>
>> PFA, patches for 1.0, 1.1 and head attached with this email.
>>
>> Regards,
>> Nikhils
>> --
>> StormDB - http://www.stormdb.com
>> The Database Cloud
>>
>> ------------------------------------------------------------------------------
>> Get your SQL database under version control now!
>> Version control is standard for application code, but databases havent
>> caught up. So what steps can you take to put your SQL databases under
>> version control? Why should you start doing it? Read more to find out.
>>
>> http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
>> _______________________________________________
>> Postgres-xc-developers mailing list
>> Pos...@li...
>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>
>>
>
>
> --
> Best Wishes,
> Ashutosh Bapat
> EntepriseDB Corporation
> The Postgres Database Company
>



-- 
StormDB - http://www.stormdb.com
The Database Cloud

Re: [Postgres-xc-developers] GTM/GTM Proxy invalid handles and failed to get snapshot issues

[Ashutosh B. <ash...@en...>]

A naive question,
Can we also cleanup the pending list?


On Tue, Aug 6, 2013 at 9:56 AM, Nikhil Sontakke <ni...@st...> wrote:

> Hi,
>
> We have had a long standing issue with a GTM Proxy in the mix. It has been
> reported here:
>
>
> http://sourceforge.net/mailarchive/forum.php?thread_name=CAB7nPqQ51fabopxCOHPrRM%3D2WTJMikfZUPHNEW942DDHmED7bQ%40mail.gmail.com&forum_name=postgres-xc-developers
>
> I think I found the root cause:
>
> Here's how things work:
>
> The client connects to proxy. The proxy internally connects to the GTM.
>
> Some commands from clients are sent immediately to the GTM by the proxy.
>
> Some commands are put in the pending list on the proxy for batch
> processing later.
>
> Now, if the client goes away before processing pending commands, the proxy
> is immediately telling the GTM so. That initiates a cleanup on the GTM side
> and removes the XIDs associated with this client. After this cleanup when
> the GTM receives a command like "MSG_SNAPSHOT_GET" or
> "MSG_TXN_COMMIT_MULTI" etc. from the pending list from the proxy, then it's
> going to get confused.
>
> A way to handle this is to put "disconnected" messages also onto the
> pending list. We then process these "disconnected" messages LAST from the
> pending list.
>
> I have tried this fix and run a number of tests (using pgbench) and things
> seem to be ok. I do not see the invalid handle and snapshot errors on the
> GTM side with this patch in place.
>
> PFA, patches for 1.0, 1.1 and head attached with this email.
>
> Regards,
> Nikhils
> --
> StormDB - http://www.stormdb.com
> The Database Cloud
>
> ------------------------------------------------------------------------------
> Get your SQL database under version control now!
> Version control is standard for application code, but databases havent
> caught up. So what steps can you take to put your SQL databases under
> version control? Why should you start doing it? Read more to find out.
> http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>
>


-- 
Best Wishes,
Ashutosh Bapat
EntepriseDB Corporation
The Postgres Database Company

Re: [Postgres-xc-developers] GTM memory leak

[Nikhil S. <ni...@st...>]

> One of the reasons why I chose to do it this way is to reduce the impact
> on the code that I borrowed heavily from Postgres and turned it into
> multi-threaded architecture. Thats why we also see something like
> TopMostMemoryContext. I wanted to emulate thread as a process, but a few
> things were required to be at process level.
>

Yeah, I understand your point of view. I am just saying that it confuses
things. I have reported one core earlier just because someone palloc'ed in
TopMemoryContext "assuming" that it's the top memory context and not the
memory context of the thread. I am talking about those kinds of confusion.

As I said, the current code looks ok enough and takes care to cleanup
memory contexts appropriately AFAICS.

Regards,
Nikhils


>
>
>> thrinfo->thr_error_context = AllocSetContextCreate(ErrorContext,
>>
>> The comment above this line says
>>
>>     /*
>>      * Each thread gets its own ErrorContext and its a child of
>> ErrorContext of
>>      * the main process
>>      */
>>
>> However due to the inclusion of gtm.h, ErrorContext becomes a macro and
>> expands to GetMyThreadInfo->thr_error_context which should be NULL!
>>
>> However the code is careful to track and release contexts AFAICS. But we
>> need to be mindful of this in the future as well.
>>
>>
> Will check that code.
>
> Thanks,
> Pavan
>



-- 
StormDB - http://www.stormdb.com
The Database Cloud

Re: [Postgres-xc-developers] GTM memory leak

[Pavan D. <pav...@gm...>]

On Tue, Aug 6, 2013 at 9:34 AM, Nikhil Sontakke <ni...@st...> wrote:

> Me and Andrei looked at the code a bit. Other things look ok in general.
>
> Again the use of defines in gtm.h like:
>
> #define TopMemoryContext        (GetMyThreadInfo->thr_thread_context)
>
> make me nervous. This can cause issues in the future as well. As an
> example, the following code in GTM_ThreadCreate:
>
>
One of the reasons why I chose to do it this way is to reduce the impact on
the code that I borrowed heavily from Postgres and turned it into
multi-threaded architecture. Thats why we also see something like
TopMostMemoryContext. I wanted to emulate thread as a process, but a few
things were required to be at process level.


> thrinfo->thr_error_context = AllocSetContextCreate(ErrorContext,
>
> The comment above this line says
>
>     /*
>      * Each thread gets its own ErrorContext and its a child of
> ErrorContext of
>      * the main process
>      */
>
> However due to the inclusion of gtm.h, ErrorContext becomes a macro and
> expands to GetMyThreadInfo->thr_error_context which should be NULL!
>
> However the code is careful to track and release contexts AFAICS. But we
> need to be mindful of this in the future as well.
>
>
Will check that code.

Thanks,
Pavan

Re: [Postgres-xc-developers] GTM memory leak

[Nikhil S. <ni...@st...>]

Me and Andrei looked at the code a bit. Other things look ok in general.

Again the use of defines in gtm.h like:

#define TopMemoryContext        (GetMyThreadInfo->thr_thread_context)

make me nervous. This can cause issues in the future as well. As an
example, the following code in GTM_ThreadCreate:

thrinfo->thr_error_context = AllocSetContextCreate(ErrorContext,

The comment above this line says

    /*
     * Each thread gets its own ErrorContext and its a child of
ErrorContext of
     * the main process
     */

However due to the inclusion of gtm.h, ErrorContext becomes a macro and
expands to GetMyThreadInfo->thr_error_context which should be NULL!

However the code is careful to track and release contexts AFAICS. But we
need to be mindful of this in the future as well.

Regards,
Nikhils



On Tue, Aug 6, 2013 at 7:25 AM, Koichi Suzuki <koi...@gm...> wrote:

> Okay, the patch looks nice.
>
> Andrei, did you find any similar (wrong) memory handling?
>
> Regards;
> ---
> Koichi Suzuki
>
>
> 2013/8/6 Andrei Martsinchyk <and...@gm...>
>
>>  GTM never pfrees pstrdup'ed value of gti_coordname, and therefore leaks
>> memory in the TopMostMemoryContext.
>> Please find fix attached. The patch is made against the master branch,
>> but applies to STABLE branches, to 1_0 with offsets.
>> There were two places where GTM_TransactionInfo was cleaned up, so the
>> code was pulled out into a separate function, for easier maintenance.
>>
>> --
>> Andrei Martsinchyk
>>
>> StormDB - http://www.stormdb.com
>> The Database Cloud
>>
>>
>>
>> ------------------------------------------------------------------------------
>> Get your SQL database under version control now!
>> Version control is standard for application code, but databases havent
>> caught up. So what steps can you take to put your SQL databases under
>> version control? Why should you start doing it? Read more to find out.
>>
>> http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk
>> _______________________________________________
>> Postgres-xc-developers mailing list
>> Pos...@li...
>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>
>>
>
>
> ------------------------------------------------------------------------------
> Get your SQL database under version control now!
> Version control is standard for application code, but databases havent
> caught up. So what steps can you take to put your SQL databases under
> version control? Why should you start doing it? Read more to find out.
> http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>
>


-- 
StormDB - http://www.stormdb.com
The Database Cloud

Re: [Postgres-xc-developers] GTM memory leak

[Andrei M. <and...@gm...>]

2013/8/6 Koichi Suzuki <koi...@gm...>

> Okay, the patch looks nice.
>
> Andrei, did you find any similar (wrong) memory handling?
>
>
No, if I did, I would come up with a patch or bug report.


> Regards;
> ---
> Koichi Suzuki
>
>
> 2013/8/6 Andrei Martsinchyk <and...@gm...>
>
>> GTM never pfrees pstrdup'ed value of gti_coordname, and therefore leaks
>> memory in the TopMostMemoryContext.
>> Please find fix attached. The patch is made against the master branch,
>> but applies to STABLE branches, to 1_0 with offsets.
>> There were two places where GTM_TransactionInfo was cleaned up, so the
>> code was pulled out into a separate function, for easier maintenance.
>>
>> --
>> Andrei Martsinchyk
>>
>> StormDB - http://www.stormdb.com
>> The Database Cloud
>>
>>
>>
>> ------------------------------------------------------------------------------
>> Get your SQL database under version control now!
>> Version control is standard for application code, but databases havent
>> caught up. So what steps can you take to put your SQL databases under
>> version control? Why should you start doing it? Read more to find out.
>>
>> http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk
>> _______________________________________________
>> Postgres-xc-developers mailing list
>> Pos...@li...
>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>
>>
>


-- 
Andrei Martsinchyk

StormDB - http://www.stormdb.com
The Database Cloud

Re: [Postgres-xc-developers] [JDBC Regression] Fix wrongly written boolean tests

[Abbas B. <abb...@en...>]

PFA revised patch.

On Tue, Aug 6, 2013 at 7:21 AM, Masataka Saito <pg...@gm...> wrote:

> I meant append a serial column to the tail of tables.
> Then you need not to modify INSERTs and SELECT targets because they
> want first column to test.
>
> e.g.
>   TestUtil.createTable(con, "testbool", "i serial, a boolean");
>      ->   TestUtil.createTable(con, "testbool", "a boolean, i serial");
>
>   stmt.executeUpdate("INSERT INTO testboolstring VALUES('true')");
>      ->   (needless to change)
>
>   ResultSet rs = con.createStatement().executeQuery("select * from
> testbool");
>      ->  ResultSet rs = con.createStatement().executeQuery("select *
> from testbool");
>            rs.close();
>            rs = con.createStatement().executeQuery("select * from
> testbool order by i");
>       (Of course, you can branch statement like you did.)
>
> Regards.
>
> On Mon, Aug 5, 2013 at 9:16 PM, Abbas Butt <abb...@en...>
> wrote:
> > Please use this patch for review, attached the wrong patch file with the
> > previous mail.
> >
> >
> > On Mon, Aug 5, 2013 at 4:59 PM, Abbas Butt <abb...@en...>
> > wrote:
> >>
> >> Attached please find a revised patch according to your suggestion.
> >> I am holding the rest of the patches till you review this one, because
> we
> >> need similar changes for integer, date, time and time-stamp tests.
> >>
> >>
> >> On Mon, Aug 5, 2013 at 12:45 PM, Masataka Saito <pg...@gm...>
> wrote:
> >>>
> >>> Hi,
> >>>
> >>> I feel feckless for sorting assertins.
> >>>
> >>> I propose appending a serial column to test tables and SELECT rows
> >>> ORDERED BY it.
> >>> I think this idea makes costless and it doesn't against to the gist of
> >>> the test.
> >>>
> >>> Regards.
> >>>
> >>> On Fri, Aug 2, 2013 at 8:47 PM, Abbas Butt <
> abb...@en...>
> >>> wrote:
> >>> > Hi,
> >>> > PFA patch to fix wrongly written boolean tests, patch comments
> explain
> >>> > the
> >>> > errors and the fix.
> >>> >
> >>> > --
> >>> > Abbas
> >>> > Architect
> >>> >
> >>> > Ph: 92.334.5100153
> >>> > Skype ID: gabbasb
> >>> > www.enterprisedb.com
> >>> >
> >>> > Follow us on Twitter
> >>> > @EnterpriseDB
> >>> >
> >>> > Visit EnterpriseDB for tutorials, webinars, whitepapers and more
> >>> >
> >>> >
> >>> >
> ------------------------------------------------------------------------------
> >>> > Get your SQL database under version control now!
> >>> > Version control is standard for application code, but databases
> havent
> >>> > caught up. So what steps can you take to put your SQL databases under
> >>> > version control? Why should you start doing it? Read more to find
> out.
> >>> >
> >>> >
> http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk
> >>> > _______________________________________________
> >>> > Postgres-xc-developers mailing list
> >>> > Pos...@li...
> >>> > https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
> >>> >
> >>
> >>
> >>
> >>
> >> --
> >> --
> >> Abbas
> >> Architect
> >>
> >> Ph: 92.334.5100153
> >> Skype ID: gabbasb
> >> www.enterprisedb.com
> >>
> >> Follow us on Twitter
> >> @EnterpriseDB
> >>
> >> Visit EnterpriseDB for tutorials, webinars, whitepapers and more
> >
> >
> >
> >
> > --
> > --
> > Abbas
> > Architect
> >
> > Ph: 92.334.5100153
> > Skype ID: gabbasb
> > www.enterprisedb.com
> >
> > Follow us on Twitter
> > @EnterpriseDB
> >
> > Visit EnterpriseDB for tutorials, webinars, whitepapers and more
>



-- 
-- 
*Abbas*
 Architect

Ph: 92.334.5100153
 Skype ID: gabbasb
www.enterprisedb.co
<http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
*
Follow us on Twitter*
@EnterpriseDB

Visit EnterpriseDB for tutorials, webinars,
whitepapers<http://www.enterprisedb.com/resources-community>and
more<http://www.enterprisedb.com/resources-community>

Re: [Postgres-xc-developers] [JDBC Regression] Fix for XC does not support serializable transactions

[Masataka S. <pg...@gm...>]

It's good.

On Mon, Aug 5, 2013 at 9:23 PM, Abbas Butt <abb...@en...> wrote:
> PFA revised patch.
>
>
> On Mon, Aug 5, 2013 at 3:22 PM, Masataka Saito <pg...@gm...> wrote:
>>
>> On Mon, Aug 5, 2013 at 6:35 PM, Abbas Butt <abb...@en...>
>> wrote:
>> >
>> >
>> > On Mon, Aug 5, 2013 at 2:18 PM, Masataka Saito <pg...@gm...> wrote:
>> >>
>> >> The patch will work fine.
>> >>
>> >> But this is my basal question:
>> >> setTransactionIsolation(Connection.TRANSACTION_SERIALIZABLE) after XC
>> >> block doesn't raise an exception, I know.
>> >> Is it right shelving unsupported isolation level without an error?
>> >
>> >
>> > It is due to already checked in code
>> >
>> > void
>> > assign_XactIsoLevel(const char *newval, void *extra)
>> > {
>> >     XactIsoLevel = *((int *) extra);
>> > #ifdef PGXC
>> >     /*
>> >      * PGXCTODO - PGXC does not support 9.1 serializable transactions
>> > yet
>> >      */
>> >     if (XactIsoLevel == XACT_SERIALIZABLE)
>> >         XactIsoLevel = XACT_REPEATABLE_READ;
>> > #endif
>> > }
>> >
>> > I think we already have a source forge ticket to deal with this XC
>> > limitation.
>>
>> Thanks.
>> I know it caused by XC limitation.
>>
>> I thought that unsupported level should be denied by
>> check_XactIsoLevel rather than modified at assign_XactIsoLevel.
>> I shouldn't grumble reviewed commit. I'm sorry to be bothering you with
>> this.
>>
>> Reading check_XactIsoLevel, I found XC doesn't support SERIALIZABLE
>> but supports other levels.
>> I think you could replace SERIALIZABLE to other transaction level
>> (e.g. REPEATABLE READ) instead of skipping.
>> It is more natural by the gist of the test case.
>>
>> >
>> >
>> >>
>> >>
>> >> On Fri, Aug 2, 2013 at 4:36 PM, Abbas Butt
>> >> <abb...@en...>
>> >> wrote:
>> >> > Hi,
>> >> > PFA patch to make sure that JDBC regression skips tests for
>> >> > serializable
>> >> > transactions.
>> >> >
>> >> > --
>> >> > Abbas
>> >> > Architect
>> >> >
>> >> > Ph: 92.334.5100153
>> >> > Skype ID: gabbasb
>> >> > www.enterprisedb.com
>> >> >
>> >> > Follow us on Twitter
>> >> > @EnterpriseDB
>> >> >
>> >> > Visit EnterpriseDB for tutorials, webinars, whitepapers and more
>> >> >
>> >> >
>> >> >
>> >> > ------------------------------------------------------------------------------
>> >> > Get your SQL database under version control now!
>> >> > Version control is standard for application code, but databases
>> >> > havent
>> >> > caught up. So what steps can you take to put your SQL databases under
>> >> > version control? Why should you start doing it? Read more to find
>> >> > out.
>> >> >
>> >> >
>> >> > http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk
>> >> > _______________________________________________
>> >> > Postgres-xc-developers mailing list
>> >> > Pos...@li...
>> >> > https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>> >> >
>> >
>> >
>> >
>> >
>> > --
>> > --
>> > Abbas
>> > Architect
>> >
>> > Ph: 92.334.5100153
>> > Skype ID: gabbasb
>> > www.enterprisedb.com
>> >
>> > Follow us on Twitter
>> > @EnterpriseDB
>> >
>> > Visit EnterpriseDB for tutorials, webinars, whitepapers and more
>
>
>
>
> --
> --
> Abbas
> Architect
>
> Ph: 92.334.5100153
> Skype ID: gabbasb
> www.enterprisedb.com
>
> Follow us on Twitter
> @EnterpriseDB
>
> Visit EnterpriseDB for tutorials, webinars, whitepapers and more

Re: [Postgres-xc-developers] [JDBC Regression] Fix wrongly written boolean tests

[Masataka S. <pg...@gm...>]

I meant append a serial column to the tail of tables.
Then you need not to modify INSERTs and SELECT targets because they
want first column to test.

e.g.
  TestUtil.createTable(con, "testbool", "i serial, a boolean");
     ->   TestUtil.createTable(con, "testbool", "a boolean, i serial");

  stmt.executeUpdate("INSERT INTO testboolstring VALUES('true')");
     ->   (needless to change)

  ResultSet rs = con.createStatement().executeQuery("select * from testbool");
     ->  ResultSet rs = con.createStatement().executeQuery("select *
from testbool");
           rs.close();
           rs = con.createStatement().executeQuery("select * from
testbool order by i");
      (Of course, you can branch statement like you did.)

Regards.

On Mon, Aug 5, 2013 at 9:16 PM, Abbas Butt <abb...@en...> wrote:
> Please use this patch for review, attached the wrong patch file with the
> previous mail.
>
>
> On Mon, Aug 5, 2013 at 4:59 PM, Abbas Butt <abb...@en...>
> wrote:
>>
>> Attached please find a revised patch according to your suggestion.
>> I am holding the rest of the patches till you review this one, because we
>> need similar changes for integer, date, time and time-stamp tests.
>>
>>
>> On Mon, Aug 5, 2013 at 12:45 PM, Masataka Saito <pg...@gm...> wrote:
>>>
>>> Hi,
>>>
>>> I feel feckless for sorting assertins.
>>>
>>> I propose appending a serial column to test tables and SELECT rows
>>> ORDERED BY it.
>>> I think this idea makes costless and it doesn't against to the gist of
>>> the test.
>>>
>>> Regards.
>>>
>>> On Fri, Aug 2, 2013 at 8:47 PM, Abbas Butt <abb...@en...>
>>> wrote:
>>> > Hi,
>>> > PFA patch to fix wrongly written boolean tests, patch comments explain
>>> > the
>>> > errors and the fix.
>>> >
>>> > --
>>> > Abbas
>>> > Architect
>>> >
>>> > Ph: 92.334.5100153
>>> > Skype ID: gabbasb
>>> > www.enterprisedb.com
>>> >
>>> > Follow us on Twitter
>>> > @EnterpriseDB
>>> >
>>> > Visit EnterpriseDB for tutorials, webinars, whitepapers and more
>>> >
>>> >
>>> > ------------------------------------------------------------------------------
>>> > Get your SQL database under version control now!
>>> > Version control is standard for application code, but databases havent
>>> > caught up. So what steps can you take to put your SQL databases under
>>> > version control? Why should you start doing it? Read more to find out.
>>> >
>>> > http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk
>>> > _______________________________________________
>>> > Postgres-xc-developers mailing list
>>> > Pos...@li...
>>> > https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>> >
>>
>>
>>
>>
>> --
>> --
>> Abbas
>> Architect
>>
>> Ph: 92.334.5100153
>> Skype ID: gabbasb
>> www.enterprisedb.com
>>
>> Follow us on Twitter
>> @EnterpriseDB
>>
>> Visit EnterpriseDB for tutorials, webinars, whitepapers and more
>
>
>
>
> --
> --
> Abbas
> Architect
>
> Ph: 92.334.5100153
> Skype ID: gabbasb
> www.enterprisedb.com
>
> Follow us on Twitter
> @EnterpriseDB
>
> Visit EnterpriseDB for tutorials, webinars, whitepapers and more

Re: [Postgres-xc-developers] GTM memory leak

[Koichi S. <koi...@gm...>]

Okay, the patch looks nice.

Andrei, did you find any similar (wrong) memory handling?

Regards;
---
Koichi Suzuki


2013/8/6 Andrei Martsinchyk <and...@gm...>

> GTM never pfrees pstrdup'ed value of gti_coordname, and therefore leaks
> memory in the TopMostMemoryContext.
> Please find fix attached. The patch is made against the master branch, but
> applies to STABLE branches, to 1_0 with offsets.
> There were two places where GTM_TransactionInfo was cleaned up, so the
> code was pulled out into a separate function, for easier maintenance.
>
> --
> Andrei Martsinchyk
>
> StormDB - http://www.stormdb.com
> The Database Cloud
>
>
>
> ------------------------------------------------------------------------------
> Get your SQL database under version control now!
> Version control is standard for application code, but databases havent
> caught up. So what steps can you take to put your SQL databases under
> version control? Why should you start doing it? Read more to find out.
> http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>
>

Re: [Postgres-xc-developers] Barrier issues

[鈴木 幸市 <ko...@in...>]

Thanks.  I've already tested similar patch but it is not sufficient.

Somehow, response from GTM is received twice in a GTM-Proxy.   Because GTM-Proxy clears up all the response in each round of backend scan, I'm worrying this has be caused by bad response handling in GTM, which does not happen when backgrounds are connected directly to the GTM.

I'm asking Pavan a review on this.

Regards;
---
Koichi Suzuki

On 2013/08/02, at 12:39, Nikhil Sontakke <ni...@st...> wrote:

> Hi, 
> 
> I saw missing breaks for the MSG_BARRIER handling in both GTM and GTM_Proxy. I wonder if barrier works in the first place without these breaks? PFA, patch to fix this. AFAICS, the 1.1 branch also has similar issues.
> 
> Regards,
> Nikhils
> -- 
> StormDB - http://www.stormdb.com
> The Database Cloud <pgxc_head_barrier_missing_breaks.patch>------------------------------------------------------------------------------
> Get your SQL database under version control now!
> Version control is standard for application code, but databases havent 
> caught up. So what steps can you take to put your SQL databases under 
> version control? Why should you start doing it? Read more to find out.
> http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk_______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers

Re: [Postgres-xc-developers] Minor Fixes

[Michael P. <mic...@gm...>]

On Mon, Aug 5, 2013 at 10:09 PM, 鈴木 幸市 <ko...@in...> wrote:

> This depends on how serious the demand/usecase is and how works on it.
>  Yes, you can work on it and you must have demanding usecase.
>
> I mean when 1.1GA is out, it's safer to concentrate on the master.   This
> is a better place to work for Solaris.
>
As 1.1 stable branch and master are already separated, what is the point of
not committing what Matt has sent before it is forgotten? It is perfectly
possible to continue the development work on master while improving the 1.1
beta state. IMO, I think that we should look at what Matt could send.
-- 
Michael

Re: [Postgres-xc-developers] Minor Fixes

[鈴木 幸市 <ko...@in...>]

This depends on how serious the demand/usecase is and how works on it.  Yes, you can work on it and you must have demanding usecase.

I mean when 1.1GA is out, it's safer to concentrate on the master.   This is a better place to work for Solaris.

Regards;
---
Koichi Suzuki

On 2013/08/03, at 0:43, Matt Warner <MW...@XI...> wrote:

> Good morning.
>  
> I just wanted to check in and see whether there’s still an interest in the patches I submitted that allow XC to compile and run under Solaris with the Sun compiler.
>  
> Regards,
>  
> Matt
>  
> From: Koichi Suzuki [mailto:koi...@gm...] 
> Sent: Thursday, June 27, 2013 9:27 AM
> To: Matt Warner
> Cc: Postgres-XC Developers
> Subject: Re: [Postgres-xc-developers] Minor Fixes
>  
> Thank you Matt.
> 
> Please wait a bit until branch for 1.1 is built.
> 
> Regards;
> 
> ----------
> Koichi Suzuki
>  
> 
> 2013/6/28 Matt Warner <MW...@xi...>
> I’d be happy to continue testing on Solaris.
>  
> From: Koichi Suzuki [mailto:koi...@gm...] 
> Sent: Wednesday, June 26, 2013 11:19 PM
> To: Matt Warner; Postgres-XC Developers
> 
> Subject: Re: [Postgres-xc-developers] Minor Fixes
>  
> Hi,
> 
> I reviewed this thread again.  It may be better to include Matt's patch to the master after we build REL1_1_STABLE so that he can continue his Solaris-related work on the master.   As Ashutosh suggested, it will be less confusing not to include this in REL1_1_STABLE.
> 
> Because I'm about to build REL1_1_STABLE for beta work, please let me know if anybody need Matt's patch in 1.1.
> 
> Matt, could you let me know your idea and if you can continue to test XC on Solaris and declare that XC supports Solaris?
> 
> Best Regards;
> 
> ----------
> Koichi Suzuki
>  
> 
> 2013/6/25 Koichi Suzuki <koi...@gm...>
> I meant that removing "return" statement which returns another function return value will be a good refactoring.   Of course, simple return may not be removed.
>  
> 
> ----------
> Koichi Suzuki
>  
> 
> 2013/6/25 Koichi Suzuki <koi...@gm...>
> Year.   The code is not harmfull at all.    Removing "return" from void functions could be a good refactoring.   Although Solaris is not supported officieally yet, I think it's a good idea to have it in master.   I do hope Matt continues to test XC so that we can tell XC runs on Solaris.
> 
> Any more inputs?
> 
> Regardsds;
> 
> ----------
> Koichi Suzuki
>  
> 
> 2013/6/25 Matt Warner <MW...@xi...>
> I'll double check but I thought I'd only removed return from functions declaring void as their return type. 
>  
> ?
>  
> Matt
> 
> On Jun 23, 2013, at 6:22 PM, "鈴木 幸市" <ko...@in...> wrote:
> 
> The patch looks reasonable.   One comment: removing "return" for non-void function will cause Linux gcc warning.  For this case, we need #ifdef SOLARIS directive.
>  
> You sent two similar patch for proxy_main.c in separate e-mails.   The later one seems to resolve my comment above.   Although the core team cannot declare that XC runs on Solaris so far, I think the patch is reasonable to be included.
>  
> Any other comments?
> ---
> Koichi Suzuki
>  
>  
>  
> On 2013/06/22, at 1:26, Matt Warner <MW...@XI...> wrote:
>  
> 
> Regarding the other changes, they are specific to Solaris. For example, in src/backend/pgxc/pool/pgxcnode.c, Solaris requires we include sys/filio.h. I’ll be searching to see if I can find a macro already defined for Solaris that I can leverage to #ifdef those Solaris-specific items.
>  
> Matt
>  
> From: Matt Warner 
> Sent: Friday, June 21, 2013 9:21 AM
> To: 'Koichi Suzuki'
> Cc: 'pos...@li...'
> Subject: RE: [Postgres-xc-developers] Minor Fixes
>  
> First patch.
>  
> From: Matt Warner 
> Sent: Friday, June 21, 2013 8:50 AM
> To: 'Koichi Suzuki'
> Cc: pos...@li...
> Subject: RE: [Postgres-xc-developers] Minor Fixes
>  
> Yes, I’m running XC on Solaris x64.
>  
> From: Koichi Suzuki [mailto:koi...@gm...] 
> Sent: Thursday, June 20, 2013 6:34 PM
> To: Matt Warner
> Cc: pos...@li...
> Subject: Re: [Postgres-xc-developers] Minor Fixes
>  
> Thanks a lot for the patch.   As Michael mentioned, you can send a patch to developers mailing list.
>  
> BTW, core team tested current XC on 64bit Intel CentOS and others tested it against RedHat.    Did you test XC on Solaris?
>  
> Regards;
> 
> ----------
> Koichi Suzuki
>  
> 
> 2013/6/21 Matt Warner <MW...@xi...>
> Just a quick question about contributing fixes. I’ve had to make some minor changes to get XC compiled on Solaris x64.
> What format would you like to see for the changes? Most are very minor, such as removing return statements inside void functions (which the Solaris compiler flags as incorrect since you can’t return from a void function).
> Matt
>  
> 
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by Windows:
> 
> Build for Windows Store.
> 
> http://p.sf.net/sfu/windows-dev2dev
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
> 
>  
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by Windows:
> 
> Build for Windows Store.
> 
> http://p.sf.net/sfu/windows-dev2dev_______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>  
>  
>  
>  
>  
> ------------------------------------------------------------------------------
> Get your SQL database under version control now!
> Version control is standard for application code, but databases havent 
> caught up. So what steps can you take to put your SQL databases under 
> version control? Why should you start doing it? Read more to find out.
> http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk_______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers

Re: [Postgres-xc-developers] [JDBC Regression] Fix for XC does not support serializable transactions

[Abbas B. <abb...@en...>]

PFA revised patch.

On Mon, Aug 5, 2013 at 3:22 PM, Masataka Saito <pg...@gm...> wrote:

> On Mon, Aug 5, 2013 at 6:35 PM, Abbas Butt <abb...@en...>
> wrote:
> >
> >
> > On Mon, Aug 5, 2013 at 2:18 PM, Masataka Saito <pg...@gm...> wrote:
> >>
> >> The patch will work fine.
> >>
> >> But this is my basal question:
> >> setTransactionIsolation(Connection.TRANSACTION_SERIALIZABLE) after XC
> >> block doesn't raise an exception, I know.
> >> Is it right shelving unsupported isolation level without an error?
> >
> >
> > It is due to already checked in code
> >
> > void
> > assign_XactIsoLevel(const char *newval, void *extra)
> > {
> >     XactIsoLevel = *((int *) extra);
> > #ifdef PGXC
> >     /*
> >      * PGXCTODO - PGXC does not support 9.1 serializable transactions yet
> >      */
> >     if (XactIsoLevel == XACT_SERIALIZABLE)
> >         XactIsoLevel = XACT_REPEATABLE_READ;
> > #endif
> > }
> >
> > I think we already have a source forge ticket to deal with this XC
> > limitation.
>
> Thanks.
> I know it caused by XC limitation.
>
> I thought that unsupported level should be denied by
> check_XactIsoLevel rather than modified at assign_XactIsoLevel.
> I shouldn't grumble reviewed commit. I'm sorry to be bothering you with
> this.
>
> Reading check_XactIsoLevel, I found XC doesn't support SERIALIZABLE
> but supports other levels.
> I think you could replace SERIALIZABLE to other transaction level
> (e.g. REPEATABLE READ) instead of skipping.
> It is more natural by the gist of the test case.
>
> >
> >
> >>
> >>
> >> On Fri, Aug 2, 2013 at 4:36 PM, Abbas Butt <abb...@en...
> >
> >> wrote:
> >> > Hi,
> >> > PFA patch to make sure that JDBC regression skips tests for
> serializable
> >> > transactions.
> >> >
> >> > --
> >> > Abbas
> >> > Architect
> >> >
> >> > Ph: 92.334.5100153
> >> > Skype ID: gabbasb
> >> > www.enterprisedb.com
> >> >
> >> > Follow us on Twitter
> >> > @EnterpriseDB
> >> >
> >> > Visit EnterpriseDB for tutorials, webinars, whitepapers and more
> >> >
> >> >
> >> >
> ------------------------------------------------------------------------------
> >> > Get your SQL database under version control now!
> >> > Version control is standard for application code, but databases havent
> >> > caught up. So what steps can you take to put your SQL databases under
> >> > version control? Why should you start doing it? Read more to find out.
> >> >
> >> >
> http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk
> >> > _______________________________________________
> >> > Postgres-xc-developers mailing list
> >> > Pos...@li...
> >> > https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
> >> >
> >
> >
> >
> >
> > --
> > --
> > Abbas
> > Architect
> >
> > Ph: 92.334.5100153
> > Skype ID: gabbasb
> > www.enterprisedb.com
> >
> > Follow us on Twitter
> > @EnterpriseDB
> >
> > Visit EnterpriseDB for tutorials, webinars, whitepapers and more
>



-- 
-- 
*Abbas*
 Architect

Ph: 92.334.5100153
 Skype ID: gabbasb
www.enterprisedb.co
<http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
*
Follow us on Twitter*
@EnterpriseDB

Visit EnterpriseDB for tutorials, webinars,
whitepapers<http://www.enterprisedb.com/resources-community>and
more<http://www.enterprisedb.com/resources-community>

Re: [Postgres-xc-developers] [JDBC Regression] Fix wrongly written boolean tests

[Abbas B. <abb...@en...>]

Please use this patch for review, attached the wrong patch file with the
previous mail.

On Mon, Aug 5, 2013 at 4:59 PM, Abbas Butt <abb...@en...>wrote:

> Attached please find a revised patch according to your suggestion.
> I am holding the rest of the patches till you review this one, because we
> need similar changes for integer, date, time and time-stamp tests.
>
>
> On Mon, Aug 5, 2013 at 12:45 PM, Masataka Saito <pg...@gm...> wrote:
>
>> Hi,
>>
>> I feel feckless for sorting assertins.
>>
>> I propose appending a serial column to test tables and SELECT rows
>> ORDERED BY it.
>> I think this idea makes costless and it doesn't against to the gist of
>> the test.
>>
>> Regards.
>>
>> On Fri, Aug 2, 2013 at 8:47 PM, Abbas Butt <abb...@en...>
>> wrote:
>> > Hi,
>> > PFA patch to fix wrongly written boolean tests, patch comments explain
>> the
>> > errors and the fix.
>> >
>> > --
>> > Abbas
>> > Architect
>> >
>> > Ph: 92.334.5100153
>> > Skype ID: gabbasb
>> > www.enterprisedb.com
>> >
>> > Follow us on Twitter
>> > @EnterpriseDB
>> >
>> > Visit EnterpriseDB for tutorials, webinars, whitepapers and more
>> >
>> >
>> ------------------------------------------------------------------------------
>> > Get your SQL database under version control now!
>> > Version control is standard for application code, but databases havent
>> > caught up. So what steps can you take to put your SQL databases under
>> > version control? Why should you start doing it? Read more to find out.
>> >
>> http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk
>> > _______________________________________________
>> > Postgres-xc-developers mailing list
>> > Pos...@li...
>> > https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>> >
>>
>
>
>
> --
> --
> *Abbas*
>  Architect
>
> Ph: 92.334.5100153
>  Skype ID: gabbasb
> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
> *
> Follow us on Twitter*
> @EnterpriseDB
>
> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>



-- 
-- 
*Abbas*
 Architect

Ph: 92.334.5100153
 Skype ID: gabbasb
www.enterprisedb.co
<http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
*
Follow us on Twitter*
@EnterpriseDB

Visit EnterpriseDB for tutorials, webinars,
whitepapers<http://www.enterprisedb.com/resources-community>and
more<http://www.enterprisedb.com/resources-community>

Re: [Postgres-xc-developers] [JDBC Regression] Fix wrongly written boolean tests

[Abbas B. <abb...@en...>]

Attached please find a revised patch according to your suggestion.
I am holding the rest of the patches till you review this one, because we
need similar changes for integer, date, time and time-stamp tests.

On Mon, Aug 5, 2013 at 12:45 PM, Masataka Saito <pg...@gm...> wrote:

> Hi,
>
> I feel feckless for sorting assertins.
>
> I propose appending a serial column to test tables and SELECT rows
> ORDERED BY it.
> I think this idea makes costless and it doesn't against to the gist of the
> test.
>
> Regards.
>
> On Fri, Aug 2, 2013 at 8:47 PM, Abbas Butt <abb...@en...>
> wrote:
> > Hi,
> > PFA patch to fix wrongly written boolean tests, patch comments explain
> the
> > errors and the fix.
> >
> > --
> > Abbas
> > Architect
> >
> > Ph: 92.334.5100153
> > Skype ID: gabbasb
> > www.enterprisedb.com
> >
> > Follow us on Twitter
> > @EnterpriseDB
> >
> > Visit EnterpriseDB for tutorials, webinars, whitepapers and more
> >
> >
> ------------------------------------------------------------------------------
> > Get your SQL database under version control now!
> > Version control is standard for application code, but databases havent
> > caught up. So what steps can you take to put your SQL databases under
> > version control? Why should you start doing it? Read more to find out.
> >
> http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk
> > _______________________________________________
> > Postgres-xc-developers mailing list
> > Pos...@li...
> > https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
> >
>



-- 
-- 
*Abbas*
 Architect

Ph: 92.334.5100153
 Skype ID: gabbasb
www.enterprisedb.co
<http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
*
Follow us on Twitter*
@EnterpriseDB

Visit EnterpriseDB for tutorials, webinars,
whitepapers<http://www.enterprisedb.com/resources-community>and
more<http://www.enterprisedb.com/resources-community>

Re: [Postgres-xc-developers] [JDBC Regression] Fix for XC does not support serializable transactions

[Masataka S. <pg...@gm...>]

On Mon, Aug 5, 2013 at 6:35 PM, Abbas Butt <abb...@en...> wrote:
>
>
> On Mon, Aug 5, 2013 at 2:18 PM, Masataka Saito <pg...@gm...> wrote:
>>
>> The patch will work fine.
>>
>> But this is my basal question:
>> setTransactionIsolation(Connection.TRANSACTION_SERIALIZABLE) after XC
>> block doesn't raise an exception, I know.
>> Is it right shelving unsupported isolation level without an error?
>
>
> It is due to already checked in code
>
> void
> assign_XactIsoLevel(const char *newval, void *extra)
> {
>     XactIsoLevel = *((int *) extra);
> #ifdef PGXC
>     /*
>      * PGXCTODO - PGXC does not support 9.1 serializable transactions yet
>      */
>     if (XactIsoLevel == XACT_SERIALIZABLE)
>         XactIsoLevel = XACT_REPEATABLE_READ;
> #endif
> }
>
> I think we already have a source forge ticket to deal with this XC
> limitation.

Thanks.
I know it caused by XC limitation.

I thought that unsupported level should be denied by
check_XactIsoLevel rather than modified at assign_XactIsoLevel.
I shouldn't grumble reviewed commit. I'm sorry to be bothering you with this.

Reading check_XactIsoLevel, I found XC doesn't support SERIALIZABLE
but supports other levels.
I think you could replace SERIALIZABLE to other transaction level
(e.g. REPEATABLE READ) instead of skipping.
It is more natural by the gist of the test case.

>
>
>>
>>
>> On Fri, Aug 2, 2013 at 4:36 PM, Abbas Butt <abb...@en...>
>> wrote:
>> > Hi,
>> > PFA patch to make sure that JDBC regression skips tests for serializable
>> > transactions.
>> >
>> > --
>> > Abbas
>> > Architect
>> >
>> > Ph: 92.334.5100153
>> > Skype ID: gabbasb
>> > www.enterprisedb.com
>> >
>> > Follow us on Twitter
>> > @EnterpriseDB
>> >
>> > Visit EnterpriseDB for tutorials, webinars, whitepapers and more
>> >
>> >
>> > ------------------------------------------------------------------------------
>> > Get your SQL database under version control now!
>> > Version control is standard for application code, but databases havent
>> > caught up. So what steps can you take to put your SQL databases under
>> > version control? Why should you start doing it? Read more to find out.
>> >
>> > http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk
>> > _______________________________________________
>> > Postgres-xc-developers mailing list
>> > Pos...@li...
>> > https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>> >
>
>
>
>
> --
> --
> Abbas
> Architect
>
> Ph: 92.334.5100153
> Skype ID: gabbasb
> www.enterprisedb.com
>
> Follow us on Twitter
> @EnterpriseDB
>
> Visit EnterpriseDB for tutorials, webinars, whitepapers and more

Re: [Postgres-xc-developers] [JDBC Regression] Fix for XC does not support serializable transactions

[Abbas B. <abb...@en...>]

On Mon, Aug 5, 2013 at 2:18 PM, Masataka Saito <pg...@gm...> wrote:

> The patch will work fine.
>
> But this is my basal question:
> setTransactionIsolation(Connection.TRANSACTION_SERIALIZABLE) after XC
> block doesn't raise an exception, I know.
> Is it right shelving unsupported isolation level without an error?
>

It is due to already checked in code

void
assign_XactIsoLevel(const char *newval, void *extra)
{
    XactIsoLevel = *((int *) extra);
#ifdef PGXC
    /*
     * PGXCTODO - PGXC does not support 9.1 serializable transactions yet
     */
    if (XactIsoLevel == XACT_SERIALIZABLE)
        XactIsoLevel = XACT_REPEATABLE_READ;
#endif
}

I think we already have a source forge ticket to deal with this XC
limitation.



>
> On Fri, Aug 2, 2013 at 4:36 PM, Abbas Butt <abb...@en...>
> wrote:
> > Hi,
> > PFA patch to make sure that JDBC regression skips tests for serializable
> > transactions.
> >
> > --
> > Abbas
> > Architect
> >
> > Ph: 92.334.5100153
> > Skype ID: gabbasb
> > www.enterprisedb.com
> >
> > Follow us on Twitter
> > @EnterpriseDB
> >
> > Visit EnterpriseDB for tutorials, webinars, whitepapers and more
> >
> >
> ------------------------------------------------------------------------------
> > Get your SQL database under version control now!
> > Version control is standard for application code, but databases havent
> > caught up. So what steps can you take to put your SQL databases under
> > version control? Why should you start doing it? Read more to find out.
> >
> http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk
> > _______________________________________________
> > Postgres-xc-developers mailing list
> > Pos...@li...
> > https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
> >
>



-- 
-- 
*Abbas*
 Architect

Ph: 92.334.5100153
 Skype ID: gabbasb
www.enterprisedb.co
<http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
*
Follow us on Twitter*
@EnterpriseDB

Visit EnterpriseDB for tutorials, webinars,
whitepapers<http://www.enterprisedb.com/resources-community>and
more<http://www.enterprisedb.com/resources-community>