postgres-xc-developers — Postgres-XC hackers and developers

[Postgres-xc-developers] Repeated rollback gets different error code from PostgreSQL

[Masataka S. <pg...@gm...>]

Hello, all.

I found Postgres-XC returns different error code from PostgreSQL's one
for repeated rollback, and it makes a pgjdbc's regression test case
fail.

PostgreSQL returns error code 42704 which is defined as
ERRCODE_UNDEFINED_OBJECT. It is maybe returned in
src/backend/access/transam/twophase.c::LockGXact.
Postgres-XC returns error code XX000 which is defined as
ERRCODE_INTERNAL_ERROR It is maybe returned in
src/backend/pgxc/pool/execRemote.c::FinishRemotePreparedTransaction.

Error messages are quite similar. I will show it at the next line.
> prepared transaction with identifier "0_8fHx8fF5/OCyZd9xZmJ2MSPCE1olci037CNQYoXoVCKbi63JcZIoUeJxU7PKl/t4qI4xV1agFPE+9gRrzheGHA==_BAUGAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA==" does not exist.

Does anyone know ...
 * Why they have different error codes, and is it reasonable?
 * To fix the code affects other components?

You can reproduce using pgjdbc's regression test. The source code of
the test is org.postgresql.test.xa.XADataSourceTest.testRepeatedRolledBack.
> http://sourceforge.net/p/postgres-xc/pgjdbc-xc/ci/master/tree/org/postgresql/test/xa/XADataSourceTest.java#l331

Regards.

Re: [Postgres-xc-developers] [master_pg93_merge] Patch # 4 Cannot convert int to define

[Ashutosh B. <ash...@en...>]

Looks ok to me.


On Wed, Oct 2, 2013 at 1:25 PM, Koichi Suzuki <koi...@gm...> wrote:

> Here's revised patch.  I think we can apply this both to our master and
> REL1_1_STABLE.  (We didn't apply this change to REL1_0_STABLE).
>
> Regards;
>
> ---
> Koichi Suzuki
>
>
> 2013/10/1 鈴木 幸市 <ko...@in...>
>
>>  Agree to remove #else .. .   Assert is defined under #ifdef
>> ASSERT_ENABLED internally and we don't have to worry about it.  Without
>> this symbol defined, Assert will be expanded to null and there's nothing
>> bothering.
>>
>>  Regards;
>> ---
>> Koichi Suzuki
>>
>>  On 2013/10/01, at 16:43, Ashutosh Bapat <ash...@en...<ashutosh..ba...@en...>>
>> wrote:
>>
>>  We should move the Assert under #ifdef ASSERT_ENABLED as well the
>> definition of old_outEnd. We should remove #else defining old_outEnd to
>> handle->outEnd which is utterly wrong.
>>
>>
>> On Mon, Sep 30, 2013 at 12:15 PM, Koichi Suzuki <koi...@gm...>wrote:
>>
>>> This change was made to eliminate a warning that old_outEnd is not used.
>>>   To improve both, the patch would be as attached.
>>>
>>>  Regards;
>>>
>>>  ---
>>> Koichi Suzuki
>>>
>>>
>>> 2013/9/30 Abbas Butt <abb...@en...>
>>>
>>>>  Hi,
>>>>
>>>> The commit ae29a966d3286d4e85b3adf162d00f9b1e8b8eae made this change
>>>> @@ -1132,7 +1132,11 @@ pgxc_node_send_parse(PGXCNodeHandle * handle,
>>>> const
>>>> char* statement,
>>>>         /* message length */
>>>>         int                     msgLen;
>>>>         int                     cnt_params;
>>>> +#if 0
>>>>         size_t          old_outEnd = handle->outEnd;
>>>> +#else
>>>> +#define old_outEnd handle->outEnd
>>>> +#endif
>>>>
>>>> which is incorrect. The purpose of the declaration and assignment is to
>>>> save the current value of handle->outEnd which is later changed in the
>>>> function.
>>>> This change makes the following assert in function pgxc_node_send_parse
>>>>     Assert(old_outEnd + ntohl(msgLen) + 1 == handle->outEnd);
>>>> fail when the query
>>>> CREATE TABLE junk AS VALUES (1), (2);
>>>> is run.
>>>>
>>>> This patch is required on master as well.
>>>>
>>>> Regards
>>>>
>>>> --
>>>> *Abbas*
>>>>  Architect
>>>>
>>>> Ph: 92.334.5100153
>>>>  Skype ID: gabbasb
>>>> www.enterprisedb.co
>>>> <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
>>>> *
>>>> Follow us on Twitter*
>>>> @EnterpriseDB
>>>>
>>>> Visit EnterpriseDB for tutorials, webinars,
>>>> whitepapers<http://www.enterprisedb.com/resources-community>and
>>>> more<http://www.enterprisedb.com/resources-community>
>>>>
>>>>
>>>> ------------------------------------------------------------------------------
>>>> October Webinars: Code for Performance
>>>> Free Intel webinars can help you accelerate application performance.
>>>> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the
>>>> most from
>>>> the latest Intel processors and coprocessors. See abstracts and
>>>> register >
>>>>
>>>> http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk
>>>> _______________________________________________
>>>> Postgres-xc-developers mailing list
>>>> Pos...@li...
>>>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>>>
>>>>
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> October Webinars: Code for Performance
>>> Free Intel webinars can help you accelerate application performance.
>>> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most
>>> from
>>> the latest Intel processors and coprocessors. See abstracts and register
>>> >
>>>
>>> http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk
>>> _______________________________________________
>>> Postgres-xc-developers mailing list
>>> Pos...@li...
>>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>>
>>>
>>
>>
>> --
>> Best Wishes,
>> Ashutosh Bapat
>> EnterpriseDB Corporation
>> The Postgres Database Company
>>
>> ------------------------------------------------------------------------------
>> October Webinars: Code for Performance
>> Free Intel webinars can help you accelerate application performance.
>> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most
>> from
>> the latest Intel processors and coprocessors. See abstracts and register >
>>
>> http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk_______________________________________________
>>
>> Postgres-xc-developers mailing list
>> Pos...@li...
>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>
>>
>>
>


-- 
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company

Re: [Postgres-xc-developers] Minor Fixes

[Matt W. <MW...@XI...>]

I've shared table definitions, query, plan, and even scrubbed data to Abbas and Michael.

From: Koichi Suzuki [mailto:koi...@gm...]
Sent: Wednesday, October 02, 2013 6:36 PM
To: Matt Warner
Cc: Michael Paquier; Postgres-XC Developers
Subject: Re: [Postgres-xc-developers] Minor Fixes

Thanks Matt and Michael.   Please keep sharing your work on Solaris and please share optimizer bug issue.   It will be nice to share table definition, query and the plan.

Best;
---
Koichi Suzuki

2013/10/3 Matt Warner <MW...@xi...<mailto:MW...@xi...>>
I'm compiling with the Solaris Studio compiler on Solaris Intel right now. If it compiles on Intel, it will compile on SPARC, the only exceptions being assembly code or code that has hard-coded dependencies on byte ordering (big- vs little-endian systems). I don't recall seeing any code like that in XC. That said, I have access to both Intel and SPARC Solaris, so I can perform builds and do some testing.

Solaris supports standard POSIX threads. I've been testing XC on Solaris and haven't seen issues around that, though I have seen what look like optimizer bugs (queries that don't complete when the amount of data changes as opposed to simply taking longer).

Matt

From: Koichi Suzuki [mailto:koi...@gm...<mailto:koi...@gm...>]
Sent: Wednesday, October 02, 2013 6:11 PM
To: Michael Paquier
Cc: Matt Warner; Postgres-XC Developers

Subject: Re: [Postgres-xc-developers] Minor Fixes

Thanks guys for your efforts to test XC on Solaris.   This is very valuable work.   If either of you can keep working with Solaris, we may be able to announce that XC supports Solaris.

Michael, I believe you're testing on Intel architecture.   Is either of you going to test XC against SPARC?

I'm not familiar with Solaris threading.   GTM and GTM_Proxy depend upon Posix thread and I hope it has no problem with Solaris.

Regards;
---
Koichi Suzuki

2013/10/3 Michael Paquier <mic...@gm...<mailto:mic...@gm...>>
On Thu, Oct 3, 2013 at 9:15 AM, Matt Warner <MW...@xi...<mailto:MW...@xi...>> wrote:
> I can spend some time cleaning up configure.in<http://configure.in> if it's not stepping on anyone's toes.
Feel free. I will try to work on your patch for GTM proxy first and do
smth for makesgml then.
--
Michael

------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk
_______________________________________________
Postgres-xc-developers mailing list
Pos...@li...<mailto:Pos...@li...>
https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers

Re: [Postgres-xc-developers] Minor Fixes

[Koichi S. <koi...@gm...>]

Thanks Matt and Michael.   Please keep sharing your work on Solaris and
please share optimizer bug issue.   It will be nice to share table
definition, query and the plan.

Best;
---
Koichi Suzuki


2013/10/3 Matt Warner <MW...@xi...>

> I’m compiling with the Solaris Studio compiler on Solaris Intel right now.
> If it compiles on Intel, it will compile on SPARC, the only exceptions
> being assembly code or code that has hard-coded dependencies on byte
> ordering (big- vs little-endian systems). I don’t recall seeing any code
> like that in XC. That said, I have access to both Intel and SPARC Solaris,
> so I can perform builds and do some testing.****
>
> ** **
>
> Solaris supports standard POSIX threads. I’ve been testing XC on Solaris
> and haven’t seen issues around that, though I have seen what look like
> optimizer bugs (queries that don’t complete when the amount of data changes
> as opposed to simply taking longer).****
>
> ** **
>
> Matt****
>
> ** **
>
> *From:* Koichi Suzuki [mailto:koi...@gm...]
> *Sent:* Wednesday, October 02, 2013 6:11 PM
> *To:* Michael Paquier
> *Cc:* Matt Warner; Postgres-XC Developers
>
> *Subject:* Re: [Postgres-xc-developers] Minor Fixes****
>
> ** **
>
> Thanks guys for your efforts to test XC on Solaris.   This is very
> valuable work.   If either of you can keep working with Solaris, we may be
> able to announce that XC supports Solaris.****
>
> ** **
>
> Michael, I believe you're testing on Intel architecture.   Is either of
> you going to test XC against SPARC?****
>
> ** **
>
> I'm not familiar with Solaris threading.   GTM and GTM_Proxy depend upon
> Posix thread and I hope it has no problem with Solaris.****
>
> ** **
>
> Regards;****
>
> ---****
>
> Koichi Suzuki****
>
> ** **
>
> 2013/10/3 Michael Paquier <mic...@gm...>****
>
> On Thu, Oct 3, 2013 at 9:15 AM, Matt Warner <MW...@xi...> wrote:
> > I can spend some time cleaning up configure.in if it's not stepping on
> anyone's toes.
> Feel free. I will try to work on your patch for GTM proxy first and do
> smth for makesgml then.****
>
> --
> Michael
>
>
> ------------------------------------------------------------------------------
> October Webinars: Code for Performance
> Free Intel webinars can help you accelerate application performance.
> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most
> from
> the latest Intel processors and coprocessors. See abstracts and register >
> http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers****
>
> ** **
>

Re: [Postgres-xc-developers] Minor Fixes

[Matt W. <MW...@XI...>]

I'm compiling with the Solaris Studio compiler on Solaris Intel right now. If it compiles on Intel, it will compile on SPARC, the only exceptions being assembly code or code that has hard-coded dependencies on byte ordering (big- vs little-endian systems). I don't recall seeing any code like that in XC. That said, I have access to both Intel and SPARC Solaris, so I can perform builds and do some testing.

Solaris supports standard POSIX threads. I've been testing XC on Solaris and haven't seen issues around that, though I have seen what look like optimizer bugs (queries that don't complete when the amount of data changes as opposed to simply taking longer).

Matt

From: Koichi Suzuki [mailto:koi...@gm...]
Sent: Wednesday, October 02, 2013 6:11 PM
To: Michael Paquier
Cc: Matt Warner; Postgres-XC Developers
Subject: Re: [Postgres-xc-developers] Minor Fixes

Thanks guys for your efforts to test XC on Solaris.   This is very valuable work.   If either of you can keep working with Solaris, we may be able to announce that XC supports Solaris.

Michael, I believe you're testing on Intel architecture.   Is either of you going to test XC against SPARC?

I'm not familiar with Solaris threading.   GTM and GTM_Proxy depend upon Posix thread and I hope it has no problem with Solaris.

Regards;
---
Koichi Suzuki

2013/10/3 Michael Paquier <mic...@gm...<mailto:mic...@gm...>>
On Thu, Oct 3, 2013 at 9:15 AM, Matt Warner <MW...@xi...<mailto:MW...@xi...>> wrote:
> I can spend some time cleaning up configure.in<http://configure.in> if it's not stepping on anyone's toes.
Feel free. I will try to work on your patch for GTM proxy first and do
smth for makesgml then.
--
Michael

------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk
_______________________________________________
Postgres-xc-developers mailing list
Pos...@li...<mailto:Pos...@li...>
https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers

Re: [Postgres-xc-developers] Minor Fixes

[Michael P. <mic...@gm...>]

On Thu, Oct 3, 2013 at 10:10 AM, Koichi Suzuki <koi...@gm...> wrote:
> Thanks guys for your efforts to test XC on Solaris.   This is very valuable
> work.   If either of you can keep working with Solaris, we may be able to
> announce that XC supports Solaris.
>
> Michael, I believe you're testing on Intel architecture.   Is either of you
> going to test XC against SPARC?
Nope, just got some Intel machines in my OSS lab.
-- 
Michael

Re: [Postgres-xc-developers] Minor Fixes

[Koichi S. <koi...@gm...>]

Thanks guys for your efforts to test XC on Solaris.   This is very valuable
work.   If either of you can keep working with Solaris, we may be able to
announce that XC supports Solaris.

Michael, I believe you're testing on Intel architecture.   Is either of you
going to test XC against SPARC?

I'm not familiar with Solaris threading.   GTM and GTM_Proxy depend upon
Posix thread and I hope it has no problem with Solaris.

Regards;
---
Koichi Suzuki


2013/10/3 Michael Paquier <mic...@gm...>

> On Thu, Oct 3, 2013 at 9:15 AM, Matt Warner <MW...@xi...> wrote:
> > I can spend some time cleaning up configure.in if it's not stepping on
> anyone's toes.
> Feel free. I will try to work on your patch for GTM proxy first and do
> smth for makesgml then.
> --
> Michael
>
>
> ------------------------------------------------------------------------------
> October Webinars: Code for Performance
> Free Intel webinars can help you accelerate application performance.
> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most
> from
> the latest Intel processors and coprocessors. See abstracts and register >
> http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>

Re: [Postgres-xc-developers] [master_pg93_merge] Patch # 4 Cannot convert int to define

[鈴木 幸市 <ko...@in...>]

Because this is not only for merge resolution.   The code was added before we cut 1_1_STABLE, which will cause assertion exception too.   This should be a part of release 1.1.1.

Regards;
---
Koichi Suzuki

On 2013/10/03, at 0:01, Ahsan Hadi <ahs...@en...<mailto:ahs...@en...>>
 wrote:




On Wed, Oct 2, 2013 at 12:55 PM, Koichi Suzuki <koi...@gm...<mailto:koi...@gm...>> wrote:
Here's revised patch.  I think we can apply this both to our master and REL1_1_STABLE.  (We didn't apply this change to REL1_0_STABLE).

Why do we need to apply this patch to 1_1 if the commit that is causing this is part of 9.3 merge?


Regards;

---
Koichi Suzuki


2013/10/1 鈴木 幸市 <ko...@in...<mailto:ko...@in...>>
Agree to remove #else .. .   Assert is defined under #ifdef ASSERT_ENABLED internally and we don't have to worry about it.  Without this symbol defined, Assert will be expanded to null and there's nothing bothering.

Regards;
---
Koichi Suzuki

On 2013/10/01, at 16:43, Ashutosh Bapat <ash...@en...<mailto:ashutosh..ba...@en...>> wrote:

We should move the Assert under #ifdef ASSERT_ENABLED as well the definition of old_outEnd. We should remove #else defining old_outEnd to handle->outEnd which is utterly wrong.


On Mon, Sep 30, 2013 at 12:15 PM, Koichi Suzuki <koi...@gm...<mailto:koi...@gm...>> wrote:
This change was made to eliminate a warning that old_outEnd is not used.   To improve both, the patch would be as attached.

Regards;

---
Koichi Suzuki


2013/9/30 Abbas Butt <abb...@en...<mailto:abb...@en...>>
Hi,

The commit ae29a966d3286d4e85b3adf162d00f9b1e8b8eae made this change
@@ -1132,7 +1132,11 @@ pgxc_node_send_parse(PGXCNodeHandle * handle, const
char* statement,
        /* message length */
        int                     msgLen;
        int                     cnt_params;
+#if 0
        size_t          old_outEnd = handle->outEnd;
+#else
+#define old_outEnd handle->outEnd
+#endif

which is incorrect. The purpose of the declaration and assignment is to
save the current value of handle->outEnd which is later changed in the
function.
This change makes the following assert in function pgxc_node_send_parse
    Assert(old_outEnd + ntohl(msgLen) + 1 == handle->outEnd);
fail when the query
CREATE TABLE junk AS VALUES (1), (2);
is run.

This patch is required on master as well.

Regards

--
*Abbas*
 Architect

Ph: 92.334.5100153<tel:92.334.5100153>
 Skype ID: gabbasb
www.enterprisedb.co<http://www.enterprisedb.co/>
<http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
*
Follow us on Twitter*
@EnterpriseDB

Visit EnterpriseDB for tutorials, webinars,
whitepapers<http://www.enterprisedb.com/resources-community>and
more<http://www.enterprisedb.com/resources-community>

------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk
_______________________________________________
Postgres-xc-developers mailing list
Pos...@li...<mailto:Pos...@li...>
https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers



------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk
_______________________________________________
Postgres-xc-developers mailing list
Pos...@li...<mailto:Pos...@li...>
https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers




--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company
------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk_______________________________________________

Postgres-xc-developers mailing list
Pos...@li...<mailto:Pos...@li...>
https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers



------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk
_______________________________________________
Postgres-xc-developers mailing list
Pos...@li...<mailto:Pos...@li...>
https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers




--
Ahsan Hadi
Snr Director Product Development
EnterpriseDB Corporation
The Enterprise Postgres Company

Phone: +92-51-8358874
Mobile: +92-333-5162114

Website: www.enterprisedb.com<http://www.enterprisedb.com/>
EnterpriseDB Blog: http://blogs.enterprisedb.com/
Follow us on Twitter: http://www.twitter.com/enterprisedb

This e-mail message (and any attachment) is intended for the use of the individual or entity to whom it is addressed. This message contains information from EnterpriseDB Corporation that may be privileged, confidential, or exempt from disclosure under applicable law. If you are not the intended recipient or authorized to receive this for the intended recipient, any use, dissemination, distribution, retention, archiving, or copying of this communication is strictly prohibited. If you have received this e-mail in error, please notify the sender immediately by reply e-mail and delete this message..
------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk_______________________________________________
Postgres-xc-developers mailing list
Pos...@li...
https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers

Re: [Postgres-xc-developers] Minor Fixes

[Michael P. <mic...@gm...>]

On Thu, Oct 3, 2013 at 9:15 AM, Matt Warner <MW...@xi...> wrote:
> I can spend some time cleaning up configure.in if it's not stepping on anyone's toes.
Feel free. I will try to work on your patch for GTM proxy first and do
smth for makesgml then.
-- 
Michael

Re: [Postgres-xc-developers] Minor Fixes

[Matt W. <MW...@XI...>]

I can spend some time cleaning up configure.in if it's not stepping on anyone's toes. 

> On Oct 2, 2013, at 5:07 PM, "Michael Paquier" <mic...@gm...> wrote:
> 
>> On Thu, Oct 3, 2013 at 9:04 AM, Matt Warner <MW...@xi...> wrote:
>> Just to follow up, the change to configure.in is trivial to include "__SOLARIS__", but it looks to me like in the master branch that someone else is already hacking the configure file and not updating configure.in.
>> 
>> Examples:
>> Someone has set CFLAGS="-DPGXC $CFLAGS" in configure but not in configure.in
>> PACKAGE_XC_VERSION, PGXC_MAJORVERSION, and PACKAGE_XC_VERSION are not defined in configure.in
>> PACKAGE_BUGREPORT is set to pgs...@po... in configure.in
>> 
>> Not trying to harp, just wondering how best to get this change incorporated?
> Woah, I completely forgot about that... All those changes should be
> incorporated in configure.in, definitely. That's one more thing to fix
> on top of makesgml.
> Regards,
> -- 
> Michael

Re: [Postgres-xc-developers] Minor Fixes

[Michael P. <mic...@gm...>]

On Thu, Oct 3, 2013 at 9:04 AM, Matt Warner <MW...@xi...> wrote:
> Just to follow up, the change to configure.in is trivial to include "__SOLARIS__", but it looks to me like in the master branch that someone else is already hacking the configure file and not updating configure.in.
>
> Examples:
> Someone has set CFLAGS="-DPGXC $CFLAGS" in configure but not in configure.in
> PACKAGE_XC_VERSION, PGXC_MAJORVERSION, and PACKAGE_XC_VERSION are not defined in configure.in
> PACKAGE_BUGREPORT is set to pgs...@po... in configure.in
>
> Not trying to harp, just wondering how best to get this change incorporated?
Woah, I completely forgot about that... All those changes should be
incorporated in configure.in, definitely. That's one more thing to fix
on top of makesgml.
Regards,
-- 
Michael

Re: [Postgres-xc-developers] Minor Fixes

[Matt W. <MW...@XI...>]

Just to follow up, the change to configure.in is trivial to include "__SOLARIS__", but it looks to me like in the master branch that someone else is already hacking the configure file and not updating configure.in.

Examples:
Someone has set CFLAGS="-DPGXC $CFLAGS" in configure but not in configure.in
PACKAGE_XC_VERSION, PGXC_MAJORVERSION, and PACKAGE_XC_VERSION are not defined in configure.in
PACKAGE_BUGREPORT is set to pgs...@po... in configure.in

Not trying to harp, just wondering how best to get this change incorporated.

?

Matt

-----Original Message-----
From: Matt Warner 
Sent: Wednesday, October 02, 2013 4:43 PM
To: 'Michael Paquier'
Cc: 鈴木 幸市; Postgres-XC Developers; Koichi Suzuki
Subject: RE: [Postgres-xc-developers] Minor Fixes

Hi,

First off, thank you for taking the time to review the patches!

Responses to the items you noted:

1. Solaris 10 is still a very active OS: Oracle shows it's end of support is not until January 2021. I think that means we should not necessarily expect everyone's build environment to be S11. If we can update maksgml to avoid strndup, then problem solved either way. Solaris has excellent backward binary compatibility, meaning what we compile on S9 or S10 will run on S11, but the reverse might or might not be true.

2. I actually did look at updating configure.in at one point in the past but when I ran autoconf, it produced a configure file that looked nothing like what was supplied with the version in the repository. I don't recall at this point which version I was looking at. I see from more recent builds that everything looks OK now, so I accept the -1 as my bad for not doing this the right way. I'm more than happy to update configure.in instead of configure. I can modify it to set something like "__SOLARIS_10__", although in your note 4 you indicated you didn't like the use of the CFLAG.

3. Glad to help!

4. I used the CFLAG because I was unsuccessful in writing a macro to do this. If you'd prefer a macro to the configure and CFLAG route, please let me know and I'll pursue it further. Otherwise, I'll plan to update configure.in

5. Thanks!

Matt

-----Original Message-----
From: Michael Paquier [mailto:mic...@gm...] 
Sent: Wednesday, October 02, 2013 6:45 AM
To: Matt Warner
Cc: 鈴木 幸市; Postgres-XC Developers; Koichi Suzuki
Subject: Re: [Postgres-xc-developers] Minor Fixes

Hi,

I have set up a Solaris 11 instance in my lab... So here is some
feedback about those patches:
1) makesgml patch: strndup is available in Solaris 11, not in Solaris
<= 10. IMO this patch is not necessary for 2 reasons:
- makesgml should not use strndup.
- Solaris 10 was out in 2005... That's getting old.
So we should patch makesgml and remove the calls to strndup inside it
instead of creating a fake version of it as you do.
2) configure patch. Not necessary, and -1 for adding a flag like that.
Isn't it possible to use something like __sparc__ or __SOLARIS__
instead? You need also to keep in mind that configure is generated
with autoconfigure, so you would actually need to patch configure.in.
3) Makefile patch, actually this is not only a bug of Solaris, so I
went ahead and committed it. That's a good catch.
4) pgxcnode patch. This is indeed necessary for the compilation on
Solaris, FIONREAD is declared in filio.h, but I don't like the use of
a CFLAGS as you did in configure.
5) GTM proxy patch. It looks like you spotted a couple of other bugs!
There is a strange mixture of things returned from functions where
they shouldn't, and this is not only a problem with Solaris. I'll
rework it a bit and commit it later after checking that it works in my
lab.

Thanks for the report and really sorry for the delay in responding!
Regards,
-- 
Michael

Re: [Postgres-xc-developers] Minor Fixes

[Matt W. <MW...@XI...>]

Hi,

First off, thank you for taking the time to review the patches!

Responses to the items you noted:

1. Solaris 10 is still a very active OS: Oracle shows it's end of support is not until January 2021. I think that means we should not necessarily expect everyone's build environment to be S11. If we can update maksgml to avoid strndup, then problem solved either way. Solaris has excellent backward binary compatibility, meaning what we compile on S9 or S10 will run on S11, but the reverse might or might not be true.

2. I actually did look at updating configure.in at one point in the past but when I ran autoconf, it produced a configure file that looked nothing like what was supplied with the version in the repository. I don't recall at this point which version I was looking at. I see from more recent builds that everything looks OK now, so I accept the -1 as my bad for not doing this the right way. I'm more than happy to update configure.in instead of configure. I can modify it to set something like "__SOLARIS_10__", although in your note 4 you indicated you didn't like the use of the CFLAG.

3. Glad to help!

4. I used the CFLAG because I was unsuccessful in writing a macro to do this. If you'd prefer a macro to the configure and CFLAG route, please let me know and I'll pursue it further. Otherwise, I'll plan to update configure.in

5. Thanks!

Matt

-----Original Message-----
From: Michael Paquier [mailto:mic...@gm...] 
Sent: Wednesday, October 02, 2013 6:45 AM
To: Matt Warner
Cc: 鈴木 幸市; Postgres-XC Developers; Koichi Suzuki
Subject: Re: [Postgres-xc-developers] Minor Fixes

Hi,

I have set up a Solaris 11 instance in my lab... So here is some
feedback about those patches:
1) makesgml patch: strndup is available in Solaris 11, not in Solaris
<= 10. IMO this patch is not necessary for 2 reasons:
- makesgml should not use strndup.
- Solaris 10 was out in 2005... That's getting old.
So we should patch makesgml and remove the calls to strndup inside it
instead of creating a fake version of it as you do.
2) configure patch. Not necessary, and -1 for adding a flag like that.
Isn't it possible to use something like __sparc__ or __SOLARIS__
instead? You need also to keep in mind that configure is generated
with autoconfigure, so you would actually need to patch configure.in.
3) Makefile patch, actually this is not only a bug of Solaris, so I
went ahead and committed it. That's a good catch.
4) pgxcnode patch. This is indeed necessary for the compilation on
Solaris, FIONREAD is declared in filio.h, but I don't like the use of
a CFLAGS as you did in configure.
5) GTM proxy patch. It looks like you spotted a couple of other bugs!
There is a strange mixture of things returned from functions where
they shouldn't, and this is not only a problem with Solaris. I'll
rework it a bit and commit it later after checking that it works in my
lab.

Thanks for the report and really sorry for the delay in responding!
Regards,
-- 
Michael

Re: [Postgres-xc-developers] [master_pg93_merge] Patch # 4 Cannot convert int to define

[Ahsan H. <ahs...@en...>]

On Wed, Oct 2, 2013 at 12:55 PM, Koichi Suzuki <koi...@gm...>wrote:

> Here's revised patch.  I think we can apply this both to our master and
> REL1_1_STABLE.  (We didn't apply this change to REL1_0_STABLE).
>

Why do we need to apply this patch to 1_1 if the commit that is causing
this is part of 9.3 merge?


>
> Regards;
>
> ---
> Koichi Suzuki
>
>
> 2013/10/1 鈴木 幸市 <ko...@in...>
>
>>  Agree to remove #else .. .   Assert is defined under #ifdef
>> ASSERT_ENABLED internally and we don't have to worry about it.  Without
>> this symbol defined, Assert will be expanded to null and there's nothing
>> bothering.
>>
>>  Regards;
>> ---
>> Koichi Suzuki
>>
>>  On 2013/10/01, at 16:43, Ashutosh Bapat <ash...@en...<ashutosh..ba...@en...>>
>> wrote:
>>
>>  We should move the Assert under #ifdef ASSERT_ENABLED as well the
>> definition of old_outEnd. We should remove #else defining old_outEnd to
>> handle->outEnd which is utterly wrong.
>>
>>
>> On Mon, Sep 30, 2013 at 12:15 PM, Koichi Suzuki <koi...@gm...>wrote:
>>
>>> This change was made to eliminate a warning that old_outEnd is not used.
>>>   To improve both, the patch would be as attached.
>>>
>>>  Regards;
>>>
>>>  ---
>>> Koichi Suzuki
>>>
>>>
>>> 2013/9/30 Abbas Butt <abb...@en...>
>>>
>>>>  Hi,
>>>>
>>>> The commit ae29a966d3286d4e85b3adf162d00f9b1e8b8eae made this change
>>>> @@ -1132,7 +1132,11 @@ pgxc_node_send_parse(PGXCNodeHandle * handle,
>>>> const
>>>> char* statement,
>>>>         /* message length */
>>>>         int                     msgLen;
>>>>         int                     cnt_params;
>>>> +#if 0
>>>>         size_t          old_outEnd = handle->outEnd;
>>>> +#else
>>>> +#define old_outEnd handle->outEnd
>>>> +#endif
>>>>
>>>> which is incorrect. The purpose of the declaration and assignment is to
>>>> save the current value of handle->outEnd which is later changed in the
>>>> function.
>>>> This change makes the following assert in function pgxc_node_send_parse
>>>>     Assert(old_outEnd + ntohl(msgLen) + 1 == handle->outEnd);
>>>> fail when the query
>>>> CREATE TABLE junk AS VALUES (1), (2);
>>>> is run.
>>>>
>>>> This patch is required on master as well.
>>>>
>>>> Regards
>>>>
>>>> --
>>>> *Abbas*
>>>>  Architect
>>>>
>>>> Ph: 92.334.5100153
>>>>  Skype ID: gabbasb
>>>> www.enterprisedb.co
>>>> <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
>>>> *
>>>> Follow us on Twitter*
>>>> @EnterpriseDB
>>>>
>>>> Visit EnterpriseDB for tutorials, webinars,
>>>> whitepapers<http://www.enterprisedb.com/resources-community>and
>>>> more<http://www.enterprisedb.com/resources-community>
>>>>
>>>>
>>>> ------------------------------------------------------------------------------
>>>> October Webinars: Code for Performance
>>>> Free Intel webinars can help you accelerate application performance.
>>>> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the
>>>> most from
>>>> the latest Intel processors and coprocessors. See abstracts and
>>>> register >
>>>>
>>>> http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk
>>>> _______________________________________________
>>>> Postgres-xc-developers mailing list
>>>> Pos...@li...
>>>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>>>
>>>>
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> October Webinars: Code for Performance
>>> Free Intel webinars can help you accelerate application performance.
>>> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most
>>> from
>>> the latest Intel processors and coprocessors. See abstracts and register
>>> >
>>>
>>> http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk
>>> _______________________________________________
>>> Postgres-xc-developers mailing list
>>> Pos...@li...
>>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>>
>>>
>>
>>
>> --
>> Best Wishes,
>> Ashutosh Bapat
>> EnterpriseDB Corporation
>> The Postgres Database Company
>>
>> ------------------------------------------------------------------------------
>> October Webinars: Code for Performance
>> Free Intel webinars can help you accelerate application performance.
>> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most
>> from
>> the latest Intel processors and coprocessors. See abstracts and register >
>>
>> http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk_______________________________________________
>>
>> Postgres-xc-developers mailing list
>> Pos...@li...
>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>
>>
>>
>
>
> ------------------------------------------------------------------------------
> October Webinars: Code for Performance
> Free Intel webinars can help you accelerate application performance.
> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most
> from
> the latest Intel processors and coprocessors. See abstracts and register >
> http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>
>


-- 
Ahsan Hadi
Snr Director Product Development
EnterpriseDB Corporation
The Enterprise Postgres Company

Phone: +92-51-8358874
Mobile: +92-333-5162114

Website: www.enterprisedb.com
EnterpriseDB Blog: http://blogs.enterprisedb.com/
Follow us on Twitter: http://www.twitter.com/enterprisedb

This e-mail message (and any attachment) is intended for the use of the
individual or entity to whom it is addressed. This message contains
information from EnterpriseDB Corporation that may be privileged,
confidential, or exempt from disclosure under applicable law. If you are
not the intended recipient or authorized to receive this for the intended
recipient, any use, dissemination, distribution, retention, archiving, or
copying of this communication is strictly prohibited. If you have received
this e-mail in error, please notify the sender immediately by reply e-mail
and delete this message.

Re: [Postgres-xc-developers] Minor Fixes

[Michael P. <mic...@gm...>]

Hi,

I have set up a Solaris 11 instance in my lab... So here is some
feedback about those patches:
1) makesgml patch: strndup is available in Solaris 11, not in Solaris
<= 10. IMO this patch is not necessary for 2 reasons:
- makesgml should not use strndup.
- Solaris 10 was out in 2005... That's getting old.
So we should patch makesgml and remove the calls to strndup inside it
instead of creating a fake version of it as you do.
2) configure patch. Not necessary, and -1 for adding a flag like that.
Isn't it possible to use something like __sparc__ or __SOLARIS__
instead? You need also to keep in mind that configure is generated
with autoconfigure, so you would actually need to patch configure.in.
3) Makefile patch, actually this is not only a bug of Solaris, so I
went ahead and committed it. That's a good catch.
4) pgxcnode patch. This is indeed necessary for the compilation on
Solaris, FIONREAD is declared in filio.h, but I don't like the use of
a CFLAGS as you did in configure.
5) GTM proxy patch. It looks like you spotted a couple of other bugs!
There is a strange mixture of things returned from functions where
they shouldn't, and this is not only a problem with Solaris. I'll
rework it a bit and commit it later after checking that it works in my
lab.

Thanks for the report and really sorry for the delay in responding!
Regards,
-- 
Michael

Re: [Postgres-xc-developers] Minor Fixes

[Michael P. <mic...@gm...>]

On Wed, Oct 2, 2013 at 3:45 PM, Koichi Suzuki <koi...@gm...> wrote:
> Okay, I will wait for your test result to commit it.
You shouldn't worry about that too...
-- 
Michael

Re: [Postgres-xc-developers] Minor Fixes

[Koichi S. <koi...@gm...>]

Okay, I will wait for your test result to commit it.

---
Koichi Suzuki


2013/10/2 Michael Paquier <mic...@gm...>

> On Wed, Oct 2, 2013 at 3:11 PM, Koichi Suzuki <koi...@gm...>
> wrote:
> > Are you testing them before committed or after then?
> >
> > BTW, koi...@gm... is obsolete (still alive though) and
> please
> > use koichi.dbms instead.
> I have always been told to test things before committing them, not after :)
> --
> Michael
>

Re: [Postgres-xc-developers] Minor Fixes

[Michael P. <mic...@gm...>]

On Wed, Oct 2, 2013 at 3:11 PM, Koichi Suzuki <koi...@gm...> wrote:
> Are you testing them before committed or after then?
>
> BTW, koi...@gm... is obsolete (still alive though) and please
> use koichi.dbms instead.
I have always been told to test things before committing them, not after :)
-- 
Michael

Re: [Postgres-xc-developers] Minor Fixes

[Koichi S. <koi...@gm...>]

Are you testing them before committed or after then?

BTW, koi...@gm... is obsolete (still alive though) and please
use koichi.dbms instead.

Regards;

---
Koichi Suzuki


2013/10/2 Michael Paquier <mic...@gm...>

> On Wed, Oct 2, 2013 at 10:33 AM, 鈴木 幸市 <ko...@in...> wrote:
> > All the patches looks reasonable and can be applied to REL1_1_STABLE, as
> well as master.
> >
> > Any more inputs?
> Yep, I'd like to actually test them on a Solaris VM.
> --
> Michael
>
>
> ------------------------------------------------------------------------------
> October Webinars: Code for Performance
> Free Intel webinars can help you accelerate application performance.
> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most
> from
> the latest Intel processors and coprocessors. See abstracts and register >
> http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>

Re: [Postgres-xc-developers] Minor Fixes

[Michael P. <mic...@gm...>]

On Wed, Oct 2, 2013 at 10:33 AM, 鈴木 幸市 <ko...@in...> wrote:
> All the patches looks reasonable and can be applied to REL1_1_STABLE, as well as master.
>
> Any more inputs?
Yep, I'd like to actually test them on a Solaris VM.
-- 
Michael

Re: [Postgres-xc-developers] Minor Fixes

[鈴木 幸市 <ko...@in...>]

All the patches looks reasonable and can be applied to REL1_1_STABLE, as well as master.

Any more inputs?
---
Koichi Suzuki

On 2013/10/02, at 8:58, Matt Warner <MW...@XI...>
 wrote:

> Attached.
> 
> Thanks!
> 
> Matt
> 
> -----Original Message-----
> From: Michael Paquier [mailto:mic...@gm...] 
> Sent: Tuesday, October 01, 2013 4:57 PM
> To: Matt Warner
> Cc: 鈴木 幸市; Postgres-XC Developers; Koichi Suzuki
> Subject: Re: [Postgres-xc-developers] Minor Fixes
> 
> On Wed, Oct 2, 2013 at 8:06 AM, Matt Warner <MW...@xi...> wrote:
>> I noticed that changes allowing XC to compile on Mac OS have been committed,
>> but it doesn’t appear that the patches I supplied for Solaris have made it
>> in.
>> 
>> Is there something I’ve omitted that would make those patches more
>> appealing?
> Sorry I couldn't find those patches in my archives :(. My fault...
> Could you send them on this thread? I promise I'll have a look at them
> even if I don't have a Solaris platform at my disposition yet. This
> gives a reason to have VM using it though.
> -- 
> Michael
> <solaris_makesgml-v1.patch><solaris_proxy_main-v2.patch><solaris_pgxcnode-v1.patch><solaris_sgml_Makefile-v1.patch><solaris_configure-v1.patch>

Re: [Postgres-xc-developers] Minor Fixes

[Matt W. <MW...@XI...>]

Attached.

Thanks!

Matt

-----Original Message-----
From: Michael Paquier [mailto:mic...@gm...] 
Sent: Tuesday, October 01, 2013 4:57 PM
To: Matt Warner
Cc: 鈴木 幸市; Postgres-XC Developers; Koichi Suzuki
Subject: Re: [Postgres-xc-developers] Minor Fixes

On Wed, Oct 2, 2013 at 8:06 AM, Matt Warner <MW...@xi...> wrote:
> I noticed that changes allowing XC to compile on Mac OS have been committed,
> but it doesn’t appear that the patches I supplied for Solaris have made it
> in.
>
> Is there something I’ve omitted that would make those patches more
> appealing?
Sorry I couldn't find those patches in my archives :(. My fault...
Could you send them on this thread? I promise I'll have a look at them
even if I don't have a Solaris platform at my disposition yet. This
gives a reason to have VM using it though.
-- 
Michael

Re: [Postgres-xc-developers] Minor Fixes

[Michael P. <mic...@gm...>]

On Wed, Oct 2, 2013 at 8:06 AM, Matt Warner <MW...@xi...> wrote:
> I noticed that changes allowing XC to compile on Mac OS have been committed,
> but it doesn’t appear that the patches I supplied for Solaris have made it
> in.
>
> Is there something I’ve omitted that would make those patches more
> appealing?
Sorry I couldn't find those patches in my archives :(. My fault...
Could you send them on this thread? I promise I'll have a look at them
even if I don't have a Solaris platform at my disposition yet. This
gives a reason to have VM using it though.
-- 
Michael

Re: [Postgres-xc-developers] Minor Fixes

[Matt W. <MW...@XI...>]

I noticed that changes allowing XC to compile on Mac OS have been committed, but it doesn’t appear that the patches I supplied for Solaris have made it in.

Is there something I’ve omitted that would make those patches more appealing?

Thanks!

Matt

From: Michael Paquier [mailto:mic...@gm...]
Sent: Monday, August 05, 2013 6:25 AM
To: 鈴木 幸市
Cc: Matt Warner; Postgres-XC Developers; Koichi Suzuki
Subject: Re: [Postgres-xc-developers] Minor Fixes



On Mon, Aug 5, 2013 at 10:09 PM, 鈴木 幸市 <ko...@in...<mailto:ko...@in...>> wrote:
This depends on how serious the demand/usecase is and how works on it.  Yes, you can work on it and you must have demanding usecase.

I mean when 1.1GA is out, it's safer to concentrate on the master.   This is a better place to work for Solaris.
As 1.1 stable branch and master are already separated, what is the point of not committing what Matt has sent before it is forgotten? It is perfectly possible to continue the development work on master while improving the 1.1 beta state. IMO, I think that we should look at what Matt could send.
--
Michael

Re: [Postgres-xc-developers] [master_pg93_merge] Patch # 4 Cannot convert int to define

[鈴木 幸市 <ko...@in...>]

Agree to remove #else .. .   Assert is defined under #ifdef ASSERT_ENABLED internally and we don't have to worry about it.  Without this symbol defined, Assert will be expanded to null and there's nothing bothering.

Regards;
---
Koichi Suzuki

On 2013/10/01, at 16:43, Ashutosh Bapat <ash...@en...<mailto:ash...@en...>> wrote:

We should move the Assert under #ifdef ASSERT_ENABLED as well the definition of old_outEnd. We should remove #else defining old_outEnd to handle->outEnd which is utterly wrong.


On Mon, Sep 30, 2013 at 12:15 PM, Koichi Suzuki <koi...@gm...<mailto:koi...@gm...>> wrote:
This change was made to eliminate a warning that old_outEnd is not used.   To improve both, the patch would be as attached.

Regards;

---
Koichi Suzuki


2013/9/30 Abbas Butt <abb...@en...<mailto:abb...@en...>>
Hi,

The commit ae29a966d3286d4e85b3adf162d00f9b1e8b8eae made this change
@@ -1132,7 +1132,11 @@ pgxc_node_send_parse(PGXCNodeHandle * handle, const
char* statement,
        /* message length */
        int                     msgLen;
        int                     cnt_params;
+#if 0
        size_t          old_outEnd = handle->outEnd;
+#else
+#define old_outEnd handle->outEnd
+#endif

which is incorrect. The purpose of the declaration and assignment is to
save the current value of handle->outEnd which is later changed in the
function.
This change makes the following assert in function pgxc_node_send_parse
    Assert(old_outEnd + ntohl(msgLen) + 1 == handle->outEnd);
fail when the query
CREATE TABLE junk AS VALUES (1), (2);
is run.

This patch is required on master as well.

Regards

--
*Abbas*
 Architect

Ph: 92.334.5100153
 Skype ID: gabbasb
www.enterprisedb.co<http://www.enterprisedb.co/>
<http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
*
Follow us on Twitter*
@EnterpriseDB

Visit EnterpriseDB for tutorials, webinars,
whitepapers<http://www.enterprisedb.com/resources-community>and
more<http://www.enterprisedb.com/resources-community>

------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk
_______________________________________________
Postgres-xc-developers mailing list
Pos...@li...<mailto:Pos...@li...>
https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers



------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk
_______________________________________________
Postgres-xc-developers mailing list
Pos...@li...<mailto:Pos...@li...>
https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers




--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company
------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk_______________________________________________
Postgres-xc-developers mailing list
Pos...@li...
https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers