Re: [Postgres-xc-developers] Not just type error?

[Koichi S. <koi...@gm...>]

Thanks Michael.   It was what I was considering.   I agree that we
shouldn't get upstream patches before we merge them into XC.

Appreciate for your comment.
---
Koichi Suzuki


2014-12-24 8:38 GMT+09:00 Michael Paquier <mic...@gm...>:
> On Tue, Dec 23, 2014 at 1:57 PM, Jaimin Pan <jai...@gm...> wrote:
>> I check the PG repo master branch(latest commit in my view
>> d69ffd6f035fe24483247bf9b2335d7474eaf31a).
>> And there is no such error, seem no modified ever.
> I disagree, per se this commit in Postgres:
> commit: 5242fefb471d1fb2d0f35a33bde3570e19acd4b1
> author: Tom Lane <tg...@ss...>
> date: Sat, 15 Jun 2013 14:11:43 -0400
> Be consistent about #define'ing configure symbols as "1" not empty.
>
> This is just neatnik-ism, since all the tests in the code are #ifdefs,
> but we shouldn't specify symbols as "Define to 1 ..." and then not
> actually define them that way.
>
> The usual policy here is not to fix problems with upstream directly,
> but to get them merged from upstream. Hence I don't think your patch
> should be merged, but we should re-sync with Postgres itself.
> --
> Michael