Re: [Postgres-xc-bugs] Is the function correct? -- GTM_WriteRestorePointXid

[鈴木 幸市 <ko...@in...>]

Ouch!

Yes, you’re right.   This needs immediate correction.   I will submit a patch to correct this and commit it.

Thank you very much for pointing out!
---
Koichi Suzuki

2014/11/14 16:02、ZhangJulian <jul...@ou...<mailto:jul...@ou...>> のメール：

void GTM_WriteRestorePointXid(FILE *f)
{
    if ((MaxGlobalTransactionId - GTMTransactions.gt_nextXid) <= RestoreDuration)
        GTMTransactions.gt_backedUpXid = GTMTransactions.gt_nextXid + RestoreDuration;
    else
        GTMTransactions.gt_backedUpXid = FirstNormalGlobalTransactionId + (RestoreDuration - (MaxGlobalTransactionId - GTMTransactions.gt_nextXid));

    elog(LOG, "Saving transaction restoration info, backed-up gxid: %u", GTMTransactions.gt_backedUpXid);
    fprintf(f, "%u\n", GTMTransactions.gt_backedUpXid);
}

It seems the operator "<=" in the "if" clause should be ">=", right?
------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications.
Take corrective actions from your mobile device.
http://pubads.g.doubleclick.net/gampad/clk?id=154624111&iu=/4140/ostg.clktrk_______________________________________________
Postgres-xc-bugs mailing list
Pos...@li...
https://lists.sourceforge.net/lists/listinfo/postgres-xc-bugs