Re: [Postgres-xc-developers] fix a memory leak in PoolManagerDisconnect()

[Masataka S. <pg...@gm...>]

On 24 April 2014 11:04, 鈴木 幸市 <ko...@in...> wrote:
> Thanks a lot Wang;
>
> The first patch may not be effective because handle does not propagate to caller.
>

The variable handle does not propagate to caller.
Therefore, the first hunk is reasonable.

Regards.

> The second one looks reasonable.
>
> Regards;
> ---
> Koichi Suzuki
>
> 2014/04/23 22:13、Wang Diancheng <dia...@gm...> のメール：
>
>> Hi,
>>
>> patch attached.
>>
>> diff --git a/src/backend/pgxc/pool/poolmgr.c b/src/backend/pgxc/pool/poolmgr.c
>> index 02ed656..432fb85 100644
>> --- a/src/backend/pgxc/pool/poolmgr.c
>> +++ b/src/backend/pgxc/pool/poolmgr.c
>> @@ -389,7 +389,6 @@ PoolManagerCloseHandle(PoolHandle *handle)
>> {
>>       close(Socket(handle->port));
>>       free(handle);
>> -     handle = NULL;
>> }
>>
>>
>> @@ -818,7 +817,7 @@ PoolManagerDisconnect(void)
>>       pool_putmessage(&poolHandle->port, 'd', NULL, 0);
>>       pool_flush(&poolHandle->port);
>>
>> -     close(Socket(poolHandle->port));
>> +     PoolManagerCloseHandle(poolHandle);
>>       poolHandle = NULL;
>> }
>>
>> ------------------------------------------------------------------------------
>> Start Your Social Network Today - Download eXo Platform
>> Build your Enterprise Intranet with eXo Platform Software
>> Java Based Open Source Intranet - Social, Extensible, Cloud Ready
>> Get Started Now And Turn Your Intranet Into A Collaboration Platform
>> http://p.sf.net/sfu/ExoPlatform_______________________________________________
>> Postgres-xc-developers mailing list
>> Pos...@li...
>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>
> ------------------------------------------------------------------------------
> Start Your Social Network Today - Download eXo Platform
> Build your Enterprise Intranet with eXo Platform Software
> Java Based Open Source Intranet - Social, Extensible, Cloud Ready
> Get Started Now And Turn Your Intranet Into A Collaboration Platform
> http://p.sf.net/sfu/ExoPlatform
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers