Re: [Postgres-xc-developers] Fwd: [Postgres-xc-committers] Postgres-XC branch, REL1_2_STABLE, updated. XC1_0_BETA1_PG9_1-3999-ge5466f7

[Ashutosh B. <ash...@en...>]

On Sat, Mar 8, 2014 at 7:52 PM, Abbas Butt <abb...@en...>wrote:

> Hi,
> Attached please find patch to add a GUC called require_replicated_table_pkey
> which is true by default.
> The purpose of the GUC is to error out for non-FQS UPDATE / DELETE to a
> replicated table.
>

Here is another reason why we shouldn't add requirement for primary key in
replicated tables. Thanks Abbas for pointing it out.

If the UPDATE/DELETE statement gets FQSed, we don't need a primary key for
replicated table and if it doesn't, then we need a primary key. It will be
difficult to explain users why some DMLs on replicated tables error out and
why some of them don't. Again we come back to the backward compatibility.
Before anyone suggests, disabling FQS for replicated tables, is not a
solution here. It will affect performance badly.


> By setting the GUC to false the error can be by passed and this is done to
> run regression tests.
> make check runs fine after the patch.
> Test cases are added to check the added functionality.
> Best Regards
>
>
>
> On Thu, Mar 6, 2014 at 9:00 AM, Pavan Deolasee <pav...@gm...>wrote:
>
>>
>>
>> On 06-Mar-2014, at 7:57 am, Abbas Butt <abb...@en...>
>> wrote:
>>
>>
>>
>>
>> On Wed, Mar 5, 2014 at 10:18 PM, Pavan Deolasee <pav...@gm...
>> > wrote:
>>
>>> On Wed, Mar 5, 2014 at 2:32 PM, Koichi Suzuki <koi...@gm...>wrote:
>>>
>>>> I'd like Abbas to answer why it is practical at this point ...
>>>>
>>>>
>>> Sure. I would wait for him to explain.
>>>
>>
>> It was done as a quick fix for backward compatibility,
>>
>>
>> IMHO it's a bug that needs to be fixed and not a compatibility that needs
>> to be backward supported. Let's just throw an error for now until we have
>> time and resources to fix the bug.
>>
>> Thanks,
>> Pavan
>>
>>
>
>
> --
> --
> *Abbas*
>  Architect
>
> Ph: 92.334.5100153
>  Skype ID: gabbasb
> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
>
> *Follow us on Twitter*
> @EnterpriseDB
>
> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>
>
> ------------------------------------------------------------------------------
> Subversion Kills Productivity. Get off Subversion & Make the Move to
> Perforce.
> With Perforce, you get hassle-free workflows. Merge that actually works.
> Faster operations. Version large binaries.  Built-in WAN optimization and
> the
> freedom to use Git, Perforce or both. Make the move to Perforce.
>
> http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>
>


-- 
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company