Re: [Postgres-xc-developers] Fixing pgbench bug

[坂田 哲夫 <sak...@la...>]

Suzuki-san,

Sorry for the delay, and thank you for your comments.

I've made the patch I sent before for the XC 1.1.0 not REL_1_1_STABLE.
So I recreated a patch for REL_1_1_STABLE.

Please check the attached patch.

Thanks in advance,

Tetsuo Sakata.




(2014/03/05 17:36), Koichi Suzuki wrote:
> Sakata-san;
> 
> I've tested the patch and found it does not apply to current
> master/REL1_2_STABLE branch.   I also tested against REL1_1_STABLE and
> the result was the same.   Could you check your patch against the
> current repo?
> 
> I wonder why it happens because pgbench is very stable.    Maybe it
> needs some tweak to deal with the current PG repo as well.
> 
> Could you also consider to use the format you get with "git diff"?
> 
> Thank you very much in advance.
> ---
> Koichi Suzuki
> 
> 
> 2014-03-05 15:23 GMT+09:00 坂田　哲夫 <sak...@la...>:
>> Hi, folks,
>>
>> I found a pgbench bug that pgbench fails to update tables such as
>> pgbench_accounts and pgbench_tellers.
>>
>> For example, original pgbench for XC tries to update pgbench_accounts'
>> specifying aid and bid values which are selected independently.
>> By the pgbench's nature, bid should have a particular value for a
>> given aid value. So the update statement fails picking up target
>> tuple and updating the table in most cases.
>>
>> The attached patch, which should be applied to XC 1.1s
>> pgbench, eliminates wrongly added bid specifications
>> and corrects index and distribute settings related.
>>
>> Best regards,
>>
>> Tetsuo Sakata.
>>
>> --
>> sakata.tetsuo _at_ lab.ntt.co.jp
>> SAKATA, Tetsuo. Shinagawa Tokyo JAPAN.
>>
>> ------------------------------------------------------------------------------
>> Subversion Kills Productivity. Get off Subversion & Make the Move to Perforce.
>> With Perforce, you get hassle-free workflows. Merge that actually works.
>> Faster operations. Version large binaries.  Built-in WAN optimization and the
>> freedom to use Git, Perforce or both. Make the move to Perforce.
>> http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk
>> _______________________________________________
>> Postgres-xc-developers mailing list
>> Pos...@li...
>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>
> 
> ------------------------------------------------------------------------------
> Subversion Kills Productivity. Get off Subversion & Make the Move to Perforce.
> With Perforce, you get hassle-free workflows. Merge that actually works.
> Faster operations. Version large binaries.  Built-in WAN optimization and the
> freedom to use Git, Perforce or both. Make the move to Perforce.
> http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
> 


-- 
sakata.tetsuo _at_ lab.ntt.co.jp
SAKATA, Tetsuo. Shinagawa Tokyo JAPAN.