Re: [Postgres-xc-bugs] A bug and related fix: Dead lock when testing TPCC on PGXC by HammerDB

[Koichi S. <koi...@gm...>]

Here's the patch.   It passes regressions.   BTW, I'm afraid we may
need similar fix to other part of gtm-related code.   At present, GTM
requires backend's GXID to obtain a snapshot, which may not be needed,
especially for read-only TXNs.

In the next chance of code clean-up, we might better consider to
remove this requirement, or allow invalid gxid (zero value) to
eliminate this case and to save GXID value.  This is a better fix for
the issue.

Other thoughts?

Regards;
---
Koichi Suzuki


2014/1/10 ZhangJulian <jul...@ou...>:
> Hi Mason,
>
>
>
> I am very glad to know the fix could pass your review. I will continue
> focusing and working on the amazing product.
>
> It is the first time I wrote the mail to the mail group, next time, I will
> append the regression test result and the patch as the attachments.  :)
>
>
>
> Thanks
>
>
> ________________________________
> Date: Thu, 9 Jan 2014 09:49:22 -0500
> Subject: Re: [Postgres-xc-bugs] A bug and related fix: Dead lock when
> testing TPCC on PGXC by HammerDB
> From: ms...@tr...
> To: jul...@ou...
> CC: mic...@gm...; ash...@en...;
> pos...@li...
>
>
>
> On Thu, Jan 9, 2014 at 12:27 AM, Ashutosh Bapat
> <ash...@en...> wrote:
>
> A patch is a patch! You can not expect people to pull code out of email and
> try it out.
>
> Also, we need regression results with the patch, which are absent in the
> mail.
>
>
>
> Julian, please do not be discouraged. I appreciate you taking the time to
> participate in the list and send along a patch, and I hope that you continue
> to do so in order for us to grow the Postgres-XC community.
>
> To make it a little easier for everyone, in the future please include the
> patch as an attachment if you can.
>
> Thanks much,
>
>
> --
> Mason Sharp
>
> TransLattice - http://www.translattice.com
> Distributed and Clustered Database Solutions
>
>
>
> ------------------------------------------------------------------------------
> CenturyLink Cloud: The Leader in Enterprise Cloud Services.
> Learn Why More Businesses Are Choosing CenturyLink Cloud For
> Critical Workloads, Development Environments & Everything In Between.
> Get a Quote or Start a Free Trial Today.
> http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
> _______________________________________________
> Postgres-xc-bugs mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-bugs
>