Re: [Postgres-xc-bugs] A bug and related fix: Dead lock when testing TPCC on PGXC by HammerDB

[Koichi S. <koi...@gm...>]

I understand that PG may need this additional call to make request to
GTM.   GTM requires calling backend's transaction ID.

If I'm right, then the patch should go to all the releases.   As much
as I tested with REL1_0_STABLE and REL1_1_STABLE, it does not affect
any of the regression tests.   Also this looks good to go to the
master and REL1_2_STABLE, which is under preparation.

Any more inputs?
---
Koichi Suzuki


2014/1/9 Koichi Suzuki <koi...@gm...>:
> I understand this.   If the code is specific to XC, we should enclose
> the additional line with #ifdef PGXC --- #endif.
>
> Regards;
> ---
> Koichi Suzuki
>
>
> 2014/1/9 Michael Paquier <mic...@gm...>:
>> On Thu, Jan 9, 2014 at 2:33 PM, Koichi Suzuki <koi...@gm...> wrote:
>>> Thanks a lot for the analysis and the patch.
>>>
>>> The patch is not for XC-specific code.   Do you think the patch should
>>> go to PG as well?
>> No. The code path taken in the first section is exclusive to XC: it
>> uses an internal 2PC. IMO the patch is fine as I recall (some
>> souvenir, feel free to correct me) that in this code path a
>> transaction ID is already assigned, so GetTopTransactionId is not
>> going to call GTM.
>> Regards,
>> --
>> Michael