|
From: Koichi S. <koi...@gm...> - 2014-01-09 06:04:07
|
I understand this. If the code is specific to XC, we should enclose the additional line with #ifdef PGXC --- #endif. Regards; --- Koichi Suzuki 2014/1/9 Michael Paquier <mic...@gm...>: > On Thu, Jan 9, 2014 at 2:33 PM, Koichi Suzuki <koi...@gm...> wrote: >> Thanks a lot for the analysis and the patch. >> >> The patch is not for XC-specific code. Do you think the patch should >> go to PG as well? > No. The code path taken in the first section is exclusive to XC: it > uses an internal 2PC. IMO the patch is fine as I recall (some > souvenir, feel free to correct me) that in this code path a > transaction ID is already assigned, so GetTopTransactionId is not > going to call GTM. > Regards, > -- > Michael |