Re: [Postgres-xc-bugs] Postgres-xc 1.1 does not build with clang and libc++

[DIMI <nic...@un...>]

I confirm that Nikhil’s suggestion works without patching!

Nicola

On 31/ott/2013, at 16:30, Koichi Suzuki <koi...@gm...> wrote:

> Thanks Nikhil.  We may need a way to set it up automatically via ./configure.
> 
> Nicola, could you test this?    This CFLAGS setting may disable -O2 optimization so it would be better to add this.
> 
> Regards;
> 
> ---
> Koichi Suzuki
> 
> 
> 2013/10/31 Nikhil Sontakke <ni...@st...>
> Hi Nicola, Suzuki-san, 
> 
> IMO, no patch is needed for XC compilation on latest OS X. 
> 
> Please append this to the CFLAGS: "-D_FORTIFY_SOURCE=0" and it should compile ok on Maverick.
> 
> ./configure CFLAGS="-D_FORTIFY_SOURCE=0"
> 
> Did work for me.
> 
> Regards,
> Nikhils
> 
> 
> 
> On Thu, Oct 31, 2013 at 11:42 AM, DIMI <nic...@un...> wrote:
> Please find enclosed the output of ./configure. I don’t see anything apparently wrong.
> 
> I’d be happy to contribute supporting XC on OS X, although I don’t have much familiarity with the code. Should I subscribe to some developer mailing list?
> 
> Nicola
> 
> 
> 
> 
> On 31/ott/2013, at 03:08, Koichi Suzuki <koi...@gm...> wrote:
> 
>> I'm interested if ./configure is successful.
>> 
>> Maybe the patch Michael suggested may not be sufficient.    I suspect there's another problem in ./configure.   If you allow me some time (maybe some time next week) until I upgrade my Macs to Marberics, I can reproduce the problem.
>> 
>> Please understand that XC has not announced OS X support so far because we don't have sufficient resource.   It will be nice if you help to support XC on OS X, or any other platforms other than Intel Linux.
>> 
>> Regards;
>> 
>> ---
>> Koichi Suzuki
>> 
>> 
>> 2013/10/30 DIMI <nic...@un...>
>> Thanks, the patch can now be applied. But, it doesn’t fix the problem: I still get the same build errors.
>> 
>> Nicola
>> 
>> On 30/ott/2013, at 09:58, Koichi Suzuki <koi...@gm...> wrote:
>> 
>>> Because the patch is for vanilla PG.   Sometimes we have patch conflict.   Here's a hack of the patch.   Because the nature of the patch does not have any bad influence, I hope you can try this.   Please let me know how it works.
>>> 
>>> # Please understand that this is really a quick hack and I'm not tracking this patch in a good manner.
>>> 
>>> Good Luck;
>>> 
>>> ---
>>> Koichi Suzuki
>>> 
>>> 
>>> 2013/10/30 DIMI <nic...@un...>
>>> On 30/ott/2013, at 08:51, Michael Paquier <mic...@gm...> wrote:
>>> 
>>> > There have been fixes these days in Postgres core for Mavericks for strlcpy:
>>> > http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=a1f86e70c8d9a152eaa50cc17e5249da10d3e758ì
>>> 
>>> I cannot apply that patch to Postgres-XC 1.1. And after making the change manually, I still get the same build errors. Am I missing something?
>>> 
>>> Nicola
>>> 
>>> 
>>> <tupdesc.c.patch>
>> 
>> 
> 
> 
> ------------------------------------------------------------------------------
> Android is increasing in popularity, but the open development platform that
> developers love is also attractive to malware creators. Download this white
> paper to learn more about secure code signing practices that can help keep
> Android apps secure.
> http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk
> _______________________________________________
> Postgres-xc-bugs mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-bugs
> 
> 
> 
> 
> -- 
> StormDB - http://www.stormdb.com
> The Database Cloud
>