Re: [Postgres-xc-developers] Minor Fixes

[Matt W. <MW...@xi...>]

Good morning. I didn't see any responses to this.

I know everyone is busy. Were the changes acceptable?

Matt

-----Original Message-----
From: Matt Warner [mailto:MW...@XI...] 
Sent: Wednesday, October 09, 2013 4:29 PM
To: 'Michael Paquier'
Cc: Postgres-XC Developers; Suzuki; Koichi
Subject: Re: [Postgres-xc-developers] Minor Fixes

Below is a summary of the changes made against git pull from this morning.

I don't claim to be the best resource for this, so please do take the time to verify what I've sent. I also welcome comments and suggestions.

Please note that the entire config directory was replaced with the one from Postgres 9.3.0.

Likewise, I used configure.in from Postgres 9.3.0 as the starting point for the updates. autoconf successfully creates the configure file, which is also attached. I've tried to capture all the XC pieces that had been added manually to the previous configure file, but the new configure file should be checked and verified.

In particular, I moved the '-DPGXC' from configure to pgxc_config.h and updated postgres.h to include this new header.

The changes all compile successfully under Solaris 10 using the Solaris Studio compiler. Being that the Solaris compiler seems to be more demanding than gcc about syntax and "correctness", I believe this is a good sign. I also ran this with test data and saw no issues.

FYI,

Matt

% git status
# On branch master
# Changes to be committed:
#   (use "git reset HEAD <file>..." to unstage)
#
#	new file:   src/include/pgxc_config.h
#	new file:   src/include/pgxc_config.h.in
#	new file:   src/include/stamp-ext-h
#
# Changes not staged for commit:
#   (use "git add <file>..." to update what will be committed)
#   (use "git checkout -- <file>..." to discard changes in working directory)
#
#	modified:   config/c-compiler.m4
#	modified:   config/config.guess
#	modified:   config/config.sub
#	modified:   config/install-sh
#	modified:   config/perl.m4
#	modified:   config/programs.m4
#	modified:   config/python.m4
#	modified:   configure
#	modified:   configure.in
#	modified:   src/backend/pgxc/pool/pgxcnode.c
#	modified:   src/include/postgres.h
#

-----Original Message-----
From: Michael Paquier [mailto:mic...@gm...] 
Sent: Tuesday, October 08, 2013 5:43 PM
To: Matt Warner
Cc: 鈴木 幸市; Postgres-XC Developers; Koichi Suzuki
Subject: Re: [Postgres-xc-developers] Minor Fixes

On Wed, Oct 9, 2013 at 9:13 AM, Matt Warner <MW...@xi...> wrote:
> So I owe you a different patch for proxy_main.c as well.
Btw, I can see why it is needed for pgxcnode.h as we use FIONREAD
there, but why is it necessary to have an include to filio.h in
proxy_main.c? I couldn't figure out why so I simply removed that from
the patch committed.
-- 
Michael