Re: [Postgres-xc-developers] [master_pg93_merge] Patch # 3 for CLEAN CONNECTION

[Koichi S. <koi...@gm...>]

(Please take a look at WIP branch master_pg93_merge).

I reviewed this patch and found that this patch handles CLEAN CONNECTION as
simply NOP.

To disable event trigger for some DDLs, we need to move the code from
ProcessUtilitySlow() to Standard_ProcessUtility().    My previous patch was
not sufficient.   We need to move the code for XC-specific DDLs in this
manner.

I don't think this change affects regression test.

DDL handling was done as follows:

(outside) --> ProcessUtility()  /* ProcessUtility_hook is handled here */
                   --> standard_ProcessUtility() /* DDLs without event
trigger support are handled here */
                        --> ProcessUtilitySlow() /* DDLs with event trigger
support are handled here */

3_1_clean_con.patch just returns from standard_ProcessUtility() without
doing anything.   Unfortunately, CLEAN CONNECTION HANDLER is now in
ProcessUtilitySlow() and this should be moved back to
standard_ProcessUtility().

Any thoughts?

---
Koichi Suzuki


2013/9/30 Abbas Butt <abb...@en...>

> Here is the patch, forgot to attach it with the previous mail.
> Regards
>
>
>
> On Mon, Sep 30, 2013 at 7:23 AM, Abbas Butt <abb...@en...>
> wrote:
> >
> > Hi,
> > The current implementation of event triggers assumes that any statment
> > that is not handeled by the main switch-case in standard_ProcessUtility
> > supports event triggers.
> > CLEAN CONNECTION is a new statement added by XC and does not support
> > event triggers as of now.
> >
> > This patch is intended for the master_pg93_merge branch and applies
> cleanly
> > on top of the following two patches.
> > 20130924_01.patch and fix_for_pooler_socket_20130926.patch
> >
> > Regards
> > --
> > Abbas
> > Architect
> >
> > Ph: 92.334.5100153
> > Skype ID: gabbasb
> > www.enterprisedb.com
> >
> > Follow us on Twitter
> > @EnterpriseDB
> >
> > Visit EnterpriseDB for tutorials, webinars, whitepapers and more
>
>
>
>
> --
> --
> Abbas
> Architect
>
> Ph: 92.334.5100153
> Skype ID: gabbasb
> www.enterprisedb.com
>
> Follow us on Twitter
> @EnterpriseDB
>
> Visit EnterpriseDB for tutorials, webinars, whitepapers and more
>
>
> On Mon, Sep 30, 2013 at 7:23 AM, Abbas Butt <abb...@en...>
> wrote:
> >
> > Hi,
> > The current implementation of event triggers assumes that any statment
> > that is not handeled by the main switch-case in standard_ProcessUtility
> > supports event triggers.
> > CLEAN CONNECTION is a new statement added by XC and does not support
> > event triggers as of now.
> >
> > This patch is intended for the master_pg93_merge branch and applies
> cleanly
> > on top of the following two patches.
> > 20130924_01.patch and fix_for_pooler_socket_20130926.patch
> >
> > Regards
> > --
> > Abbas
> > Architect
> >
> > Ph: 92.334.5100153
> > Skype ID: gabbasb
> > www.enterprisedb.com
> >
> > Follow us on Twitter
> > @EnterpriseDB
> >
> > Visit EnterpriseDB for tutorials, webinars, whitepapers and more
>
>
>
>
> --
> --
> Abbas
> Architect
>
> Ph: 92.334.5100153
> Skype ID: gabbasb
> www.enterprisedb.com
>
> Follow us on Twitter
> @EnterpriseDB
>
> Visit EnterpriseDB for tutorials, webinars, whitepapers and more
>
>
> ------------------------------------------------------------------------------
> October Webinars: Code for Performance
> Free Intel webinars can help you accelerate application performance.
> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most
> from
> the latest Intel processors and coprocessors. See abstracts and register >
> http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>
>