From: Matt W. <MW...@XI...> - 2013-10-09 17:13:27
|
I've checked out latest with git and as you point out, there's no need for filio.h in proxy_main.c. There is a need for it in backend/pgxc/pgxcnode.c, so I've put in an "#ifdef HAVE_SYS_FILIO_H" to conditionally include filio.h. As soon as I complete a successful compilation of the latest pull from git and do some testing, I'll send the changes. Matt -----Original Message----- From: Michael Paquier [mailto:mic...@gm...] Sent: Tuesday, October 08, 2013 5:43 PM To: Matt Warner Cc: 鈴木 幸市; Postgres-XC Developers; Koichi Suzuki Subject: Re: [Postgres-xc-developers] Minor Fixes On Wed, Oct 9, 2013 at 9:13 AM, Matt Warner <MW...@xi...> wrote: > So I owe you a different patch for proxy_main.c as well. Btw, I can see why it is needed for pgxcnode.h as we use FIONREAD there, but why is it necessary to have an include to filio.h in proxy_main.c? I couldn't figure out why so I simply removed that from the patch committed. -- Michael |