Re: [Postgres-xc-developers] Minor Fixes

[Matt W. <MW...@XI...>]

I've taken configure.in and the M4 files from Postgres 9.3.0 and added in the XC-specific pieces. I hope to have not missed anything. I am testing to ensure I can perform a complete build with no issues before I send the updated files.

With respect to how to handle the include of filio.h and defining PGXC, I added in a pgxc_config.h.in file to handle both. This seems to be in line with how Postgres is handling these types of configs and only requires a simple ifdef for including filio.h.

So I owe you a different patch for proxy_main.c as well.

FYI,

Matt

-----Original Message-----
From: Matt Warner 
Sent: Tuesday, October 08, 2013 1:45 PM
To: 'Michael Paquier'
Cc: 鈴木 幸市; Postgres-XC Developers; Koichi Suzuki
Subject: RE: [Postgres-xc-developers] Minor Fixes

Yes, I have autoconf in place and have been putting in time here and there to update the configure.in.

I've also been looking at using autoconf to check for the presence of filio.h and go that route instead of specifying "__SOLARIS__". That would seem to be more portable.

Matt

-----Original Message-----
From: Michael Paquier [mailto:mic...@gm...] 
Sent: Tuesday, October 08, 2013 5:33 AM
To: Matt Warner
Cc: 鈴木 幸市; Postgres-XC Developers; Koichi Suzuki
Subject: Re: [Postgres-xc-developers] Minor Fixes

On Tue, Oct 8, 2013 at 9:03 PM, Michael Paquier
<mic...@gm...> wrote:
> 3 - Patch for makesgml
I pushed 3 as it was a trivial change as well, remains 1 and 2. Matt,
are you able to get an environment with autoconf 2.63? I cannot recall
on the top of my head an environment that has it... Ubuntu or CentOS
maintain autoconf archives, no?
-- 
Michael