From: Matt W. <MW...@XI...> - 2013-10-03 00:15:37
|
I can spend some time cleaning up configure.in if it's not stepping on anyone's toes. > On Oct 2, 2013, at 5:07 PM, "Michael Paquier" <mic...@gm...> wrote: > >> On Thu, Oct 3, 2013 at 9:04 AM, Matt Warner <MW...@xi...> wrote: >> Just to follow up, the change to configure.in is trivial to include "__SOLARIS__", but it looks to me like in the master branch that someone else is already hacking the configure file and not updating configure.in. >> >> Examples: >> Someone has set CFLAGS="-DPGXC $CFLAGS" in configure but not in configure.in >> PACKAGE_XC_VERSION, PGXC_MAJORVERSION, and PACKAGE_XC_VERSION are not defined in configure.in >> PACKAGE_BUGREPORT is set to pgs...@po... in configure.in >> >> Not trying to harp, just wondering how best to get this change incorporated? > Woah, I completely forgot about that... All those changes should be > incorporated in configure.in, definitely. That's one more thing to fix > on top of makesgml. > Regards, > -- > Michael |