Re: [Postgres-xc-developers] [master_pg93_merge] Patch # 4 Cannot convert int to define

[Ahsan H. <ahs...@en...>]

On Wed, Oct 2, 2013 at 12:55 PM, Koichi Suzuki <koi...@gm...>wrote:

> Here's revised patch.  I think we can apply this both to our master and
> REL1_1_STABLE.  (We didn't apply this change to REL1_0_STABLE).
>

Why do we need to apply this patch to 1_1 if the commit that is causing
this is part of 9.3 merge?


>
> Regards;
>
> ---
> Koichi Suzuki
>
>
> 2013/10/1 鈴木 幸市 <ko...@in...>
>
>>  Agree to remove #else .. .   Assert is defined under #ifdef
>> ASSERT_ENABLED internally and we don't have to worry about it.  Without
>> this symbol defined, Assert will be expanded to null and there's nothing
>> bothering.
>>
>>  Regards;
>> ---
>> Koichi Suzuki
>>
>>  On 2013/10/01, at 16:43, Ashutosh Bapat <ash...@en...<ashutosh..ba...@en...>>
>> wrote:
>>
>>  We should move the Assert under #ifdef ASSERT_ENABLED as well the
>> definition of old_outEnd. We should remove #else defining old_outEnd to
>> handle->outEnd which is utterly wrong.
>>
>>
>> On Mon, Sep 30, 2013 at 12:15 PM, Koichi Suzuki <koi...@gm...>wrote:
>>
>>> This change was made to eliminate a warning that old_outEnd is not used.
>>>   To improve both, the patch would be as attached.
>>>
>>>  Regards;
>>>
>>>  ---
>>> Koichi Suzuki
>>>
>>>
>>> 2013/9/30 Abbas Butt <abb...@en...>
>>>
>>>>  Hi,
>>>>
>>>> The commit ae29a966d3286d4e85b3adf162d00f9b1e8b8eae made this change
>>>> @@ -1132,7 +1132,11 @@ pgxc_node_send_parse(PGXCNodeHandle * handle,
>>>> const
>>>> char* statement,
>>>>         /* message length */
>>>>         int                     msgLen;
>>>>         int                     cnt_params;
>>>> +#if 0
>>>>         size_t          old_outEnd = handle->outEnd;
>>>> +#else
>>>> +#define old_outEnd handle->outEnd
>>>> +#endif
>>>>
>>>> which is incorrect. The purpose of the declaration and assignment is to
>>>> save the current value of handle->outEnd which is later changed in the
>>>> function.
>>>> This change makes the following assert in function pgxc_node_send_parse
>>>>     Assert(old_outEnd + ntohl(msgLen) + 1 == handle->outEnd);
>>>> fail when the query
>>>> CREATE TABLE junk AS VALUES (1), (2);
>>>> is run.
>>>>
>>>> This patch is required on master as well.
>>>>
>>>> Regards
>>>>
>>>> --
>>>> *Abbas*
>>>>  Architect
>>>>
>>>> Ph: 92.334.5100153
>>>>  Skype ID: gabbasb
>>>> www.enterprisedb.co
>>>> <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
>>>> *
>>>> Follow us on Twitter*
>>>> @EnterpriseDB
>>>>
>>>> Visit EnterpriseDB for tutorials, webinars,
>>>> whitepapers<http://www.enterprisedb.com/resources-community>and
>>>> more<http://www.enterprisedb.com/resources-community>
>>>>
>>>>
>>>> ------------------------------------------------------------------------------
>>>> October Webinars: Code for Performance
>>>> Free Intel webinars can help you accelerate application performance.
>>>> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the
>>>> most from
>>>> the latest Intel processors and coprocessors. See abstracts and
>>>> register >
>>>>
>>>> http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk
>>>> _______________________________________________
>>>> Postgres-xc-developers mailing list
>>>> Pos...@li...
>>>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>>>
>>>>
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> October Webinars: Code for Performance
>>> Free Intel webinars can help you accelerate application performance.
>>> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most
>>> from
>>> the latest Intel processors and coprocessors. See abstracts and register
>>> >
>>>
>>> http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk
>>> _______________________________________________
>>> Postgres-xc-developers mailing list
>>> Pos...@li...
>>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>>
>>>
>>
>>
>> --
>> Best Wishes,
>> Ashutosh Bapat
>> EnterpriseDB Corporation
>> The Postgres Database Company
>>
>> ------------------------------------------------------------------------------
>> October Webinars: Code for Performance
>> Free Intel webinars can help you accelerate application performance.
>> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most
>> from
>> the latest Intel processors and coprocessors. See abstracts and register >
>>
>> http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk_______________________________________________
>>
>> Postgres-xc-developers mailing list
>> Pos...@li...
>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>
>>
>>
>
>
> ------------------------------------------------------------------------------
> October Webinars: Code for Performance
> Free Intel webinars can help you accelerate application performance.
> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most
> from
> the latest Intel processors and coprocessors. See abstracts and register >
> http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>
>


-- 
Ahsan Hadi
Snr Director Product Development
EnterpriseDB Corporation
The Enterprise Postgres Company

Phone: +92-51-8358874
Mobile: +92-333-5162114

Website: www.enterprisedb.com
EnterpriseDB Blog: http://blogs.enterprisedb.com/
Follow us on Twitter: http://www.twitter.com/enterprisedb

This e-mail message (and any attachment) is intended for the use of the
individual or entity to whom it is addressed. This message contains
information from EnterpriseDB Corporation that may be privileged,
confidential, or exempt from disclosure under applicable law. If you are
not the intended recipient or authorized to receive this for the intended
recipient, any use, dissemination, distribution, retention, archiving, or
copying of this communication is strictly prohibited. If you have received
this e-mail in error, please notify the sender immediately by reply e-mail
and delete this message.