Re: [Postgres-xc-developers] Minor Fixes

[Michael P. <mic...@gm...>]

Hi,

I have set up a Solaris 11 instance in my lab... So here is some
feedback about those patches:
1) makesgml patch: strndup is available in Solaris 11, not in Solaris
<= 10. IMO this patch is not necessary for 2 reasons:
- makesgml should not use strndup.
- Solaris 10 was out in 2005... That's getting old.
So we should patch makesgml and remove the calls to strndup inside it
instead of creating a fake version of it as you do.
2) configure patch. Not necessary, and -1 for adding a flag like that.
Isn't it possible to use something like __sparc__ or __SOLARIS__
instead? You need also to keep in mind that configure is generated
with autoconfigure, so you would actually need to patch configure.in.
3) Makefile patch, actually this is not only a bug of Solaris, so I
went ahead and committed it. That's a good catch.
4) pgxcnode patch. This is indeed necessary for the compilation on
Solaris, FIONREAD is declared in filio.h, but I don't like the use of
a CFLAGS as you did in configure.
5) GTM proxy patch. It looks like you spotted a couple of other bugs!
There is a strange mixture of things returned from functions where
they shouldn't, and this is not only a problem with Solaris. I'll
rework it a bit and commit it later after checking that it works in my
lab.

Thanks for the report and really sorry for the delay in responding!
Regards,
-- 
Michael