[Postgres-xc-developers] [master_pg93_merge] Patch # 4 Cannot convert int to define

[Abbas B. <abb...@en...>]

Hi,

The commit ae29a966d3286d4e85b3adf162d00f9b1e8b8eae made this change
@@ -1132,7 +1132,11 @@ pgxc_node_send_parse(PGXCNodeHandle * handle, const
char* statement,
        /* message length */
        int                     msgLen;
        int                     cnt_params;
+#if 0
        size_t          old_outEnd = handle->outEnd;
+#else
+#define old_outEnd handle->outEnd
+#endif

which is incorrect. The purpose of the declaration and assignment is to
save the current value of handle->outEnd which is later changed in the
function.
This change makes the following assert in function pgxc_node_send_parse
    Assert(old_outEnd + ntohl(msgLen) + 1 == handle->outEnd);
fail when the query
CREATE TABLE junk AS VALUES (1), (2);
is run.

This patch is required on master as well.

Regards

-- 
*Abbas*
 Architect

Ph: 92.334.5100153
 Skype ID: gabbasb
www.enterprisedb.co
<http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
*
Follow us on Twitter*
@EnterpriseDB

Visit EnterpriseDB for tutorials, webinars,
whitepapers<http://www.enterprisedb.com/resources-community>and
more<http://www.enterprisedb.com/resources-community>