Re: [Postgres-xc-developers] Fwd: Re: Query Planning bug ?

[Koichi S. <koi...@gm...>]

This patch has been in process long and it seems that Tomonari provided
sufficient materials.

I'd like to know if there's any more issues on his work.

Regards;

---
Koichi Suzuki


2013/9/26 Tomonari Katsumata <kat...@po...>

> Hi,
>
> Does anyone check these patches?
> If there are no comments, please commit it.
>
> regards,
>
> ----------------------
> NTT Software Corporation
> Tomonari Katsumata
>
> -------- Original Message --------
> Subject:     Re: [Postgres-xc-developers] Query Planning bug ?
> Date:     Thu, 5 Sep 2013 21:34:32 +0900
> From:     Tomonari Katsumata <t.k...@gm...>
> To:     Tomonari Katsumata <katsumata.tomonari@po.ntts.**co.jp<kat...@po...>
> >
> CC:     Ashutosh Bapat <ashutosh.bapat@enterprisedb.**com<ash...@en...>>,
> pgxc-hackers mailing list <postgres-xc-developers@lists.**sourceforge.net<pos...@li...>
> >
>
>
> Hi,
>
> I'm sorry for long long leaving this thread alone.
> I've devided the patch to source part and regression part.
> (against f8e0f994bff1faefa9b1fc2f6e584a**1d3de70241)
>
> I did not change any process on source part.
> (revised_fqs_r4.patch)
>
> I added a script into src/test/regress/sql directory for
> changing regression part.
> (add_test_xc_misc.patch and execute_direct_regress.sh)
> When regression test runs, the script is executed instead of
> user defined function.
>
> Please check and commit it.
>
> regards,
> ------------------------
> NTT Software Corporation
> Tomonari Katsumata
>
>
> 2013/8/14 Tomonari Katsumata <katsumata.tomonari@po.ntts.**co.jp<kat...@po...>
> >
>
> > Hi Ashtosh,
> >
> > Thanks for your comment!
> >
> >
> > > The code changes are fine, but, the comment in
> pgxc_collect_RTE_walker()
> > > seems to specific. I think it should read, "create a copy of query's
> > range
> > > table, so that it can be linked with other RTEs in the collector's
> > context."
> > >
> > I've revised the comment as you suggested.
> >
> >
> > > In the test file, isn't there any way, you can add the offending
> statent
> > > without any wrapper function test_execute_direct_all_xc_****nodes()?
> We
>
> > should
> > > minimize the test-code to use only the minimal set of features. Since
> > this
> > > statement no more gets into infinite loop, please do not use the
> > statement
> > > timeout.
> >
> > I've gotten rid of using statement timeout.
> > But I couldn't come up any idea to testing more simply,
> > so the function is remaining as same as before patch.
> > Any ideas?
> >
> > Here is the new patch.
> > (against dec40008b3d689911566514614c511****1c0a61327d)
>
> >
> >
> > regards,
> > -------------
> > NTT Software Corporation
> > Tomonari Katsumata
> >
> >
>
>
>
>
> ------------------------------------------------------------------------------
> October Webinars: Code for Performance
> Free Intel webinars can help you accelerate application performance.
> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most
> from
> the latest Intel processors and coprocessors. See abstracts and register >
> http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>
>