Re: [Postgres-xc-developers] Query Planning bug ?

[Ashutosh B. <ash...@en...>]

Hi Tomonari,
The code changes are fine, but, the comment in pgxc_collect_RTE_walker()
seems to specific. I think it should read, "create a copy of query's range
table, so that it can be linked with other RTEs in the collector's context."

In the test file, isn't there any way, you can add the offending statent
without any wrapper function test_execute_direct_all_xc_nodes()? We should
minimize the test-code to use only the minimal set of features. Since this
statement no more gets into infinite loop, please do not use the statement
timeout.


On Sat, Aug 10, 2013 at 11:21 AM, Tomonari Katsumata <
t.k...@gm...> wrote:

> Hi,
>
> Sorry for begin for long waiting...
>
> I've revised my patch.
> The patch is revised_fqs_r2.patch.
> This is a patch for (e684b405779d0d348309d011249e4f5439f8d304)
>
>
> 2013/7/22 Tomonari Katsumata <kat...@po...>
>
>> Hi Abbas,
>>
>> (2013/07/19 20:37), Abbas Butt wrote:
>>
>
>
>>   > 1. The problem you reported seems to be caused by a missing
>> initialization
>>  > i.e.
>>  > query->rtable = NIL;
>>  > Can you please explain why did the server crash and how it got fixed by
>>  > having the above initialization statement?
>> The fix has nothing to do with server crash.
>> The test environment(2datanodes and 1cordinator) avoids the crash.
>>
>>  > It would be nice to add some comment on top of this line explaining it.
>>  >
>> To be honest, I don't know why my fix solves
>> my infinite loop problem.
>> I'll check it deeper and revise the patch.
>> Please wait for it.
>>
>
> It seems that my old fix is not good.
> Because all rtable data is ignored.
> So I changed the place to fix to pgxc_collect_RTE_walker in pgxcplan.c.
> When concating lists, I make a copy of a list.
> This was suggested by Ashtosh before, and I've confirm
> I can avoid my problem with this.
>
>
>>
>>  > 2. I think your patch unintentionally includes a change in
>>  > contrib/pgxc_ctl/signature.h
>>  >     Can you please remove it?
>>  >
>> OK, I'll do it.
>>
>
> done.
>
>
>>
>>  > 3. Can you please add a test case in say xc_misc.sql?
>>  >
>> OK, I'll do it too.
>>
>
> done.
>
> regards,
> -------------
> NTT Software Corporation
> Tomonari Katsumata
>
>
>
> ------------------------------------------------------------------------------
> Get 100% visibility into Java/.NET code with AppDynamics Lite!
> It's a free troubleshooting tool designed for production.
> Get down to code-level detail for bottlenecks, with <2% overhead.
> Download for free and get started troubleshooting in minutes.
> http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>
>


-- 
Best Wishes,
Ashutosh Bapat
EntepriseDB Corporation
The Postgres Database Company