Re: [Postgres-xc-developers] pgxc_ctl does not compile of Mac OS X

[Koichi S. <koi...@gm...>]

I still have a couple of questions on the patch.

1. Is this way portable enough?  It fixes the type of signal handler, which
is originally abstracted.

#ifdef <macos>
typedef void (*pgsigfunc) (int);
#else
#define pgsigfunc sighandler_t
#endif

...

#ifdef <macos>
typedef void (*pgsigfunc) (int)
#endif

Is the following okay?  Do you have any idea what symbol is used to
identify Mac-OS?   Makefile.global identifies Mac-OS as darwin but I
couldn't find how we can use this in the source code.

2. Are you okay if the patch is applied only to master, or do you need this
for 1.1 as well?

Regards;
---
Koichi Suzuki


2013/8/7 Koichi Suzuki <koi...@gm...>

> Thanks Nikhil for the patch.
>
> I have a couple of questions on this patch.
>
> 1, Did you run only pgxc_ctl on Mac OS and the others (all XC components)
> on Linux?
> 2. Did you really test that pgxc_ctl runs on Mac OS?   pgxc_ctl uses so
> many system() functions so it is shell script dependent.   I do hope all
> the shell scripts used in pgxc_ctl works in Mac OS too.
>
> Regards;
>
>
>
>
> 2013/8/7 Nikhil Sontakke <ni...@st...>
>
>> Hi Suzuki san,
>>
>> PFA, patch which allows pgxc_ctl to compile on OS X.
>>
>> Regards,
>> Nikhils
>> --
>> StormDB - http://www.stormdb.com
>> The Database Cloud
>>
>> ------------------------------------------------------------------------------
>> Get 100% visibility into Java/.NET code with AppDynamics Lite!
>> It's a free troubleshooting tool designed for production.
>> Get down to code-level detail for bottlenecks, with <2% overhead.
>> Download for free and get started troubleshooting in minutes.
>>
>> http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
>> _______________________________________________
>> Postgres-xc-developers mailing list
>> Pos...@li...
>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>
>>
>