Re: [Postgres-xc-developers] [JDBC Regression] Fix wrongly written boolean tests

[Abbas B. <abb...@en...>]

PFA revised patch.

On Tue, Aug 6, 2013 at 7:21 AM, Masataka Saito <pg...@gm...> wrote:

> I meant append a serial column to the tail of tables.
> Then you need not to modify INSERTs and SELECT targets because they
> want first column to test.
>
> e.g.
>   TestUtil.createTable(con, "testbool", "i serial, a boolean");
>      ->   TestUtil.createTable(con, "testbool", "a boolean, i serial");
>
>   stmt.executeUpdate("INSERT INTO testboolstring VALUES('true')");
>      ->   (needless to change)
>
>   ResultSet rs = con.createStatement().executeQuery("select * from
> testbool");
>      ->  ResultSet rs = con.createStatement().executeQuery("select *
> from testbool");
>            rs.close();
>            rs = con.createStatement().executeQuery("select * from
> testbool order by i");
>       (Of course, you can branch statement like you did.)
>
> Regards.
>
> On Mon, Aug 5, 2013 at 9:16 PM, Abbas Butt <abb...@en...>
> wrote:
> > Please use this patch for review, attached the wrong patch file with the
> > previous mail.
> >
> >
> > On Mon, Aug 5, 2013 at 4:59 PM, Abbas Butt <abb...@en...>
> > wrote:
> >>
> >> Attached please find a revised patch according to your suggestion.
> >> I am holding the rest of the patches till you review this one, because
> we
> >> need similar changes for integer, date, time and time-stamp tests.
> >>
> >>
> >> On Mon, Aug 5, 2013 at 12:45 PM, Masataka Saito <pg...@gm...>
> wrote:
> >>>
> >>> Hi,
> >>>
> >>> I feel feckless for sorting assertins.
> >>>
> >>> I propose appending a serial column to test tables and SELECT rows
> >>> ORDERED BY it.
> >>> I think this idea makes costless and it doesn't against to the gist of
> >>> the test.
> >>>
> >>> Regards.
> >>>
> >>> On Fri, Aug 2, 2013 at 8:47 PM, Abbas Butt <
> abb...@en...>
> >>> wrote:
> >>> > Hi,
> >>> > PFA patch to fix wrongly written boolean tests, patch comments
> explain
> >>> > the
> >>> > errors and the fix.
> >>> >
> >>> > --
> >>> > Abbas
> >>> > Architect
> >>> >
> >>> > Ph: 92.334.5100153
> >>> > Skype ID: gabbasb
> >>> > www.enterprisedb.com
> >>> >
> >>> > Follow us on Twitter
> >>> > @EnterpriseDB
> >>> >
> >>> > Visit EnterpriseDB for tutorials, webinars, whitepapers and more
> >>> >
> >>> >
> >>> >
> ------------------------------------------------------------------------------
> >>> > Get your SQL database under version control now!
> >>> > Version control is standard for application code, but databases
> havent
> >>> > caught up. So what steps can you take to put your SQL databases under
> >>> > version control? Why should you start doing it? Read more to find
> out.
> >>> >
> >>> >
> http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk
> >>> > _______________________________________________
> >>> > Postgres-xc-developers mailing list
> >>> > Pos...@li...
> >>> > https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
> >>> >
> >>
> >>
> >>
> >>
> >> --
> >> --
> >> Abbas
> >> Architect
> >>
> >> Ph: 92.334.5100153
> >> Skype ID: gabbasb
> >> www.enterprisedb.com
> >>
> >> Follow us on Twitter
> >> @EnterpriseDB
> >>
> >> Visit EnterpriseDB for tutorials, webinars, whitepapers and more
> >
> >
> >
> >
> > --
> > --
> > Abbas
> > Architect
> >
> > Ph: 92.334.5100153
> > Skype ID: gabbasb
> > www.enterprisedb.com
> >
> > Follow us on Twitter
> > @EnterpriseDB
> >
> > Visit EnterpriseDB for tutorials, webinars, whitepapers and more
>



-- 
-- 
*Abbas*
 Architect

Ph: 92.334.5100153
 Skype ID: gabbasb
www.enterprisedb.co
<http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
*
Follow us on Twitter*
@EnterpriseDB

Visit EnterpriseDB for tutorials, webinars,
whitepapers<http://www.enterprisedb.com/resources-community>and
more<http://www.enterprisedb.com/resources-community>