Re: [Postgres-xc-developers] [JDBC Regression] Fix for XC does not support serializable transactions

[Abbas B. <abb...@en...>]

PFA revised patch.

On Mon, Aug 5, 2013 at 3:22 PM, Masataka Saito <pg...@gm...> wrote:

> On Mon, Aug 5, 2013 at 6:35 PM, Abbas Butt <abb...@en...>
> wrote:
> >
> >
> > On Mon, Aug 5, 2013 at 2:18 PM, Masataka Saito <pg...@gm...> wrote:
> >>
> >> The patch will work fine.
> >>
> >> But this is my basal question:
> >> setTransactionIsolation(Connection.TRANSACTION_SERIALIZABLE) after XC
> >> block doesn't raise an exception, I know.
> >> Is it right shelving unsupported isolation level without an error?
> >
> >
> > It is due to already checked in code
> >
> > void
> > assign_XactIsoLevel(const char *newval, void *extra)
> > {
> >     XactIsoLevel = *((int *) extra);
> > #ifdef PGXC
> >     /*
> >      * PGXCTODO - PGXC does not support 9.1 serializable transactions yet
> >      */
> >     if (XactIsoLevel == XACT_SERIALIZABLE)
> >         XactIsoLevel = XACT_REPEATABLE_READ;
> > #endif
> > }
> >
> > I think we already have a source forge ticket to deal with this XC
> > limitation.
>
> Thanks.
> I know it caused by XC limitation.
>
> I thought that unsupported level should be denied by
> check_XactIsoLevel rather than modified at assign_XactIsoLevel.
> I shouldn't grumble reviewed commit. I'm sorry to be bothering you with
> this.
>
> Reading check_XactIsoLevel, I found XC doesn't support SERIALIZABLE
> but supports other levels.
> I think you could replace SERIALIZABLE to other transaction level
> (e.g. REPEATABLE READ) instead of skipping.
> It is more natural by the gist of the test case.
>
> >
> >
> >>
> >>
> >> On Fri, Aug 2, 2013 at 4:36 PM, Abbas Butt <abb...@en...
> >
> >> wrote:
> >> > Hi,
> >> > PFA patch to make sure that JDBC regression skips tests for
> serializable
> >> > transactions.
> >> >
> >> > --
> >> > Abbas
> >> > Architect
> >> >
> >> > Ph: 92.334.5100153
> >> > Skype ID: gabbasb
> >> > www.enterprisedb.com
> >> >
> >> > Follow us on Twitter
> >> > @EnterpriseDB
> >> >
> >> > Visit EnterpriseDB for tutorials, webinars, whitepapers and more
> >> >
> >> >
> >> >
> ------------------------------------------------------------------------------
> >> > Get your SQL database under version control now!
> >> > Version control is standard for application code, but databases havent
> >> > caught up. So what steps can you take to put your SQL databases under
> >> > version control? Why should you start doing it? Read more to find out.
> >> >
> >> >
> http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk
> >> > _______________________________________________
> >> > Postgres-xc-developers mailing list
> >> > Pos...@li...
> >> > https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
> >> >
> >
> >
> >
> >
> > --
> > --
> > Abbas
> > Architect
> >
> > Ph: 92.334.5100153
> > Skype ID: gabbasb
> > www.enterprisedb.com
> >
> > Follow us on Twitter
> > @EnterpriseDB
> >
> > Visit EnterpriseDB for tutorials, webinars, whitepapers and more
>



-- 
-- 
*Abbas*
 Architect

Ph: 92.334.5100153
 Skype ID: gabbasb
www.enterprisedb.co
<http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
*
Follow us on Twitter*
@EnterpriseDB

Visit EnterpriseDB for tutorials, webinars,
whitepapers<http://www.enterprisedb.com/resources-community>and
more<http://www.enterprisedb.com/resources-community>