Re: [Postgres-xc-developers] [JDBC Regression] Patch to skip tests for features not supported by XC

[Abbas B. <abb...@en...>]

PFA a revised patch in which I have done the following change.
Instead of creating the flag variable to indicate that the tests are being
run for XC in Driver.java.in, I have created a function in TestUtil.java
that returns the state of the property created in build.xml.
This is to make sure that the changes are restricted to the test suite only.
Thanks Masataka for reviewing the patch.


On Wed, Jul 24, 2013 at 12:06 PM, Abbas Butt <abb...@en...>wrote:

>
>
> On Wed, Jul 24, 2013 at 10:09 AM, Michael Paquier <
> mic...@gm...> wrote:
>
>>
>>
>>
>> On Wed, Jul 24, 2013 at 2:00 PM, Ashutosh Bapat <
>> ash...@en...> wrote:
>>
>>> For the sake of everyone's understanding, it would be nice if you can
>>> describe the general structure of JDBC testcases (if there is write-up
>>> available point to it) and description of specific problems. E.g. what is
>>> this build.xml, what does it do? What is the particular problem and so on.
>>>
>> +1. Why is this patch for jdbc here?
>>
>
> The patch is not for JDBC, it is for JDBC Regression. Our intention is to
> run JDBC regression against XC, and we need to change a few things in the
> test suite to run it like I have mentioned in my previous email in this
> chain.
>
>
>> Are you guys planning to fork jdbc for XC?
>>
>
> No.
>
>
>>  I am still not able to read in people's mind, especially when they are a
>> couple of thousand kilometers far, so any clarification would be good.
>>
>
> We intend to send small patches so that the review is easy and then
> combine them all to make a single patch that would be required to be
> applied to PG JDBC regression suite before it runs against XC with minimal
> failures.
>
>
>
>> --
>> Michael
>>
>
>
>
> --
> --
> *Abbas*
>  Architect
>
> Ph: 92.334.5100153
>  Skype ID: gabbasb
> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
> *
> Follow us on Twitter*
> @EnterpriseDB
>
> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>



-- 
-- 
*Abbas*
 Architect

Ph: 92.334.5100153
 Skype ID: gabbasb
www.enterprisedb.co
<http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
*
Follow us on Twitter*
@EnterpriseDB

Visit EnterpriseDB for tutorials, webinars,
whitepapers<http://www.enterprisedb.com/resources-community>and
more<http://www.enterprisedb.com/resources-community>